From: Dmitry Gutov <dmitry@gutov.dev>
To: Olivier Certner <ocert.dev@free.fr>, Eli Zaretskii <eliz@gnu.org>
Cc: 62693@debbugs.gnu.org
Subject: bug#62693: 28.2; VC: CVS: Fix lost file reporting and enable reverting it
Date: Sat, 15 Apr 2023 01:59:28 +0300 [thread overview]
Message-ID: <b7d1e6b9-4a12-0423-afad-d746dbd3e0de@gutov.dev> (raw)
In-Reply-To: <12836994.tY86fQioq2@ravel>
On 13/04/2023 19:40, Olivier Certner wrote:
> Hi,
>
> Thanks for looking at this.
>
>> - Could you explain what kind of files are not listed and when? I'm
>> guessing this has to do with the file name? I've tried to reproduce the
>> problem with a file name that contained a space, and couldn't see it.
>
> It's not that files are not listed, they are so always. As said, the problem
> is their name. For example, if I remove an INSTALL file in a repository,
> `INSTALL' is the name listed in a VC dir buffer, *quotes included*. Then, no
> VC operation can work because there is indeed no file by this name (with
> quotes, both in the filesystem or known by CVS).
So the actual file name is not the problem -- the problem happens with
removed files?
Okay, I can see that now: when the file is removed, it's displayed
(incorrectly) with quotes around its name. Patches 2 and 3 do fix the
remove - vc-dir - vc-revert scenario.
Eli, do we want these fixes in emacs-29? These are again not
regressions, but I'm guessing users of CVS are foremost to benefit from
adding this to the upcoming release.
>> - Could you give an example of the repository CVS root which is
>> recognized by the current code incorrectly?
>
> Just run (vc-cvs-parse-root "/your/local/path/to/some/CVS/repo") and you'll
> see...
>
> I've found more occurences of problems with this function, so my initial fix
> is not enough. I went ahead and rewrote it completely. So please forget about
> the original first patch, and consider it replaced by the attached one. The
> commit message there explains how you can reproduce the bugs I found and shows
> that the new version fixes them.
Thank you. What was the effect of wrong local/nonlocal recognition,
though? Some misbehavior related to cvs-stay-local?
Regarding the new patch, it's great to see the list of examples, but
could you instead move it to a test or several inside
test/lisp/vc/vc-cvs-tests.el? This file does not exist yet, but you can
use vc-git-test.el as an example, in the same directory.
next prev parent reply other threads:[~2023-04-14 22:59 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-06 9:51 bug#62693: 28.2; VC: CVS: Fix lost file reporting and enable reverting it Olivier Certner
2023-04-12 22:48 ` Dmitry Gutov
2023-04-13 16:40 ` Olivier Certner
2023-04-14 22:59 ` Dmitry Gutov [this message]
2023-04-15 9:28 ` Eli Zaretskii
2023-04-17 9:24 ` Olivier Certner
2023-04-17 17:48 ` Eli Zaretskii
2023-04-17 20:10 ` Olivier Certner
2023-04-19 0:54 ` Dmitry Gutov
2023-04-19 8:10 ` Olivier Certner
2023-04-20 8:55 ` Eli Zaretskii
2023-04-20 9:42 ` Olivier Certner
2023-04-20 10:22 ` Dmitry Gutov
2023-04-17 8:04 ` Olivier Certner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b7d1e6b9-4a12-0423-afad-d746dbd3e0de@gutov.dev \
--to=dmitry@gutov.dev \
--cc=62693@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=ocert.dev@free.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.