From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Paul Eggert Newsgroups: gmane.emacs.bugs Subject: bug#39248: format-time-string ignores user's preferred locale Date: Sun, 26 Jan 2020 00:35:31 -0800 Organization: UCLA Computer Science Department Message-ID: References: <68077D50-2E85-4FB7-92EF-96C636D6DE6E@paulwrankin.com> <837e1it5el.fsf@gnu.org> <3ov9p1j0c4.fsf@fencepost.gnu.org> <20200125111805.GA7816@breton.holly.idiocy.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="10419"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 Cc: "Paul W. Rankin" , 39248-done@debbugs.gnu.org To: Alan Third Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Jan 26 09:36:17 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ivdOy-0002eq-JI for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 26 Jan 2020 09:36:16 +0100 Original-Received: from localhost ([::1]:60430 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ivdOx-0005DS-Or for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 26 Jan 2020 03:36:15 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:52697) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ivdOk-0005DD-Ue for bug-gnu-emacs@gnu.org; Sun, 26 Jan 2020 03:36:03 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ivdOj-0003ra-UY for bug-gnu-emacs@gnu.org; Sun, 26 Jan 2020 03:36:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:50522) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ivdOj-0003rT-RV for bug-gnu-emacs@gnu.org; Sun, 26 Jan 2020 03:36:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ivdOj-0004zP-PH for bug-gnu-emacs@gnu.org; Sun, 26 Jan 2020 03:36:01 -0500 Resent-From: Paul Eggert Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Sun, 26 Jan 2020 08:36:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 39248 X-GNU-PR-Package: emacs Mail-Followup-To: 39248@debbugs.gnu.org, eggert@cs.ucla.edu, hello@paulwrankin.com Original-Received: via spool by 39248-done@debbugs.gnu.org id=D39248.158002773919145 (code D ref 39248); Sun, 26 Jan 2020 08:36:01 +0000 Original-Received: (at 39248-done) by debbugs.gnu.org; 26 Jan 2020 08:35:39 +0000 Original-Received: from localhost ([127.0.0.1]:56495 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ivdON-0004yj-FX for submit@debbugs.gnu.org; Sun, 26 Jan 2020 03:35:39 -0500 Original-Received: from zimbra.cs.ucla.edu ([131.179.128.68]:40198) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ivdOM-0004yX-AZ for 39248-done@debbugs.gnu.org; Sun, 26 Jan 2020 03:35:38 -0500 Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 63D0B16007A; Sun, 26 Jan 2020 00:35:32 -0800 (PST) Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id u8173aB7AKXX; Sun, 26 Jan 2020 00:35:31 -0800 (PST) Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id A2F1916007F; Sun, 26 Jan 2020 00:35:31 -0800 (PST) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id EZp1mHSRjDmc; Sun, 26 Jan 2020 00:35:31 -0800 (PST) Original-Received: from [192.168.1.9] (cpe-23-242-74-103.socal.res.rr.com [23.242.74.103]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id 70AE916007A; Sun, 26 Jan 2020 00:35:31 -0800 (PST) In-Reply-To: <20200125111805.GA7816@breton.holly.idiocy.org> Content-Language: en-US X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:175291 Archived-At: On 1/25/20 3:18 AM, Alan Third wrote: > On Thu, Jan 23, 2020 at 11:35:20PM -0800, Paul Eggert wrote: >> #ifdef HAVE_NS >> ns_pool =3D ns_alloc_autorelease_pool (); >> -#ifdef NS_IMPL_GNUSTEP >> - /* GNUstep stupidly resets our locale settings after we made them. = */ >> - fixup_locale (); >> -#endif >=20 > Hi Paul, this LGTM, but I=E2=80=99m just curious if you=E2=80=99re sure= we don=E2=80=99t need > that code above any more? Although I don't use GNUstep and haven't tested the code, as I recall GNU= step=20 initializes itself on its first call (which is why the fixup_locale call = was=20 there, as ns_alloc_autorelease_pool was the first call to GNUstep), and i= f so=20 then we don't need fixup_locale there anymore since we now call fixup_loc= ale=20 earlier, just after calling ns_init_locale which calls NSLocale currentlo= cale=20 should cause GNUstep to initialize itself. If I'm wrong feel free to put that code back in, but in the meantime I in= stalled=20 the patch as-is, as Paul R. reports that it works for him.