From: Paul Eggert <eggert@cs.ucla.edu>
To: Andreas Schwab <schwab@linux-m68k.org>
Cc: Glenn Morris <rgm@gnu.org>, emacs-devel@gnu.org
Subject: Re: master 37940b3: min and max now return one of their arguments
Date: Wed, 8 Mar 2017 10:47:23 -0800 [thread overview]
Message-ID: <b7813c5e-1b57-3050-df8c-614378c88cdc@cs.ucla.edu> (raw)
In-Reply-To: <87efy8188w.fsf@linux-m68k.org>
On 03/08/2017 12:29 AM, Andreas Schwab wrote:
> ??? You removed the documentation!
Ah, sorry, right you are; I'd forgotten that. Thanks for restoring it.
However, I don't understand the point of the code part of your change to
minmax_driver. Since arithcompare already checks that its arguments are
numbers or markers, it's redundant for minmax driver to do so as well,
so CHECK_NUMBER_OR_FLOAT_COERCE_MARKER call that you added to
arithcompare will slow Emacs down slightly. Is there some reason why the
slower code is necessary?
next prev parent reply other threads:[~2017-03-08 18:47 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20170307012700.3354.30219@vcs0.savannah.gnu.org>
[not found] ` <20170307012701.1C05D23F1F@vcs0.savannah.gnu.org>
2017-03-07 15:04 ` [Emacs-diffs] master 37940b3: min and max now return one of their arguments Stefan Monnier
2017-03-08 3:04 ` John Wiegley
2017-03-08 6:08 ` Paul Eggert
2017-03-08 15:54 ` Eli Zaretskii
2017-03-08 22:04 ` Paul Eggert
2017-03-09 16:10 ` Eli Zaretskii
2017-03-09 16:25 ` Clément Pit-Claudel
2017-03-09 16:54 ` Eli Zaretskii
2017-03-09 17:09 ` Clément Pit-Claudel
2017-03-09 17:45 ` Paul Eggert
2017-03-09 18:34 ` Eli Zaretskii
2017-03-07 19:08 ` Glenn Morris
2017-03-08 4:26 ` Tino Calancha
2017-03-08 5:27 ` Paul Eggert
2017-03-08 7:54 ` Andreas Schwab
2017-03-08 8:29 ` Andreas Schwab
2017-03-08 18:47 ` Paul Eggert [this message]
2017-03-08 22:10 ` Andreas Schwab
2017-03-11 14:46 ` Andreas Politz
2017-03-12 1:46 ` Tino Calancha
2017-03-12 23:33 ` Andreas Politz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b7813c5e-1b57-3050-df8c-614378c88cdc@cs.ucla.edu \
--to=eggert@cs.ucla.edu \
--cc=emacs-devel@gnu.org \
--cc=rgm@gnu.org \
--cc=schwab@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.