From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Gregory Heytings Newsgroups: gmane.emacs.devel Subject: Re: master 616da8fa8e: Merge branch 'feature/fix-the-long-lines-display-bug' Date: Thu, 21 Jul 2022 13:36:34 +0000 Message-ID: References: <165839997103.16342.15946302166780212268@vcs2.savannah.gnu.org> <20220721103932.9604DC0F20B@vcs2.savannah.gnu.org> <87y1wm7ipn.fsf@yahoo.com> <83v8rqmyeq.fsf@gnu.org> <87lesm7gnd.fsf@yahoo.com> <875yjq7g11.fsf@yahoo.com> Mime-Version: 1.0 Content-Type: text/plain; format=flowed; charset=us-ascii Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="14091"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Eli Zaretskii , emacs-devel@gnu.org To: Po Lu Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Jul 21 15:45:39 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oEWUk-0003VY-Ta for ged-emacs-devel@m.gmane-mx.org; Thu, 21 Jul 2022 15:45:38 +0200 Original-Received: from localhost ([::1]:45288 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oEWUj-0007oa-CN for ged-emacs-devel@m.gmane-mx.org; Thu, 21 Jul 2022 09:45:37 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:50650) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oEWM2-0001R8-WD for emacs-devel@gnu.org; Thu, 21 Jul 2022 09:36:40 -0400 Original-Received: from heytings.org ([95.142.160.155]:44818) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oEWM1-0000br-61; Thu, 21 Jul 2022 09:36:38 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=heytings.org; s=20220101; t=1658410594; bh=cJMwJZ8IJ4/JigVCQDj0dt3NGEdzhQd0TcHOZKijya8=; h=Date:From:To:cc:Subject:In-Reply-To:Message-ID:References:From; b=K5eWFuJV8v4wVJBBRVsv4QJYHY6XGIvpFXXlJ5NnI4EKw/CB4hPKwMHfkorAk62xb 1Cfbg2B9EnJuYxhzuoRTnhRjFCg/3Ua6yRefCkPiT/qB39lABUz1HNmedJJp1Nz9FB QjTwrCJ47TdwJOkmYGERbUjAB18wh86gZyc8rrLn6Xxhm5a1qijZqxljCY8TVA6AUB l/Ki9LJs08UYoZOGV23hMR/V8XSWNWhsi71/kYIUo9sn+38dvP/ixkbifBdhtnK6U6 bFBtwdhGuDUMUBjnWW9xa2Xebib9EMUlduD25eRodTszWxvG88t9JmROonkZdJ+HMU ju2sTOaSHnn6g== In-Reply-To: <875yjq7g11.fsf@yahoo.com> Received-SPF: pass client-ip=95.142.160.155; envelope-from=gregory@heytings.org; helo=heytings.org X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:292362 Archived-At: >> One of the design principles of that feature is that it should be as >> transparent as possible, and it is. The point of adding a variable to >> control the feature was to avoid introducing an arbitrary constant at >> the C level, and also to allow users who really enjoy slowdowns to turn >> these optimizations off > > Then why is it a number and not a boolean? A number that I don't know > how to change is as good as a constant. > You don't have to change it. >> Vertical-motion is not slow anymore. > > Could you please show a file where I can appreciate a noticable speed-up > in vertical-motion? > Are you kidding? Try, for example: https://github.com/Wilfred/ReVo-utilities/blob/a4bdc40dd2656c496defc461fc19c403c8306d9f/revo-export/dictionary.json?raw=true No type M-> C-p. Before the merge this takes about 50 seconds (about 20 seconds for M-> and 30 seconds for C-p). Now it is instantaneous. And that's only a moderately large file (20 MB). Try the same with a 1 GB file, and M-> will never end. Meanwhile, could you please fix the build breakage introduced by a29a3ad55d?