From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Gregory Heytings Newsgroups: gmane.emacs.devel Subject: Re: master 616da8fa8e: Merge branch 'feature/fix-the-long-lines-display-bug' Date: Thu, 21 Jul 2022 13:50:41 +0000 Message-ID: References: <165839997103.16342.15946302166780212268@vcs2.savannah.gnu.org> <20220721103932.9604DC0F20B@vcs2.savannah.gnu.org> <87y1wm7ipn.fsf@yahoo.com> <83v8rqmyeq.fsf@gnu.org> <87lesm7gnd.fsf@yahoo.com> <875yjq7g11.fsf@yahoo.com> <83pmhymvpq.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; format=flowed; charset=us-ascii Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="7805"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Po Lu , emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Jul 21 15:51:30 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oEWaP-0001rz-Bh for ged-emacs-devel@m.gmane-mx.org; Thu, 21 Jul 2022 15:51:29 +0200 Original-Received: from localhost ([::1]:53144 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oEWaN-0004wu-8w for ged-emacs-devel@m.gmane-mx.org; Thu, 21 Jul 2022 09:51:27 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:53766) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oEWZi-0004Du-Eu for emacs-devel@gnu.org; Thu, 21 Jul 2022 09:50:46 -0400 Original-Received: from heytings.org ([95.142.160.155]:44840) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oEWZg-00032q-RL; Thu, 21 Jul 2022 09:50:46 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=heytings.org; s=20220101; t=1658411442; bh=WAJv9tu8xgbgLwxV7GAZ513xsJVxlpD9tlh3sGP4VqU=; h=Date:From:To:cc:Subject:In-Reply-To:Message-ID:References:From; b=nc8K+6UXaPoOpGGPkia7F206mRTEw4693osVhHgvL8lCuZwMDVaGsI++IANOuLz4Z 1eCuFqOsgTz+b0yabX86u3adzJFs2KJG7mm0jRthJTB5yLMDEaT4TlkrUYMOc/QO8R NAhDR+TQ4UKiDxFIpHUKURQGZBxSkpjwUlRIg4cdjW3g3I2orIG9rFkAuAJRfPBC35 /g7z8n2UXDDnno1mEtkM6iq70Nzg03x2Dr8a1+U7ASeclCLuYk1ytSdFrtpH3vTRuK Qyh83HNKVtz62VzM/+/Dz0L+8d+xP3wgbV1rMPn6DSQ+m6GIMKGkKS1hpCda/y3IJ8 9AUvO2KfUYysA== In-Reply-To: <83pmhymvpq.fsf@gnu.org> Received-SPF: pass client-ip=95.142.160.155; envelope-from=gregory@heytings.org; helo=heytings.org X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:292363 Archived-At: >> Then why is it a number and not a boolean? A number that I don't know >> how to change is as good as a constant. > > If we decide that there's no reason for users to change the number, we > might consider making it a boolean, indeed. > Not a boolean, because even if there is no reason for users to change the number, there are at least three useful values: always disabled, enabled iff the buffer contains long lines, always enabled. Which you can get now by setting the variable to nil, 10000, and 0. I'm also pretty sure we would have bug reports if what a "long line" is was hardcoded. So from my point of view the variable is fine as it is.