From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Jostein =?UTF-8?Q?Kj=C3=B8nigsen?= Newsgroups: gmane.emacs.bugs Subject: bug#59831: 29.0.60; typescript-ts-mode: Variables, properties & fields are often not fontified Date: Wed, 7 Dec 2022 10:42:20 +0100 Message-ID: References: <676d4e95-dfe3-5ced-60a3-b2387512ee63@secure.kjonigsen.net> <87v8mqxmfo.fsf@thornhill.no> <2151efc1-b6f6-4e0d-7416-cccae9277a34@secure.kjonigsen.net> <87bkoifbj3.fsf@thornhill.no> <848e54b0-4b74-2d85-064d-bf8dc792d1e8@secure.kjonigsen.net> <87mt7zzhg6.fsf@thornhill.no> Reply-To: jostein@kjonigsen.net Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------P00yLdQ52eHovmb8ZNlUwYQO" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="35216"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.1 Cc: 59831@debbugs.gnu.org To: Theodor Thornhill , jostein@kjonigsen.net, Yuan Fu Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Dec 07 10:43:35 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1p2qxg-0008wR-Cr for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 07 Dec 2022 10:43:35 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p2qxG-00070U-4c; Wed, 07 Dec 2022 04:43:06 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p2qxE-0006zv-OP for bug-gnu-emacs@gnu.org; Wed, 07 Dec 2022 04:43:05 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1p2qxC-0003cw-3X for bug-gnu-emacs@gnu.org; Wed, 07 Dec 2022 04:43:04 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1p2qxB-0001bX-P0 for bug-gnu-emacs@gnu.org; Wed, 07 Dec 2022 04:43:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Jostein =?UTF-8?Q?Kj=C3=B8nigsen?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 07 Dec 2022 09:43:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59831 X-GNU-PR-Package: emacs Original-Received: via spool by 59831-submit@debbugs.gnu.org id=B59831.16704061556160 (code B ref 59831); Wed, 07 Dec 2022 09:43:01 +0000 Original-Received: (at 59831) by debbugs.gnu.org; 7 Dec 2022 09:42:35 +0000 Original-Received: from localhost ([127.0.0.1]:48892 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p2qwl-0001bI-1C for submit@debbugs.gnu.org; Wed, 07 Dec 2022 04:42:35 -0500 Original-Received: from wout1-smtp.messagingengine.com ([64.147.123.24]:55393) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p2qwk-0001bA-1o for 59831@debbugs.gnu.org; Wed, 07 Dec 2022 04:42:34 -0500 Original-Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.west.internal (Postfix) with ESMTP id 3E7CF320024A; Wed, 7 Dec 2022 04:42:25 -0500 (EST) Original-Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Wed, 07 Dec 2022 04:42:25 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= secure.kjonigsen.net; h=cc:cc:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:reply-to:sender:subject:subject:to:to; s=fm3; t= 1670406144; x=1670492544; bh=M+CVXV80ESa2eeuv0g6pAnMDU6wfoG7eeqv mokwcvjE=; b=bAeKhDOaZiFdRRVcgi33l0hycoLa+gipOj9W0jQG6+/S1cEYyR8 tJMDhVcXW8RBsWEuSRWxlDTAWVGcFQpx/7jQGhKn3j/cB7fH0/bMy5HfXf8W7aCR q1LndVCj2XTDtsUO8I+pqrVMRosbWteTt2/K9JjlyrcvQlyy/Cp1oAzx0O73fhG/ OPGOYgov914M9/uXh4JRdjZhIOiUeCU8lPPZbszqWPnbCW9DJh6Jk16EyE4zNvVb lEaUnifivtGy7YpRhW9P4QPKIWasxwJPJsyaAe+UutkED23n4u11ugG29ikJiNMP OKAQYhIacZEV+xw7ccIm4rAko4hqsFWhffg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; t=1670406144; x=1670492544; bh=M+CVXV80ESa2e euv0g6pAnMDU6wfoG7eeqvmokwcvjE=; b=QwZa3MS5GQ4e6S2eDoUFcTCI+PVca lO5ZHy3bBy0RXUlk/fLUeA4yoQXAPqUW23R9Hv9zn6aM0AuM28M9dBjOSWzCLbf3 2BnsLjfYRq8tYqRqWjmDXKNx/ZCV2/THD8SxzK0pv8sogRb/U87FOrpzhygyHb87 jIHfkzv1f7MeGKB3WM88UACKlwS1XSHiYCu2j/SZhKJtFULZ9NPBGD/EvfkNIc3h aNqWhEw5JfOROCrXVo2EPlemxZwWdocrLvmf+xDuy6XsmHGzgiboqIShhe0XCHLn 2rn5dhT5RTLIxn6/AMWLAdgZ173axXYVveVwQwk7t430vY00+vXRUxiUQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrudekgddtiecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpegtkfffgggfrhfuvfevfhfhjgesmhdtreertdefjeenucfhrhhomheplfhoshht vghinhcumfhjpphnihhgshgvnhcuoehjohhsthgvihhnsehsvggtuhhrvgdrkhhjohhnih hgshgvnhdrnhgvtheqnecuggftrfgrthhtvghrnhepleeihefgveefffelkeelleffffdt feevleetheefgfdtgfdtfeeiveekgfevkedvnecuvehluhhsthgvrhfuihiivgeptdenuc frrghrrghmpehmrghilhhfrhhomhepjhhoshhtvghinhesshgvtghurhgvrdhkjhhonhhi ghhsvghnrdhnvght X-ME-Proxy: Feedback-ID: ib2f84088:Fastmail Original-Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 7 Dec 2022 04:42:23 -0500 (EST) Content-Language: nb-NO In-Reply-To: <87mt7zzhg6.fsf@thornhill.no> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:250172 Archived-At: This is a multi-part message in MIME format. --------------P00yLdQ52eHovmb8ZNlUwYQO Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 07.12.2022 10:33, Theodor Thornhill wrote: > > Do we need this (this) here, or could that just go into the keyword feature? > > Otherwise LGTM. Go ahead and install, Yuan, unless you have something > else to add :-) > > Theo You're right. We don't. I've cleaned that up in this patch, and also made sure to better support if-statements with negations. See new, attached patch with all changes applied. -- Jostein --------------P00yLdQ52eHovmb8ZNlUwYQO Content-Type: text/x-patch; charset=UTF-8; name="0001-lisp-progmodes-typescript-ts-mode.el-Improve-fontifi.patch" Content-Disposition: attachment; filename*0="0001-lisp-progmodes-typescript-ts-mode.el-Improve-fontifi.pa"; filename*1="tch" Content-Transfer-Encoding: base64 RnJvbSBmMmY3OWIyYmRlMjE0N2ZkMGZlYmRkZWE2OTZhYjQzYmNjMjU3Yjk2IE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiA9P1VURi04P3E/Sm9zdGVpbj0yMEtqPUMzPUI4bmln c2VuPz0gPGpvc3RlaW5Aa2pvbmlnc2VuLm5ldD4KRGF0ZTogV2VkLCA3IERlYyAyMDIyIDA5 OjI3OjQyICswMTAwClN1YmplY3Q6IFtQQVRDSF0gbGlzcC9wcm9nbW9kZXMvdHlwZXNjcmlw dC10cy1tb2RlLmVsOiBJbXByb3ZlIGZvbnRpZmljYXRpb24KIG9mIHZhcmlhYmxlcwoKLS0t CiBsaXNwL3Byb2dtb2Rlcy90eXBlc2NyaXB0LXRzLW1vZGUuZWwgfCA0MiArKysrKysrKysr KysrKysrKy0tLS0tLS0tLS0tCiAxIGZpbGUgY2hhbmdlZCwgMjYgaW5zZXJ0aW9ucygrKSwg MTYgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvbGlzcC9wcm9nbW9kZXMvdHlwZXNjcmlw dC10cy1tb2RlLmVsIGIvbGlzcC9wcm9nbW9kZXMvdHlwZXNjcmlwdC10cy1tb2RlLmVsCmlu ZGV4IDNkYTY5MDU2N2UyLi5mYzJmNzQ2YTBmNCAxMDA2NDQKLS0tIGEvbGlzcC9wcm9nbW9k ZXMvdHlwZXNjcmlwdC10cy1tb2RlLmVsCisrKyBiL2xpc3AvcHJvZ21vZGVzL3R5cGVzY3Jp cHQtdHMtbW9kZS5lbApAQCAtMjIwLDcgKzIyMCwzMSBAQCB0eXBlc2NyaXB0LXRzLW1vZGUt LWZvbnQtbG9jay1zZXR0aW5ncwogICAgICAoYmluYXJ5X2V4cHJlc3Npb24gbGVmdDogKGlk ZW50aWZpZXIpIEBmb250LWxvY2stdmFyaWFibGUtbmFtZS1mYWNlKQogICAgICAoYmluYXJ5 X2V4cHJlc3Npb24gcmlnaHQ6IChpZGVudGlmaWVyKSBAZm9udC1sb2NrLXZhcmlhYmxlLW5h bWUtZmFjZSkKIAotICAgICAoYXJndW1lbnRzIChpZGVudGlmaWVyKSBAZm9udC1sb2NrLXZh cmlhYmxlLW5hbWUtZmFjZSkpCisgICAgIChhcmd1bWVudHMgKGlkZW50aWZpZXIpIEBmb250 LWxvY2stdmFyaWFibGUtbmFtZS1mYWNlKQorCisgICAgIChwYXJlbnRoZXNpemVkX2V4cHJl c3Npb24gKGlkZW50aWZpZXIpIEBmb250LWxvY2stdmFyaWFibGUtbmFtZS1mYWNlKQorICAg ICAocGFyZW50aGVzaXplZF9leHByZXNzaW9uIChfIChpZGVudGlmaWVyKSkgQGZvbnQtbG9j ay12YXJpYWJsZS1uYW1lLWZhY2UpKQorCisgICA6bGFuZ3VhZ2UgbGFuZ3VhZ2UKKyAgIDpv dmVycmlkZSB0CisgICA6ZmVhdHVyZSAncHJvcGVydHkKKyAgIGAoKHByb3BlcnR5X3NpZ25h dHVyZQorICAgICAgbmFtZTogKHByb3BlcnR5X2lkZW50aWZpZXIpIEBmb250LWxvY2stcHJv cGVydHktZmFjZSkKKyAgICAgKHB1YmxpY19maWVsZF9kZWZpbml0aW9uCisgICAgICBuYW1l OiAocHJvcGVydHlfaWRlbnRpZmllcikgQGZvbnQtbG9jay1wcm9wZXJ0eS1mYWNlKQorICAg ICAobWVtYmVyX2V4cHJlc3Npb24KKyAgICAgIG9iamVjdDogKGlkZW50aWZpZXIpIEBmb250 LWxvY2stdmFyaWFibGUtbmFtZS1mYWNlKQorICAgICAobWVtYmVyX2V4cHJlc3Npb24KKyAg ICAgIHByb3BlcnR5OiAoXykgQGZvbnQtbG9jay1wcm9wZXJ0eS1mYWNlKQorCisgICAgIChw YWlyIGtleTogKHByb3BlcnR5X2lkZW50aWZpZXIpIEBmb250LWxvY2stdmFyaWFibGUtbmFt ZS1mYWNlKQorCisgICAgIChwYWlyIHZhbHVlOiAoaWRlbnRpZmllcikgQGZvbnQtbG9jay12 YXJpYWJsZS1uYW1lLWZhY2UpCisKKyAgICAgKChzaG9ydGhhbmRfcHJvcGVydHlfaWRlbnRp ZmllcikgQGZvbnQtbG9jay1wcm9wZXJ0eS1mYWNlKQorCisgICAgICgoc2hvcnRoYW5kX3By b3BlcnR5X2lkZW50aWZpZXJfcGF0dGVybikKKyAgICAgIEBmb250LWxvY2stcHJvcGVydHkt ZmFjZSkpCiAKICAgIDpsYW5ndWFnZSBsYW5ndWFnZQogICAgOm92ZXJyaWRlIHQKQEAgLTI4 NiwyMiArMzEwLDggQEAgdHlwZXNjcmlwdC10cy1tb2RlLS1mb250LWxvY2stc2V0dGluZ3MK ICAgIDpvdmVycmlkZSB0CiAgICAnKChlc2NhcGVfc2VxdWVuY2UpIEBmb250LWxvY2stZXNj YXBlLWZhY2UpCiAKLSAgIDpsYW5ndWFnZSBsYW5ndWFnZQotICAgOm92ZXJyaWRlIHQKLSAg IDpmZWF0dXJlICdwcm9wZXJ0eQotICAgYCgocHJvcGVydHlfc2lnbmF0dXJlCi0gICAgICBu YW1lOiAocHJvcGVydHlfaWRlbnRpZmllcikgQGZvbnQtbG9jay1wcm9wZXJ0eS1mYWNlKQot ICAgICAocHVibGljX2ZpZWxkX2RlZmluaXRpb24KLSAgICAgIG5hbWU6IChwcm9wZXJ0eV9p ZGVudGlmaWVyKSBAZm9udC1sb2NrLXByb3BlcnR5LWZhY2UpCiAKLSAgICAgKHBhaXIga2V5 OiAocHJvcGVydHlfaWRlbnRpZmllcikgQGZvbnQtbG9jay12YXJpYWJsZS1uYW1lLWZhY2Up Ci0KLSAgICAgKHBhaXIgdmFsdWU6IChpZGVudGlmaWVyKSBAZm9udC1sb2NrLXZhcmlhYmxl LW5hbWUtZmFjZSkKLQotICAgICAoKHNob3J0aGFuZF9wcm9wZXJ0eV9pZGVudGlmaWVyKSBA Zm9udC1sb2NrLXByb3BlcnR5LWZhY2UpCi0KLSAgICAgKChzaG9ydGhhbmRfcHJvcGVydHlf aWRlbnRpZmllcl9wYXR0ZXJuKQotICAgICAgQGZvbnQtbG9jay1wcm9wZXJ0eS1mYWNlKSkp KQorICAgKSkKIAogOzs7IyMjYXV0b2xvYWQKIChhZGQtdG8tbGlzdCAnYXV0by1tb2RlLWFs aXN0ICcoIlxcLnRzXFwnIiAuIHR5cGVzY3JpcHQtdHMtbW9kZSkpCi0tIAoyLjM3LjIKCg== --------------P00yLdQ52eHovmb8ZNlUwYQO--