From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Drew Adams Newsgroups: gmane.emacs.bugs Subject: bug#43702: Emacs master: Incorrect highlighting in regexp isearch. Date: Mon, 12 Oct 2020 16:07:38 -0700 (PDT) Message-ID: References: <20200929121317.GA27007@ACM> <83wo0ck5ig.fsf@gnu.org> <20200929153355.GB27007@ACM> <87y2ks819k.fsf@gnus.org> <87y2krdqsk.fsf@mail.linkov.net> <87y2kp93dn.fsf@mail.linkov.net> <87mu0z3zxf.fsf@mail.linkov.net> <871riav4os.fsf@mail.linkov.net> <21c5738b-e9f2-465f-9ca3-8947a5b9191d@default> <874kmzz03q.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="5623"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Alan Mackenzie , Lars Ingebrigtsen , 43702@debbugs.gnu.org To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Oct 13 01:10:09 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kS6xE-0001Lr-Tt for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 13 Oct 2020 01:10:08 +0200 Original-Received: from localhost ([::1]:44852 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kS6xE-0006iz-0V for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 12 Oct 2020 19:10:08 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:41640) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kS6x8-0006ig-JX for bug-gnu-emacs@gnu.org; Mon, 12 Oct 2020 19:10:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:32790) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kS6x8-00040Y-9x for bug-gnu-emacs@gnu.org; Mon, 12 Oct 2020 19:10:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kS6x8-0000by-3s for bug-gnu-emacs@gnu.org; Mon, 12 Oct 2020 19:10:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Drew Adams Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 12 Oct 2020 23:10:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 43702 X-GNU-PR-Package: emacs Original-Received: via spool by 43702-submit@debbugs.gnu.org id=B43702.16025441952333 (code B ref 43702); Mon, 12 Oct 2020 23:10:02 +0000 Original-Received: (at 43702) by debbugs.gnu.org; 12 Oct 2020 23:09:55 +0000 Original-Received: from localhost ([127.0.0.1]:44336 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kS6x1-0000bZ-3k for submit@debbugs.gnu.org; Mon, 12 Oct 2020 19:09:55 -0400 Original-Received: from aserp2130.oracle.com ([141.146.126.79]:60252) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kS6wz-0000bE-4O for 43702@debbugs.gnu.org; Mon, 12 Oct 2020 19:09:53 -0400 Original-Received: from pps.filterd (aserp2130.oracle.com [127.0.0.1]) by aserp2130.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 09CN9kuO157855; Mon, 12 Oct 2020 23:09:46 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=mime-version : message-id : date : from : sender : to : cc : subject : references : in-reply-to : content-type : content-transfer-encoding; s=corp-2020-01-29; bh=XhZ1WMs/LbMKGZ10NPTWyenDiafjvBNsbr9Rbii4NDo=; b=zdMxUZQkGsix1BQSsj3wx7STqGCe2FbED57pAdAk4LJcz3zG8083Is2TowJX5nV2AZwF 98tibIExxxO5o3FFrVUVt0FfLNRffeTDdP/6cMm//+CMydSgP+dYsqGEGdFHixkAorJH cDVDe0seJRCTGQZ5JbUqH/OfztxKifSPI34b18l8zhVPDCvSA1dzREOBNRoqFJ56dXZc BSRMLoESAGRc4wFeRQAgVAHrerNmKQPIrIQv1+Z3wEzGvh10f12275h43gh/5h0ja+L3 Q0petCo8kNYJMoId0/AnWiNGz7MyZ1Jx5DZ9SFt5Qe8IPUF4BmBKJM/CWdxAk63vgfoA KQ== Original-Received: from userp3020.oracle.com (userp3020.oracle.com [156.151.31.79]) by aserp2130.oracle.com with ESMTP id 343pajp4bu-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Mon, 12 Oct 2020 23:09:46 +0000 Original-Received: from pps.filterd (userp3020.oracle.com [127.0.0.1]) by userp3020.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 09CN5UZF140084; Mon, 12 Oct 2020 23:07:45 GMT Original-Received: from aserv0121.oracle.com (aserv0121.oracle.com [141.146.126.235]) by userp3020.oracle.com with ESMTP id 344by1ddy3-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 12 Oct 2020 23:07:45 +0000 Original-Received: from abhmp0010.oracle.com (abhmp0010.oracle.com [141.146.116.16]) by aserv0121.oracle.com (8.14.4/8.13.8) with ESMTP id 09CN7dMR027336; Mon, 12 Oct 2020 23:07:39 GMT In-Reply-To: <874kmzz03q.fsf@mail.linkov.net> X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9.1 (1003210) [OL 16.0.5056.0 (x86)] X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9772 signatures=668681 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 spamscore=0 suspectscore=0 mlxscore=0 malwarescore=0 adultscore=0 bulkscore=0 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2010120167 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9772 signatures=668681 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 suspectscore=0 impostorscore=0 priorityscore=1501 clxscore=1015 malwarescore=0 adultscore=0 lowpriorityscore=0 spamscore=0 phishscore=0 mlxscore=0 mlxlogscore=999 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2010120168 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:190365 Archived-At: > > It's helpful in pretty much any context where regexps > > are matched against text, IMO. >=20 > I think you are right. So here is a patch that implements this: It's probably not my place to criticize your patch. But in case it helps: I don't understand why you change the signature of `replace-highlight' by adding parameter MATCH-DATA. I just use (match-beginning GROUP) and (match-end GROUP), instead of explicitly passing the match data and then copying it all with `butlast' etc. just to find the group's match beginning and end. https://www.emacswiki.org/emacs/download/replace%2b.el