From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#66732: tree-sitter fontification doesn't update multi-line syntax reliably Date: Mon, 18 Dec 2023 20:27:59 +0200 Message-ID: References: <878r7s5cdf.fsf@honnef.co> <83fs1tbou1.fsf@gnu.org> <835y1zo3rw.fsf@gnu.org> <2ce274aa-6d01-4d0a-b10c-07f821343fed@gmail.com> <50920549-006c-0153-2471-02e41a3dada7@gutov.dev> <8c7cd429-bdc3-4fac-ad1c-fbad793bf1a0@gmail.com> <231ebcd1-ec30-0432-82e7-d63e11cd65f7@gutov.dev> <765D713E-9923-4F66-9044-9D69C104C9B0@gmail.com> <33fe5d61-5022-67c5-6a65-babde4fb7f91@gutov.dev> <92CACD38-9534-4A07-8DE3-CE8408272FB6@gmail.com> <59CC46F7-867E-4C74-83EC-49B41DF0FAB8@gmail.com> <8fa0e506-6efc-57d4-6034-e938f97b1fb0@gutov.dev> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="31692"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Cc: Eli Zaretskii , 66732@debbugs.gnu.org, Yuan Fu , dominik@honnef.co To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Dec 18 19:29:13 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rFIMZ-0007pL-NN for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 18 Dec 2023 19:29:12 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rFIMR-0008TN-JO; Mon, 18 Dec 2023 13:29:03 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rFIMP-0008Sy-OJ for bug-gnu-emacs@gnu.org; Mon, 18 Dec 2023 13:29:01 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rFIMO-0004Kf-CD for bug-gnu-emacs@gnu.org; Mon, 18 Dec 2023 13:29:00 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rFIMQ-0004yz-56 for bug-gnu-emacs@gnu.org; Mon, 18 Dec 2023 13:29:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 18 Dec 2023 18:29:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 66732 X-GNU-PR-Package: emacs Original-Received: via spool by 66732-submit@debbugs.gnu.org id=B66732.170292409219033 (code B ref 66732); Mon, 18 Dec 2023 18:29:02 +0000 Original-Received: (at 66732) by debbugs.gnu.org; 18 Dec 2023 18:28:12 +0000 Original-Received: from localhost ([127.0.0.1]:33585 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rFILc-0004wr-Gg for submit@debbugs.gnu.org; Mon, 18 Dec 2023 13:28:12 -0500 Original-Received: from out3-smtp.messagingengine.com ([66.111.4.27]:44709) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rFILa-0004wJ-80 for 66732@debbugs.gnu.org; Mon, 18 Dec 2023 13:28:10 -0500 Original-Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id 0D5D25C015B; Mon, 18 Dec 2023 13:28:03 -0500 (EST) Original-Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Mon, 18 Dec 2023 13:28:03 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gutov.dev; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm3; t=1702924083; x=1703010483; bh=fwvFwEPF/ViOYB0TwcH4rugWTMrcASEbwPIhs1LRO1o=; b= esE2bfR6gbpPfkeNYxuaXc2E6Ps3GyrpvBjelHbGeay7Tam84zWt8q4HaAwyZi0N Gg9Zfc6usfuswAmd1q8PX3qSPp55PgAEr6p0qUQ0gOQSldhF7uWem/pdCltfxhGS EnSPM8QFc9Le7sVNcxp+WZJbacDqoy92bvYYND9ZR/DkKa4lBNuI/rulwbpZr+GQ uXE8XR4lZ2U/899So37wi3jK+7xLTox6haadvafe+voe+5rm3MLiESEoFW7pUqXH cWCdTNb5724hvxCnka3ZKQTGshlOvm/QAN+7bEapgOlUUj6/COR+q9ao2t4OBOKi uSqT6NYRVCgVmYrfghs3sw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1702924083; x= 1703010483; bh=fwvFwEPF/ViOYB0TwcH4rugWTMrcASEbwPIhs1LRO1o=; b=U qYv2KRaWMvi7yhjyErOaFS22SDnrGE+8F0ALa7IE8hmCXuxkLrqKdcHJ6agQgIXr Y4JuL9G8TEsSXmHauORissZAHXd3iTQzbyi+0RgBPN9/Ucr9T0Tc18dMAVBE/7W1 hPBhpsPLtmOw664czEq2tYRRBsolY3ag5fuwBUHB2PsRoVNUYBXoBWv5u1xfX655 2g0o4s7cad7+vKdlHEJcR4kIhM90okPqBHiIuXXjWtPnBQHfDMBxLjcmq9Q1a6Wh MEPWdHB0NR68SmarVp7F7Fo/5PLsh4ADVBLxlXqlxKXU4kQpTNnimRqcgVMIo/DK 935+dmJhoBna+P3NucP/Q== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedrvddtkedgudduudcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefkffggfgfuhffvvehfjggtgfesthekredttdefjeenucfhrhhomhepffhm ihhtrhihucfiuhhtohhvuceoughmihhtrhihsehguhhtohhvrdguvghvqeenucggtffrrg htthgvrhhnpefhfedtjeeltefflefhffetfefggefgjefgtdduueevtddttedvleffkedv geduteenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpe gumhhithhrhiesghhuthhovhdruggvvh X-ME-Proxy: Feedback-ID: i0e71465a:Fastmail Original-Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 18 Dec 2023 13:28:01 -0500 (EST) Content-Language: en-US In-Reply-To: <8fa0e506-6efc-57d4-6034-e938f97b1fb0@gutov.dev> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:276476 Archived-At: Stefan, what do you think? On 17/12/2023 00:56, Dmitry Gutov wrote: >> I found that if you don’t set text prop fontified to nil for the whole >> extended region, redisplay doesn’t seem to, well, redisplay the full >> region, even thought the new face has been correctly applied to them. > > That sounds like a bug in font-lock? At the end of jit-lock-fontify-now, > there is a call creating a timer with jit-lock-force-redisplay. > > And that function ends with this: > >     ;; Don't cause refontification (it's already been done), but just do >     ;; some random buffer change, so as to force redisplay. >     (put-text-property start end 'fontified t))))) > > If I just change t to nil there (or to some other value, like 42), > either of our patches starts behaving well. Perhaps Stefan could comment.