From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: "Phillip Lord" Newsgroups: gmane.emacs.bugs Subject: bug#23203: 25.0.91; some loaddefs files have auto-save remnants after building (and install doesn't ignore them) Date: Sun, 3 Apr 2016 20:33:37 +0100 Message-ID: References: <87twjjqidp.fsf@Rainer.invalid> <87shz35b8i.fsf@Rainer.invalid> <87lh4v0y1z.fsf@linux-m68k.org> <87egam6hif.fsf@Rainer.invalid> <3bf1141d622845eb4fe66b6dce573551.squirrel@cloud103.planethippo.com> <83fuv2plj5.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed;boundary="----=_20160403203336_82544" X-Trace: ger.gmane.org 1459712061 24447 80.91.229.3 (3 Apr 2016 19:34:21 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 3 Apr 2016 19:34:21 +0000 (UTC) Cc: 23203@debbugs.gnu.org, stromeko@nexgo.de, Phillip Lord To: "Eli Zaretskii" Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Apr 03 21:34:10 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1amnmk-0005Gg-Bm for geb-bug-gnu-emacs@m.gmane.org; Sun, 03 Apr 2016 21:34:10 +0200 Original-Received: from localhost ([::1]:54967 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1amnmj-0001Ci-M9 for geb-bug-gnu-emacs@m.gmane.org; Sun, 03 Apr 2016 15:34:09 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:55504) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1amnmf-0001Bk-NA for bug-gnu-emacs@gnu.org; Sun, 03 Apr 2016 15:34:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1amnmc-00079q-GI for bug-gnu-emacs@gnu.org; Sun, 03 Apr 2016 15:34:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:53178) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1amnmc-00079m-9o for bug-gnu-emacs@gnu.org; Sun, 03 Apr 2016 15:34:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1amnmc-0008D4-2Y for bug-gnu-emacs@gnu.org; Sun, 03 Apr 2016 15:34:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: "Phillip Lord" Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 03 Apr 2016 19:34:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 23203 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 23203-submit@debbugs.gnu.org id=B23203.145971202531535 (code B ref 23203); Sun, 03 Apr 2016 19:34:02 +0000 Original-Received: (at 23203) by debbugs.gnu.org; 3 Apr 2016 19:33:45 +0000 Original-Received: from localhost ([127.0.0.1]:50305 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1amnmK-0008CY-Vz for submit@debbugs.gnu.org; Sun, 03 Apr 2016 15:33:45 -0400 Original-Received: from cloud103.planethippo.com ([31.216.48.48]:43849) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1amnmI-0008CM-Lh for 23203@debbugs.gnu.org; Sun, 03 Apr 2016 15:33:43 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=russet.org.uk; s=default; h=Content-Type:MIME-Version:Cc:To:From:Subject: Date:References:In-Reply-To:Message-ID; bh=zhQuGWxycrrowmuwy/0n+UtEIV7EVziMt5x6muIZJcM=; b=BT7bMNSS2yAyhYFWFMEEs4Vl9A Z5xMXSywsSUBnYwdvQUm58xB2JPeqXIzkEoDemHvvN0rCoxEH5nqVLhRIig155t07ia6iviI3088s R5+eFx9ftybcPHp/0EPJYfCFNHGKyOEoq7i8jjz1N66JrQBbIk219/0p1Ts/X5QmsYE3aU3kpiQ4X h/DQwCSHUpPaEvhXz+fqRE33VlMTHZZ65EEgdKlFIVVnxBVttsn1eqoZ943sQHQ6hsHfcsoukHEDv 4VlNHd8JrM43NnqRSX7j6/+FjX9gosr0eFLQNAg4Vv7H7GvooGEVb6Wltugnr0IDIjxtWRkmCTb17 OuPHnvhA==; Original-Received: from [127.0.0.1] (port=33240 helo=cloud103.planethippo.com) by cloud103.planethippo.com with esmtpa (Exim 4.86_1) (envelope-from ) id 1amnmC-003BR4-UY; Sun, 03 Apr 2016 20:33:37 +0100 Original-Received: from 77.98.219.118 ([77.98.219.118]) (SquirrelMail authenticated user phillip.lord@russet.org.uk) by cloud103.planethippo.com with HTTP; Sun, 3 Apr 2016 20:33:37 +0100 In-Reply-To: <83fuv2plj5.fsf@gnu.org> User-Agent: SquirrelMail/1.5.2 [SVN] X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - cloud103.planethippo.com X-AntiAbuse: Original Domain - debbugs.gnu.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - russet.org.uk X-Get-Message-Sender-Via: cloud103.planethippo.com: authenticated_id: phillip.lord@russet.org.uk X-Authenticated-Sender: cloud103.planethippo.com: phillip.lord@russet.org.uk X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:115978 Archived-At: ------=_20160403203336_82544 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 8bit On Sun, April 3, 2016 7:58 pm, Eli Zaretskii wrote: >> Date: Sun, 3 Apr 2016 19:46:40 +0100 >> From: "Phillip Lord" >> Cc: 23203@debbugs.gnu.org >> >> >> The attached patch fixes the problem in my hands (assuming we believe >> that this is a bug). The solution may be a bit blunt, though, although >> the function patched is documented as "use in batch during build". > > Indeed, I'd rather we didn't do anything that drastic. > > > If needed, backups can be disabled from the command line. That works too (see attached diff), although it's a bit of pain because of duplication in the makefile. I would ask though, when do we want backup files produced from the batch-update-autoloads function? Changing the default behaviour of this function seems to make the most sense to me (although perhaps not the way that I did it). Phil ------=_20160403203336_82544 Content-Type: text/x-patch; name="fix2.diff" Content-Transfer-Encoding: 8bit Content-Disposition: attachment; filename="fix2.diff" diff --git a/lisp/Makefile.in b/lisp/Makefile.in index f33dd01..98743e8 100644 --- a/lisp/Makefile.in +++ b/lisp/Makefile.in @@ -183,6 +183,7 @@ $(lisp)/loaddefs.el: $(LOADDEFS) --eval '(setq autoload-ensure-writable t)' \ --eval '(setq autoload-builtin-package-versions t)' \ --eval '(setq generated-autoload-file (expand-file-name (unmsys--file-name "$@")))' \ + --eval '(setq make-backup-files nil)' \ -f batch-update-autoloads ${SUBDIRS_ALMOST} # This is required by the bootstrap-emacs target in ../src/Makefile, so @@ -381,7 +382,8 @@ $(MH_E_DIR)/mh-loaddefs.el: $(MH_E_SRC) $(AM_V_GEN)$(emacs) -l autoload \ --eval "(setq generate-autoload-cookie \";;;###mh-autoload\")" \ --eval "(setq generated-autoload-file (expand-file-name (unmsys--file-name \"$@\")))" \ - -f batch-update-autoloads $(MH_E_DIR) + --eval '(setq make-backup-files nil)' \ + -f batch-update-autoloads $(MH_E_DIR) # Update TRAMP internal autoloads. Maybe we could move tramp*.el into # an own subdirectory. OTOH, it does not hurt to keep them in @@ -394,6 +396,7 @@ $(TRAMP_DIR)/tramp-loaddefs.el: $(TRAMP_SRC) $(AM_V_GEN)$(emacs) -l autoload \ --eval "(setq generate-autoload-cookie \";;;###tramp-autoload\")" \ --eval "(setq generated-autoload-file (expand-file-name (unmsys--file-name \"$@\")))" \ + --eval '(setq make-backup-files nil)' \ -f batch-update-autoloads $(TRAMP_DIR) CAL_DIR = $(lisp)/calendar @@ -406,19 +409,22 @@ $(CAL_DIR)/cal-loaddefs.el: $(CAL_SRC) $(AM_V_GEN)$(emacs) -l autoload \ --eval "(setq generate-autoload-cookie \";;;###cal-autoload\")" \ --eval "(setq generated-autoload-file (expand-file-name (unmsys--file-name \"$@\")))" \ + --eval '(setq make-backup-files nil)' \ -f batch-update-autoloads $(CAL_DIR) $(CAL_DIR)/diary-loaddefs.el: $(CAL_SRC) $(CAL_DIR)/cal-loaddefs.el $(AM_V_GEN)$(emacs) -l autoload \ --eval "(setq generate-autoload-cookie \";;;###diary-autoload\")" \ --eval "(setq generated-autoload-file (expand-file-name (unmsys--file-name \"$@\")))" \ + --eval '(setq make-backup-files nil)' \ -f batch-update-autoloads $(CAL_DIR) $(CAL_DIR)/hol-loaddefs.el: $(CAL_SRC) $(CAL_DIR)/diary-loaddefs.el $(AM_V_GEN)$(emacs) -l autoload \ --eval "(setq generate-autoload-cookie \";;;###holiday-autoload\")" \ --eval "(setq generated-autoload-file (expand-file-name (unmsys--file-name \"$@\")))" \ - -f batch-update-autoloads $(CAL_DIR) + --eval '(setq make-backup-files nil)' \ + -f batch-update-autoloads $(CAL_DIR) .PHONY: bootstrap-clean distclean maintainer-clean ------=_20160403203336_82544--