bug#23203: 25.0.91; some loaddefs files have auto-save remnants after building (and install doesn't ignore them)

["Phillip Lord" <phillip.lord@russet.org.uk>]

[-- Attachment #1: Type: text/plain, Size: 860 bytes --]

On Sun, April 3, 2016 7:58 pm, Eli Zaretskii wrote:
>> Date: Sun, 3 Apr 2016 19:46:40 +0100
>> From: "Phillip Lord" <phillip.lord@russet.org.uk>
>> Cc: 23203@debbugs.gnu.org
>>
>>
>> The attached patch fixes the problem in my hands (assuming we believe
>> that this is a bug). The solution may be a bit blunt, though, although
>> the function patched is documented as "use in batch during build".
>
> Indeed, I'd rather we didn't do anything that drastic.
>
>
> If needed, backups can be disabled from the command line.

That works too (see attached diff), although it's a bit of pain because of
duplication in the makefile.

I would ask though, when do we want backup files produced from the
batch-update-autoloads function? Changing the default behaviour of this
function seems to make the most sense to me (although perhaps not the way
that I did it).

Phil

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: fix2.diff --]
[-- Type: text/x-patch; name="fix2.diff", Size: 2645 bytes --]

diff --git a/lisp/Makefile.in b/lisp/Makefile.in
index f33dd01..98743e8 100644
--- a/lisp/Makefile.in
+++ b/lisp/Makefile.in
@@ -183,6 +183,7 @@ $(lisp)/loaddefs.el: $(LOADDEFS)
 	    --eval '(setq autoload-ensure-writable t)' \
 	    --eval '(setq autoload-builtin-package-versions t)' \
 	    --eval '(setq generated-autoload-file (expand-file-name (unmsys--file-name "$@")))' \
+	    --eval '(setq make-backup-files nil)' \
 	    -f batch-update-autoloads ${SUBDIRS_ALMOST}
 
 # This is required by the bootstrap-emacs target in ../src/Makefile, so
@@ -381,7 +382,8 @@ $(MH_E_DIR)/mh-loaddefs.el: $(MH_E_SRC)
 	$(AM_V_GEN)$(emacs) -l autoload \
 	   --eval "(setq generate-autoload-cookie \";;;###mh-autoload\")" \
 	   --eval "(setq generated-autoload-file (expand-file-name (unmsys--file-name \"$@\")))" \
-	   -f batch-update-autoloads $(MH_E_DIR)
+	   --eval '(setq make-backup-files nil)' \
+           -f batch-update-autoloads $(MH_E_DIR)
 
 # Update TRAMP internal autoloads. Maybe we could move tramp*.el into
 # an own subdirectory. OTOH, it does not hurt to keep them in
@@ -394,6 +396,7 @@ $(TRAMP_DIR)/tramp-loaddefs.el: $(TRAMP_SRC)
 	$(AM_V_GEN)$(emacs) -l autoload \
 	   --eval "(setq generate-autoload-cookie \";;;###tramp-autoload\")" \
 	   --eval "(setq generated-autoload-file (expand-file-name (unmsys--file-name \"$@\")))" \
+	   --eval '(setq make-backup-files nil)' \
 	   -f batch-update-autoloads $(TRAMP_DIR)
 
 CAL_DIR = $(lisp)/calendar
@@ -406,19 +409,22 @@ $(CAL_DIR)/cal-loaddefs.el: $(CAL_SRC)
 	$(AM_V_GEN)$(emacs) -l autoload \
 	   --eval "(setq generate-autoload-cookie \";;;###cal-autoload\")" \
 	   --eval "(setq generated-autoload-file (expand-file-name (unmsys--file-name \"$@\")))" \
+	   --eval '(setq make-backup-files nil)' \
 	   -f batch-update-autoloads $(CAL_DIR)
 
 $(CAL_DIR)/diary-loaddefs.el: $(CAL_SRC) $(CAL_DIR)/cal-loaddefs.el
 	$(AM_V_GEN)$(emacs) -l autoload \
 	   --eval "(setq generate-autoload-cookie \";;;###diary-autoload\")" \
 	   --eval "(setq generated-autoload-file (expand-file-name (unmsys--file-name \"$@\")))" \
+	   --eval '(setq make-backup-files nil)' \
 	   -f batch-update-autoloads $(CAL_DIR)
 
 $(CAL_DIR)/hol-loaddefs.el: $(CAL_SRC) $(CAL_DIR)/diary-loaddefs.el
 	$(AM_V_GEN)$(emacs) -l autoload \
 	   --eval "(setq generate-autoload-cookie \";;;###holiday-autoload\")" \
 	   --eval "(setq generated-autoload-file (expand-file-name (unmsys--file-name \"$@\")))" \
-	   -f batch-update-autoloads $(CAL_DIR)
+	   --eval '(setq make-backup-files nil)' \
+           -f batch-update-autoloads $(CAL_DIR)
 
 .PHONY: bootstrap-clean distclean maintainer-clean