all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Dmitry Gutov <dgutov@yandex.ru>
To: Andrii Kolomoiets <andreyk.mad@gmail.com>
Cc: 43464@debbugs.gnu.org
Subject: bug#43464: 28.0.50; vc: Error calling vc-revert for repo root
Date: Mon, 5 Oct 2020 13:19:19 +0300	[thread overview]
Message-ID: <b62c3bbb-448b-c125-3cb3-60ba546985d8@yandex.ru> (raw)
In-Reply-To: <m24kn9i51g.fsf@gmail.com>

On 05.10.2020 09:02, Andrii Kolomoiets wrote:
> Dmitry Gutov <dgutov@yandex.ru> writes:
> 
>> Where is that vc-backend called from, in our scenario?
> 
> It's called from 'vc-call'.  The 'vc-revert-file' used it twice
> to call the 'make-version-backups-p' and the 'revert' backend functions.

Then a change in vc-revert-file could be sufficient.

>> Could we make do with changing that code to use vc-responsible-backend
>> instead of vc-backend instead? If it's not a function called
>> frequently.
> 
> I went a little different way and made the 'vc-backend' return correct
> backend for directories.  In case you missed it somehow here is the link
> to the message:
> 
> https://lists.gnu.org/archive/html/bug-gnu-emacs/2020-09/msg02508.html

Like I explained, it will create a cache entry that is never invalidated.





  reply	other threads:[~2020-10-05 10:19 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-17  7:29 bug#43464: 28.0.50; vc: Error calling vc-revert for repo root Andrii Kolomoiets
2020-09-17 16:10 ` Lars Ingebrigtsen
2020-09-18  9:00 ` Dmitry Gutov
2020-09-18  9:30   ` Andrii Kolomoiets
2020-09-18 13:30     ` Dmitry Gutov
2020-09-18 15:45       ` Andrii Kolomoiets
2020-09-22 19:48         ` Dmitry Gutov
2020-09-24  7:15           ` Andrii Kolomoiets
2020-09-30  9:13             ` Andrii Kolomoiets
2020-10-04 22:32             ` Dmitry Gutov
2020-10-05  6:02               ` Andrii Kolomoiets
2020-10-05 10:19                 ` Dmitry Gutov [this message]
2020-10-07 13:16                   ` Andrii Kolomoiets
2020-10-07 22:47                     ` Dmitry Gutov
2020-10-11 20:28                       ` Andrii Kolomoiets
2020-10-13 11:59                         ` Dmitry Gutov
2020-09-18 13:18   ` Lars Ingebrigtsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b62c3bbb-448b-c125-3cb3-60ba546985d8@yandex.ru \
    --to=dgutov@yandex.ru \
    --cc=43464@debbugs.gnu.org \
    --cc=andreyk.mad@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.