From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.devel Subject: Re: Change in files.el Date: Sat, 28 Jan 2017 18:31:29 +0300 Message-ID: References: <83mvebzh0k.fsf@gnu.org> <83bmurz0y9.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Trace: blaine.gmane.org 1485617522 19067 195.159.176.226 (28 Jan 2017 15:32:02 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 28 Jan 2017 15:32:02 +0000 (UTC) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:51.0) Gecko/20100101 Thunderbird/51.0 Cc: emacs-devel@gnu.org To: Eli Zaretskii , Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Jan 28 16:31:56 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cXUyb-0003HP-Gw for ged-emacs-devel@m.gmane.org; Sat, 28 Jan 2017 16:31:41 +0100 Original-Received: from localhost ([::1]:52264 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cXUyg-0005fG-K4 for ged-emacs-devel@m.gmane.org; Sat, 28 Jan 2017 10:31:46 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:34764) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cXUyZ-0005YK-T6 for emacs-devel@gnu.org; Sat, 28 Jan 2017 10:31:40 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cXUyW-0002s8-I5 for emacs-devel@gnu.org; Sat, 28 Jan 2017 10:31:39 -0500 Original-Received: from mail-lf0-x243.google.com ([2a00:1450:4010:c07::243]:34676) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cXUyW-0002rb-Ag; Sat, 28 Jan 2017 10:31:36 -0500 Original-Received: by mail-lf0-x243.google.com with SMTP id q89so28104158lfi.1; Sat, 28 Jan 2017 07:31:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=8B5o68NnUomF32vEp1XxkXwz3E2cT7wFA0+qiX9UvFQ=; b=fik99wJAaE7w+Pr4QD8FAb3qxcKX/cAqH/wTnsxVsWYLISs6yTV3HF3bmaAajMgVyx I8ah0yFruQ3scwDhzCTcU/9QLZWw/NzpOkVPmDDi049YqgL6uFdUZe/qj6UpmGYN6MP5 34xT8E7YIkAh8q04tlDSB99zWRMnswDEOREx0Yp/CrTwhjV0fH0aBKHG5mHdy6MVdZVN QpBgHcKZFlY8RPmghO3nsbjpAllN7rYuRoCmuB1+9ItFgOl9fJ1h9+D6XlPDp3CNFuMw CqHsK31W5+j9KPPX+lWwQepW59+lZubuLnJcFBe1KLckhsWWO7/gC/lc+lTY9MbzIWOe ijVQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=8B5o68NnUomF32vEp1XxkXwz3E2cT7wFA0+qiX9UvFQ=; b=FiwGt7o5FCASBZfSwJulFJIV5a5GmfKu5SLoh1P76At+oIYpthDLEwFWcPqUhdQmi/ 55H/cQSvo4GzZcOPMS6xKNCZO0D7EDuOLbFFQmibVq+IzodoJfnc3FpIjXgfFUZ5uxAy CD9Ruwb0mEGLLjtbs1hLkcgT+rFIvBmagw2pmWhB7abuO3nRXkXeTrky/5/nWiMBHKu0 gy23iq6PsmykaSvWvE27gPbOxXSB2CLT7pzbdgMWcJglYKvLy8ikQbwNLnUhjNdJFrao bZ9crNoFARUOJ3OxrVR+QfKpGR8a3oGpZ44JKXMRB/todXZ02/g6tIwyMeOQOBKZogMj he5g== X-Gm-Message-State: AIkVDXKXtluJW900LMFhNsKHmZt4mgZylRYr8XHaRFW91lLOecTp/OiQSdwHH0lWXfyQ0Q== X-Received: by 10.25.199.14 with SMTP id x14mr3692633lff.13.1485617493121; Sat, 28 Jan 2017 07:31:33 -0800 (PST) Original-Received: from [192.168.1.174] ([178.252.127.239]) by smtp.googlemail.com with ESMTPSA id g4sm632683ljg.23.2017.01.28.07.31.31 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 28 Jan 2017 07:31:32 -0800 (PST) In-Reply-To: <83bmurz0y9.fsf@gnu.org> Content-Language: en-US X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2a00:1450:4010:c07::243 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:211697 Archived-At: On 28.01.2017 17:57, Eli Zaretskii wrote: > These sound minor to me (and the last two are also possible without > the requirement, AFAIU). By contrast, insisting on a function value > instead of the default nil forces me to go through at least one more > level of indirection when I need to understand what happens in a > function that references such variables, which sounds like a more > serious trouble from my POV. It's just one more level of indirection. We routinely deal with dozens of them. This above rule should just be adhered consistently, and the indirection won't be a surprise every time. On the plus side, you might get a smaller function that calls the -default one, because some code will be extracted. Finally, the default value of save-some-buffers-default-predicate can be #'ignore or #'identity (it's either this, or the previous paragraph, I'm not familiar with the code enough to be sure). > I was up to my neck in this when I > needed to document all the various optional behaviors implemented in > isearch.el, and bumped into similar issues several times elsewhere. isearch.el and etags.el have more egregious problems, such as extensive use of dynamic bindings.