From: Ken Brown <kbrown@cornell.edu>
To: "emacs-devel@gnu.org" <emacs-devel@gnu.org>,
Eli Zaretskii <eliz@gnu.org>
Subject: Re: [Emacs-diffs] master 74a5a33: Support native image transforms on MS-Windows
Date: Sat, 29 Jun 2019 19:21:11 +0000 [thread overview]
Message-ID: <b5ee9173-2768-6034-c4cf-1b6807b583b2@cornell.edu> (raw)
In-Reply-To: <20190629115506.BDED9208EA@vcs0.savannah.gnu.org>
On 6/29/2019 7:55 AM, Eli Zaretskii wrote:
> branch: master
> commit 74a5a332fee8a346cf65ed6656c1b08dc1df5fde
> Author: Eli Zaretskii <eliz@gnu.org>
> Commit: Eli Zaretskii <eliz@gnu.org>
>
> Support native image transforms on MS-Windows
I'm seeing a few compiler warnings after this commit with GCC-7.4.0:
In file included from ../../master/src/image.c:37:0:
../../master/src/image.c: In function ‘image_set_transform’:
../../master/src/lisp.h:61:24: warning: implicit conversion from ‘float’ to
‘double’ to match other operand of binary expression [-Wdouble-promotion]
#define max(a, b) ((a) > (b) ? (a) : (b))
^
../../master/src/image.c:2123:12: note: in expansion of macro ‘max’
xscale = max (xscale, FLT_MIN);
^
../../master/src/lisp.h:61:36: warning: implicit conversion from ‘float’ to
‘double’ to match other result of conditional [-Wdouble-promotion]
#define max(a, b) ((a) > (b) ? (a) : (b))
^
../../master/src/image.c:2123:12: note: in expansion of macro ‘max’
xscale = max (xscale, FLT_MIN);
^
../../master/src/image.c: In function ‘image_set_transform.isra.21’:
../../master/src/image.c:2136:14: warning: ‘sin_r’ may be used uninitialized in
this function [-Wmaybe-uninitialized]
int cos_r, sin_r;
^~~~~
../../master/src/image.c:2175:17: warning: ‘cos_r’ may be used uninitialized in
this function [-Wmaybe-uninitialized]
matrix3x3 rot = { [0][0] = cos_r, [0][1] = -sin_r,
The double-promotion warning is fixed by using DBL_MIN instead of FLT_MIN.
The maybe-uninitialized warnings seem bogus to me.
Ken
next parent reply other threads:[~2019-06-29 19:21 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20190629115503.5317.97999@vcs0.savannah.gnu.org>
[not found] ` <20190629115506.BDED9208EA@vcs0.savannah.gnu.org>
2019-06-29 19:21 ` Ken Brown [this message]
2019-06-30 0:00 ` [Emacs-diffs] master 74a5a33: Support native image transforms on MS-Windows Paul Eggert
2019-06-30 2:39 ` Eli Zaretskii
2019-06-30 4:08 ` Paul Eggert
2019-06-30 14:21 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b5ee9173-2768-6034-c4cf-1b6807b583b2@cornell.edu \
--to=kbrown@cornell.edu \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.