From: Yuan Fu <casouri@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 66711-done@debbugs.gnu.org, dominik@honnef.co
Subject: bug#66711: treesit-default-defun-skipper moves to bol if there is any whitespace
Date: Sun, 10 Dec 2023 17:45:18 -0800 [thread overview]
Message-ID: <b5a5ed82-0cca-4fb5-8b59-dee7546b47c9@gmail.com> (raw)
In-Reply-To: <837cmfo3ts.fsf@gnu.org>
On 11/18/23 12:36 AM, Eli Zaretskii wrote:
> Ping! Yuan, any comments?
>
>> Cc: 66711@debbugs.gnu.org
>> Date: Sun, 29 Oct 2023 13:53:27 +0200
>> From: Eli Zaretskii <eliz@gnu.org>
>>
>>> From: Dominik Honnef <dominik@honnef.co>
>>> Date: Mon, 23 Oct 2023 19:41:24 +0200
>>>
>>> treesit-default-defun-skipper has the following bit of code:
>>>
>>> ;; Moving backward, but there are some whitespace (and only
>>> ;; whitespace) between point and BOL: go back to BOL.
>>> ((looking-back (rx (+ (or " " "\t")))
>>> (line-beginning-position))
>>> (beginning-of-line))))
>>>
>>> However, as written, the regexp matches if there is any whitespace
>>> before point, not if there is only whitespace.
>> Yuan, any comments?
Thanks, Dominik and Eli. I applied a patch that should fix the regexp.
Yuan
prev parent reply other threads:[~2023-12-11 1:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-23 17:41 bug#66711: treesit-default-defun-skipper moves to bol if there is any whitespace Dominik Honnef
2023-10-29 11:53 ` Eli Zaretskii
2023-11-18 8:36 ` Eli Zaretskii
2023-12-11 1:45 ` Yuan Fu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b5a5ed82-0cca-4fb5-8b59-dee7546b47c9@gmail.com \
--to=casouri@gmail.com \
--cc=66711-done@debbugs.gnu.org \
--cc=dominik@honnef.co \
--cc=eliz@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.