From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Drew Adams Newsgroups: gmane.emacs.devel Subject: RE: master 49192e9: Strip "(fn...)" from output of `describe-mode' (bug#38222) Date: Tue, 19 Nov 2019 13:26:43 -0800 (PST) Message-ID: References: <20191119101930.28082.63466@vcs0.savannah.gnu.org> <20191119101931.EA4E2209BF@vcs0.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="160638"; mail-complaints-to="usenet@blaine.gmane.org" Cc: Emacs developers To: Stefan Monnier , Juanma Barranquero Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Nov 19 22:27:39 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iXB29-000fcZ-Br for ged-emacs-devel@m.gmane.org; Tue, 19 Nov 2019 22:27:37 +0100 Original-Received: from localhost ([::1]:51718 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iXB27-00056t-Te for ged-emacs-devel@m.gmane.org; Tue, 19 Nov 2019 16:27:35 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:59028) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iXB1R-00056j-Cm for emacs-devel@gnu.org; Tue, 19 Nov 2019 16:26:54 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iXB1P-0007cX-ON for emacs-devel@gnu.org; Tue, 19 Nov 2019 16:26:52 -0500 Original-Received: from userp2130.oracle.com ([156.151.31.86]:36782) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iXB1P-0007bx-GP for emacs-devel@gnu.org; Tue, 19 Nov 2019 16:26:51 -0500 Original-Received: from pps.filterd (userp2130.oracle.com [127.0.0.1]) by userp2130.oracle.com (8.16.0.27/8.16.0.27) with SMTP id xAJLJRuC175997; Tue, 19 Nov 2019 21:26:47 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=mime-version : message-id : date : from : sender : to : cc : subject : references : in-reply-to : content-type : content-transfer-encoding; s=corp-2019-08-05; bh=bpW8d2Bv6tCkOh9ljHwrLK5XxI3vhwSUCmtlhie/aqs=; b=V8THBnfoaOJ2+ydgfC18e7EDcK33xxc/161HhSExVK1h0tZUaATa3LWRYUK2kXo1HRBh EW6g0ysVYlXbPbRwrjLqFGw9bklOBuNSNpkeBKuq1fHkCw3+VtRar6lDlGV7Pe+7tCZc 7Vk5/7ylC28BntanUbZx29jVc20ofirck11JrOUvBdY74OQRdlfCVbiPk8dVSYMcV3wo hRBknLG80/+pJV9lNO+iVtMURBktDFojN+esy2J/EqtesUhBCJOYtU2NfBH6RVp7Xh0o LcdXN62HdaxeqJmHPec2zgwH/3TUEwxqyKkpG7Xv+LYNP84I17RHBHUSz5afvLf5t5aa Zw== Original-Received: from aserp3020.oracle.com (aserp3020.oracle.com [141.146.126.70]) by userp2130.oracle.com with ESMTP id 2wa8htstjv-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 19 Nov 2019 21:26:47 +0000 Original-Received: from pps.filterd (aserp3020.oracle.com [127.0.0.1]) by aserp3020.oracle.com (8.16.0.27/8.16.0.27) with SMTP id xAJLIXkW016742; Tue, 19 Nov 2019 21:26:46 GMT Original-Received: from userv0122.oracle.com (userv0122.oracle.com [156.151.31.75]) by aserp3020.oracle.com with ESMTP id 2wcembafqp-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 19 Nov 2019 21:26:46 +0000 Original-Received: from abhmp0006.oracle.com (abhmp0006.oracle.com [141.146.116.12]) by userv0122.oracle.com (8.14.4/8.14.4) with ESMTP id xAJLQia3006323; Tue, 19 Nov 2019 21:26:45 GMT In-Reply-To: X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9.1 (1003210) [OL 16.0.4927.0 (x86)] X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9446 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1911140001 definitions=main-1911190175 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9446 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1911140001 definitions=main-1911190175 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [generic] [fuzzy] X-Received-From: 156.151.31.86 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:242454 Archived-At: > What I'm suggesting is to look at all the usage we can find and see if > such a change would break that code. If none is broken, there's a high > probability that other code we don't know about wouldn't be > broken either. FWIW, I have 6 occurrences of `help-split-fundoc' in my library `help-fns+.el'. But those occurrences are derived from the `help-fns.el' code. FWIW2, I've already updated `help-fns+.el' to use code similar to what Juanma proposed, for `describe-mode'. But I can no doubt adapt both that and the `help-split-fundoc' occurrences to whatever changes you end up making. https://www.emacswiki.org/emacs/download/help-fns%2b.el