From: Katsumi Yamaoka <yamaoka@jpl.org>
To: monnier@iro.umontreal.ca
Cc: asjo@koldfront.dk, ivan.kanis@googlemail.com, emacs-devel@gnu.org
Subject: Re: Simple defadvice's stopped working (commit daa84a03, Thu Nov 8 23:10:16 2012 -0500)
Date: Wed, 14 Nov 2012 08:18:29 +0900 [thread overview]
Message-ID: <b4mzk2lm6re.fsf@jpl.org> (raw)
In-Reply-To: jwv4nktbmmu.fsf-monnier+emacs@gnu.org
Stefan Monnier wrote:
> You might try your advice code with the new code in trunk.
> There are significant changes in there, so I suspect the bug you suffered
> from is gone, but I wouldn't be surprised if it is replaced by others.
I built Emacs from scratch using the very fresh bzr source.
It looks to have been pretty improved except for at least one
problem: an elc module seems to need to be loaded before advising
a function that provides, i.e.:
This works:
(require 'gnus-art)
(defadvice gnus-article-bla-bla...)
This doesn't work:
(defadvice gnus-article-bla-bla...)
In the latter case I got the following error:
Debugger entered--Lisp error: (wrong-type-argument listp t)
ad-parse-arglist(t)
ad-map-arglists(t t)
ad-make-advised-definition(gnus-article-prepare-display)
ad-activate-advised-definition(gnus-article-prepare-display nil)
ad-activate(gnus-article-prepare-display nil)
(progn (ad-add-advice (quote gnus-article-prepare-display)...
It's easy for you to fix this, isn't it? :)
The advice that causes this is:
(defadvice gnus-article-prepare-display (after delete-last-empty-lines
activate)
"Delete last empty lines."
(let ((limit (previous-char-property-change (goto-char (point-max)))))
(while (progn
(forward-line -1)
(and (< limit (point)) (looking-at "[\t ]*$")))))
(forward-line 1)
(let ((inhibit-read-only t))
(delete-region (point) (point-max))))
next prev parent reply other threads:[~2012-11-13 23:18 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-09 23:47 Simple defadvice's stopped working (commit daa84a03, Thu Nov 8 23:10:16 2012 -0500) Adam Sjøgren
2012-11-10 1:55 ` Stefan Monnier
2012-11-11 21:24 ` Tim Cross
2012-11-12 10:36 ` Ivan Kanis
2012-11-13 11:09 ` Katsumi Yamaoka
2012-11-13 14:34 ` Stefan Monnier
2012-11-13 23:18 ` Katsumi Yamaoka [this message]
2012-11-14 16:19 ` Juanma Barranquero
2012-11-15 2:08 ` Katsumi Yamaoka
2012-11-15 3:30 ` Stefan Monnier
2012-11-15 9:00 ` Ivan Kanis
2012-11-15 10:55 ` Katsumi Yamaoka
2012-11-15 14:39 ` Stefan Monnier
2012-11-15 23:01 ` Katsumi Yamaoka
2012-11-16 14:16 ` Stefan Monnier
2012-11-16 16:33 ` Juanma Barranquero
2012-11-16 17:25 ` Stefan Monnier
2012-11-16 17:36 ` Juanma Barranquero
2012-11-16 18:11 ` Stefan Monnier
2012-11-16 18:17 ` Juanma Barranquero
2012-11-16 20:11 ` Stefan Monnier
2012-11-16 23:52 ` Juanma Barranquero
2012-11-19 1:29 ` Stefan Monnier
2012-11-19 2:36 ` Juanma Barranquero
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b4mzk2lm6re.fsf@jpl.org \
--to=yamaoka@jpl.org \
--cc=asjo@koldfront.dk \
--cc=emacs-devel@gnu.org \
--cc=ivan.kanis@googlemail.com \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.