From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Katsumi Yamaoka Newsgroups: gmane.emacs.bugs Subject: Re: Bad value in file-coding-system-alist Date: Mon, 09 Jul 2007 10:34:38 +0900 Organization: Emacsen advocacy group Message-ID: References: <468BCE38.20402@gmail.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1183944906 28735 80.91.229.12 (9 Jul 2007 01:35:06 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Mon, 9 Jul 2007 01:35:06 +0000 (UTC) Cc: bug-gnu-emacs@gnu.org To: "Lennart Borgman \(gmail\)" Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Jul 09 03:35:05 2007 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1I7i9X-0003Ha-B5 for geb-bug-gnu-emacs@m.gmane.org; Mon, 09 Jul 2007 03:35:03 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1I7i9W-00023K-Fy for geb-bug-gnu-emacs@m.gmane.org; Sun, 08 Jul 2007 21:35:02 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1I7i9T-000233-OA for bug-gnu-emacs@gnu.org; Sun, 08 Jul 2007 21:34:59 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1I7i9T-00022d-5D for bug-gnu-emacs@gnu.org; Sun, 08 Jul 2007 21:34:59 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1I7i9S-00022V-SY for bug-gnu-emacs@gnu.org; Sun, 08 Jul 2007 21:34:58 -0400 Original-Received: from orlando.hostforweb.net ([216.246.45.90]) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1I7i9S-0006rN-GA for bug-gnu-emacs@gnu.org; Sun, 08 Jul 2007 21:34:58 -0400 Original-Received: from [66.225.201.151] (helo=mail.jpl.org) by orlando.hostforweb.net with esmtpa (Exim 4.63) (envelope-from ) id 1I7i9M-0004Mw-3t; Sun, 08 Jul 2007 20:34:52 -0500 X-Hashcash: 1:20:070709:lennart.borgman@gmail.com::TroFc0+EsdabqzNZ:0000000000000000000000000000000000004u2h X-Hashcash: 1:20:070709:bug-gnu-emacs@gnu.org::DulUk6n+O1ZUtpWD:00000000000000000000000000000000000000000f8b X-Face: #kKnN,xUnmKia.'[pp`; Omh}odZK)?7wQSl"4o04=EixTF+V[""w~iNbM9ZL+.b*_CxUmFk B#Fu[*?MZZH@IkN:!"\w%I_zt>[$nm7nQosZ<3eu; B:$Q_:p!',P.c0-_Cy[dz4oIpw0ESA^D*1Lw= L&i*6&( User-Agent: Gnus/5.110007 (No Gnus v0.7) Emacs/22.1.50 (gnu/linux) Cancel-Lock: sha1:h6W2JuR1d7GJszEYiMv+ZruBF4g= X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - orlando.hostforweb.net X-AntiAbuse: Original Domain - gnu.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - jpl.org X-Source: X-Source-Args: X-Source-Dir: X-detected-kernel: Genre and OS details not recognized. X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:16111 Archived-At: >>>>> Katsumi Yamaoka wrote: >> I guess the reason the `coding-system' widget doesn't check whether >> the value is a coding system is for the coding systems that are >> defined afterward, e.g., the ones to be autoloaded. > Therefore, I modified the `coding-system' widget only for > `file-coding-system-alist' so that it may not issue an error > signal when the value is a function. Committed in both > the Emacs trunk and the EMACS_22_BASE branch. Oops. The fix I committed was incorrect. I've fixed it again in the trunk and the EMACS_22_BASE branch. The following patch for the Emacs 22.1 release represents what I did: *** cus-start.el~ Thu Apr 12 03:05:31 2007 --- cus-start.el Mon Jul 9 01:33:47 2007 *************** *** 122,129 **** :value (undecided . undecided) (coding-system :tag "Decoding") (coding-system :tag "Encoding")) ! (coding-system :tag "Single coding system" ! :value undecided) (function :value ignore)))) (selection-coding-system mule coding-system) ;; dired.c --- 122,132 ---- :value (undecided . undecided) (coding-system :tag "Decoding") (coding-system :tag "Encoding")) ! (coding-system ! :tag "Single coding system" ! :value undecided ! :match (lambda (widget value) ! (and value (not (functionp value))))) (function :value ignore)))) (selection-coding-system mule coding-system) ;; dired.c Regards,