From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Katsumi Yamaoka Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] master 90e9cf8: * lisp/gnus/mailcap.el (mailcap-mime-data): Date: Wed, 21 Oct 2015 09:32:11 +0900 Organization: Emacsen advocacy group Message-ID: References: <20151020111910.1636.10529@vcs.savannah.gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1445387560 6179 80.91.229.3 (21 Oct 2015 00:32:40 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 21 Oct 2015 00:32:40 +0000 (UTC) Cc: Michael Sperber , emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Oct 21 02:32:25 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1ZohKL-00081h-2N for ged-emacs-devel@m.gmane.org; Wed, 21 Oct 2015 02:32:25 +0200 Original-Received: from localhost ([::1]:48586 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZohKK-0000Tm-2Y for ged-emacs-devel@m.gmane.org; Tue, 20 Oct 2015 20:32:24 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:56624) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZohKG-0000TX-Ay for emacs-devel@gnu.org; Tue, 20 Oct 2015 20:32:21 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZohKB-0003nx-FC for emacs-devel@gnu.org; Tue, 20 Oct 2015 20:32:18 -0400 Original-Received: from [216.246.47.56] (port=55595 helo=memphis.hostforweb.net) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZohKB-0003mg-BC for emacs-devel@gnu.org; Tue, 20 Oct 2015 20:32:15 -0400 Original-Received: from s70.gtokyofl21.vectant.ne.jp ([202.215.75.70]:62861 helo=localhost) by memphis.hostforweb.net with esmtpsa (TLSv1.2:AES128-GCM-SHA256:128) (Exim 4.85) (envelope-from ) id 1ZohK5-002vZU-RC; Tue, 20 Oct 2015 19:32:10 -0500 X-Face: #kKnN,xUnmKia.'[pp`; Omh}odZK)?7wQSl"4o04=EixTF+V[""w~iNbM9ZL+.b*_CxUmFk B#Fu[*?MZZH@IkN:!"\w%I_zt>[$nm7nQosZ<3eu; B:$Q_:p!',P.c0-_Cy[dz4oIpw0ESA^D*1Lw= L&i*6&( User-Agent: Gnus/5.130014 (=?utf-8?Q?=E7=9C=9F?= Gnus v0.14) Emacs/25.0.50 (i686-pc-cygwin) Cancel-Lock: sha1:ciM7TGVly8G4QUzAldOk7pKmgZs= X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - memphis.hostforweb.net X-AntiAbuse: Original Domain - gnu.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - jpl.org X-Get-Message-Sender-Via: memphis.hostforweb.net: authenticated_id: yamaokac/only user confirmed/virtual account not confirmed X-Source: X-Source-Args: X-Source-Dir: X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 216.246.47.56 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:192248 Archived-At: On Tue, 20 Oct 2015 10:15:09 -0400, Stefan Monnier wrote: >> ("pdf" >> (viewer . doc-view-mode) >> (type . "application/pdf") >> - (test . (eq window-system 'x))) >> + (test . (and (fboundp 'doc-view-mode) >> + (eq window-system 'x)))) > Should this be redundant? I mean shouldn't the generic code check > fboundp of the `viewer' anyway? Well, do you mean we should not add non-existent viewer to mailcap-mime-data in like this way? (defvar mailcap-mime-data `(("application" [...] ,@(when (fboundp 'doc-view-mode) '(("pdf" (viewer . doc-view-mode) (type . "application/pdf") (test . (eq window-system 'x))))) [...] It would be perhaps better than adding the fboundp check to the test token.