From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Katsumi Yamaoka Newsgroups: gmane.emacs.bugs Subject: bug#33653: 27.0.50; Change Gnus obarrays-as-hash-tables into real hash tables Date: Tue, 09 Apr 2019 09:55:23 +0900 Organization: Emacsen advocacy group Message-ID: References: <8736raz3ec.fsf@ericabrahamsen.net> <87y392xoht.fsf@ericabrahamsen.net> <87imxzxa4s.fsf@ericabrahamsen.net> <87a7hn3h3w.fsf@ericabrahamsen.net> <87a7hhtinz.fsf@ericabrahamsen.net> <87o95gqrfm.fsf@ericabrahamsen.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="11361"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (x86_64-pc-cygwin) Cc: "Basil L. Contovounesios" , Bastien Guerry , Adam =?UTF-8?Q?Sj=C3=B8gren?= , 33653@debbugs.gnu.org To: Eric Abrahamsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Apr 09 02:56:21 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hDf3i-0002ns-SD for geb-bug-gnu-emacs@m.gmane.org; Tue, 09 Apr 2019 02:56:18 +0200 Original-Received: from localhost ([127.0.0.1]:33084 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hDf3h-0001sj-Tn for geb-bug-gnu-emacs@m.gmane.org; Mon, 08 Apr 2019 20:56:17 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:52552) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hDf3W-0001s1-Al for bug-gnu-emacs@gnu.org; Mon, 08 Apr 2019 20:56:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hDf3T-0005da-Bw for bug-gnu-emacs@gnu.org; Mon, 08 Apr 2019 20:56:06 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:36833) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hDf3S-0005cv-PH for bug-gnu-emacs@gnu.org; Mon, 08 Apr 2019 20:56:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hDf3S-0001KW-Nq for bug-gnu-emacs@gnu.org; Mon, 08 Apr 2019 20:56:02 -0400 X-Loop: help-debbugs@gnu.org In-Reply-To: <8736raz3ec.fsf@ericabrahamsen.net> Resent-From: Katsumi Yamaoka Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 09 Apr 2019 00:56:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 33653 X-GNU-PR-Package: emacs Original-Received: via spool by 33653-submit@debbugs.gnu.org id=B33653.15547713285060 (code B ref 33653); Tue, 09 Apr 2019 00:56:02 +0000 Original-Received: (at 33653) by debbugs.gnu.org; 9 Apr 2019 00:55:28 +0000 Original-Received: from localhost ([127.0.0.1]:50376 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hDf2u-0001JW-9q for submit@debbugs.gnu.org; Mon, 08 Apr 2019 20:55:28 -0400 Original-Received: from goldenrod.birch.relay.mailchannels.net ([23.83.209.74]:48757) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hDf2s-0001JO-Ju for 33653@debbugs.gnu.org; Mon, 08 Apr 2019 20:55:27 -0400 X-Sender-Id: tih5qno0ow|x-authuser|yamaoka@hampton.hostforweb.net Original-Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id 6F1DB124750; Tue, 9 Apr 2019 00:55:24 +0000 (UTC) Original-Received: from hampton.hostforweb.net (unknown [100.96.20.50]) (Authenticated sender: tih5qno0ow) by relay.mailchannels.net (Postfix) with ESMTPA id 4B5DC124CE9; Tue, 9 Apr 2019 00:55:23 +0000 (UTC) X-Sender-Id: tih5qno0ow|x-authuser|yamaoka@hampton.hostforweb.net Original-Received: from hampton.hostforweb.net (hampton.hostforweb.net [172.245.115.217]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384) by 0.0.0.0:2500 (trex/5.17.2); Tue, 09 Apr 2019 00:55:24 +0000 X-MC-Relay: Neutral X-MailChannels-SenderId: tih5qno0ow|x-authuser|yamaoka@hampton.hostforweb.net X-MailChannels-Auth-Id: tih5qno0ow X-Power-Bubble: 4696fe1c6c124cba_1554771323979_1206876961 X-MC-Loop-Signature: 1554771323979:461705882 X-MC-Ingress-Time: 1554771323978 Original-Received: from s70.gtokyofl21.vectant.ne.jp ([202.215.75.70]:60001 helo=localhost) by hampton.hostforweb.net with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.89_1) (envelope-from ) id 1hDf2l-00Aqdh-E7; Mon, 08 Apr 2019 19:55:20 -0500 X-Face: #kKnN,xUnmKia.'[pp`; Omh}odZK)?7wQSl"4o04=EixTF+V[""w~iNbM9ZL+.b*_CxUmFk B#Fu[*?MZZH@IkN:!"\w%I_zt>[$nm7nQosZ<3eu; B:$Q_:p!',P.c0-_Cy[dz4oIpw0ESA^D*1Lw= L&i*6&( Cancel-Lock: sha1:8bDBR0fRhBie6nh12XzJfvdAB4M= X-OutGoing-Spam-Status: No, score=-0.2 X-AuthUser: yamaoka@hampton.hostforweb.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:157383 Archived-At: On Mon, 08 Apr 2019 11:31:57 -0700, Eric Abrahamsen wrote: > On 04/08/19 17:13 PM, Katsumi Yamaoka wrote: >> - (with-temp-buffer >> + (mm-with-unibyte-buffer >> (insert-buffer-substring cur) > I was asking on emacs.devel about that, and with Andreas' help came up > with the attached patch. It's a terrible hack, but it seems to work, and > I think would be good as an intermediate step. > What you're doing -- changing the unibyte/multibyte status of the > buffers -- is I think part of the final, more correct solution to the > problem, that will leave group names decoded everywhere. But I would > like to Gnus back into an intermediate working state before tackling > that... > What do you think? Whatever we should do finally, isn't it necessary to make Gnus on Emacs master work now anyway even if it is immature? Those who like the *latest* code by any means (me included) would be coming to use it sooner or later. So, I'd like you to install to master a fix whatever makes Gnus work. > --- a/lisp/gnus/gnus-start.el > +++ b/lisp/gnus/gnus-start.el [...] > (setq group (read cur) > + group > + (encode-coding-string > + (cond ((numberp group) > + (number-to-string group)) > + ((symbolp group) > + (symbol-name group)) > + ((stringp group) > + group)) > + 'latin-1)))) Makes sense to me. Though encoding the one having already encoded looks redundant, I have no idea other than this and my patch, and benchmark reports there is no notably difference in speed between this and my patch. Anyway I verified it works for listing the nnml:=E3=83=86=E3=82=B9=E3=83=88= group. > --- a/lisp/gnus/nnmail.el > +++ b/lisp/gnus/nnmail.el > --- a/lisp/gnus/nnml.el > +++ b/lisp/gnus/nnml.el Verified that those patches enable updating groups by `M-g'. > --- a/lisp/gnus/nnrss.el > +++ b/lisp/gnus/nnrss.el Verified that I can read some feeds. Thanks.