bug#18980: 24.4; gnus in 24.4 breaks load-path?

bug#18980: 24.4; gnus in 24.4 breaks load-path?

[Trent W. Buck]

After upgrading from 24.3 to 24.4, "emacs -f gnus" stopped working:

    Cannot open load file: no such file or directory, image

If I -f toggle-debug-on-error first, it says

    Cannot open load file: no such file or directory, debug

If I manually (require 'image) first, the problem goes away:

    $ emacs --batch -q -Q -l ~/.gnus.el -f gnus -f gnus-group-exit -f kill-emacs
    Reading /home/twb/.newsrc.eld...
    Opening nnfolder server on archive...
    Opening nnfolder server on archive...done
    Opening nntp server on news.internode.on.net...
    Opening nntp server on news.internode.on.net...done
    No new newsgroups
    Checking new news...
    Cannot open load file: no such file or directory, image

    $ emacs --batch -q -Q -l ~/.gnus.el -eval "(require 'image)" -f gnus -f gnus-group-exit -f kill-emacs
    Reading /home/twb/.newsrc.eld...
    Opening nnfolder server on archive...
    Opening nnfolder server on archive...done
    Opening nntp server on news.internode.on.net...
    Opening nntp server on news.internode.on.net...done
    No new newsgroups
    Checking new news...
    Reading active file from archive via nnfolder...
    Reading active file from archive via nnfolder...
    Reading active file from archive via nnfolder...done
    Reading active file via nndraft...
    Reading active file via nndraft...
    Reading active file via nndraft...done
    Checking new news...done
    Saving file /home/twb/.newsrc...
    Wrote /home/twb/.newsrc
    Saving /home/twb/.newsrc.eld...
    Saving file /home/twb/.newsrc.eld...
    Wrote /home/twb/.newsrc.eld
    Saving /home/twb/.newsrc.eld...done

Tracing shows it is not searching the full load-path:

    $ strace -o/tmp/trace -etrace=file emacs --batch -q -Q -l ~/.gnus.el -f toggle-debug-on-error -f gnus
    [...]
    $ grep '\<debug\>' /tmp/trace
    execve("/usr/bin/emacs", ["emacs", "--batch", "-q", "-Q", "-l", "/home/twb/.gnus.el", "-f", "toggle-debug-on-error", "-f", "gnus"], [/* 60 vars */]) = 0
    open("/usr/share/emacs/24.4/etc/images/gnus/debug.elc", O_RDONLY|O_CLOEXEC) = -1 ENOENT (No such file or directory)
    open("/usr/share/emacs/24.4/etc/images/gnus/debug.elc.gz", O_RDONLY|O_CLOEXEC) = -1 ENOENT (No such file or directory)
    open("/usr/share/emacs/24.4/etc/images/gnus/debug.el", O_RDONLY|O_CLOEXEC) = -1 ENOENT (No such file or directory)
    open("/usr/share/emacs/24.4/etc/images/gnus/debug.el.gz", O_RDONLY|O_CLOEXEC) = -1 ENOENT (No such file or directory)
    $ dlocate /debug.elc
    emacs24-common: /usr/share/emacs/24.4/lisp/emacs-lisp/debug.elc

My .gnus.el is not interesting:

    (setq gnus-select-method '(nntp "news.gmane.org")
          gnus-secondary-select-methods '((nntp "news.internode.on.net")) ; for asr
          gnus-treat-date-local 'head
          ;; Discarding text/html and show the text/plain version.
          mm-discouraged-alternatives '("text/html" "multipart/related")
          gnus-buttonized-mime-types '("multipart/alternative" "multipart/signed"))



In GNU Emacs 24.4.1 (x86_64-pc-linux-gnu)
 of 2014-10-26 on trouble, modified by Debian
System Description:	Debian GNU/Linux testing (jessie)

Configured using:
 `configure --build x86_64-linux-gnu --prefix=/usr
 --sharedstatedir=/var/lib --libexecdir=/usr/lib
 --localstatedir=/var/lib --infodir=/usr/share/info
 --mandir=/usr/share/man --with-pop=yes
 --enable-locallisppath=/etc/emacs24:/etc/emacs:/usr/local/share/emacs/24.4/site-lisp:/usr/local/share/emacs/site-lisp:/usr/share/emacs/24.4/site-lisp:/usr/share/emacs/site-lisp
 --build x86_64-linux-gnu --prefix=/usr --sharedstatedir=/var/lib
 --libexecdir=/usr/lib --localstatedir=/var/lib
 --infodir=/usr/share/info --mandir=/usr/share/man --with-pop=yes
 --enable-locallisppath=/etc/emacs24:/etc/emacs:/usr/local/share/emacs/24.4/site-lisp:/usr/local/share/emacs/site-lisp:/usr/share/emacs/24.4/site-lisp:/usr/share/emacs/site-lisp
 --with-x=no --without-gconf --without-gsettings 'CFLAGS=-g -O2
 -fstack-protector-strong -Wformat -Werror=format-security -Wall'
 CPPFLAGS=-D_FORTIFY_SOURCE=2 LDFLAGS=-Wl,-z,relro'

Important settings:
  value of $LC_COLLATE: C
  value of $LANG: en_AU.utf8
  locale-coding-system: utf-8-unix

Major mode: Fundamental

Minor modes in effect:
  xterm-mouse-mode: t
  ido-everywhere: t
  savehist-mode: t
  icomplete-mode: t
  show-paren-mode: t
  delete-selection-mode: t
  tooltip-mode: t
  electric-indent-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  column-number-mode: t
  line-number-mode: t
  transient-mark-mode: t

Recent input:
ESC x r e p o r t SPC e m a c s SPC b u g RET

Recent messages:
Loading /usr/share/emacs/site-lisp/magit/magit-install.el (source)...done
Loading /etc/emacs/site-start.d/50magit.el (source)...done
Loading /etc/emacs/site-start.d/50pylint.el (source)...
Loading pylint...done
Loading /etc/emacs/site-start.d/50pylint.el (source)...done
Loading /etc/emacs/site-start.d/50python-docutils.el (source)...done
Loading /etc/emacs/site-start.d/50w3m-el-snapshot.el (source)...done
Loading /etc/emacs/site-start.d/51debian-el.el (source)...done
Loading term/xterm...done
For information about GNU Emacs and the GNU system, type C-h C-a.

Load-path shadows:
/usr/share/emacs/24.4/site-lisp/debian-startup hides /usr/share/emacs/site-lisp/debian-startup
/usr/share/emacs/site-lisp/rst hides /usr/share/emacs/24.4/lisp/textmodes/rst
/usr/share/emacs24/site-lisp/dictionaries-common/ispell hides /usr/share/emacs/24.4/lisp/textmodes/ispell
/usr/share/emacs24/site-lisp/dictionaries-common/flyspell hides /usr/share/emacs/24.4/lisp/textmodes/flyspell

Features:
(shadow sort gnus-util mail-extr emacsbug message format-spec rfc822 mml
easymenu mml-sec mm-decode mm-bodies mm-encode mail-parse rfc2231
mailabbrev gmm-utils mailheader mule-util xterm advice sendmail rfc2047
rfc2045 ietf-drums mm-util help-fns mail-prsvr mail-utils jka-compr
edmacro kmacro cl-loaddefs cl-lib disp-table xt-mouse ido savehist
icomplete time-date paren delsel saveplace debian-el debian-el-loaddefs
w3m-load pylint compile comint regexp-opt ansi-color ring tool-bar
50magit emacs-goodies-el emacs-goodies-custom emacs-goodies-loaddefs
easy-mmode dpkg-dev-el dpkg-dev-el-loaddefs tooltip electric uniquify
ediff-hook vc-hooks lisp-float-type tabulated-list newcomment lisp-mode
prog-mode register page menu-bar rfn-eshadow timer select mouse jit-lock
font-lock syntax facemenu font-core frame cham georgian utf-8-lang
misc-lang vietnamese tibetan thai tai-viet lao korean japanese hebrew
greek romanian slovak czech european ethiopic indian cyrillic chinese
case-table epa-hook jka-cmpr-hook help simple abbrev minibuffer nadvice
loaddefs button faces cus-face macroexp files text-properties overlay
sha1 md5 base64 format env code-pages mule custom widget
hashtable-print-readable backquote make-network-process dbusbind
gfilenotify multi-tty emacs)

Memory information:
((conses 16 108780 5202)
 (symbols 48 19433 0)
 (miscs 40 41 96)
 (strings 32 32329 4871)
 (string-bytes 1 763456)
 (vectors 16 9258)
 (vector-slots 8 355633 14422)
 (floats 8 69 208)
 (intervals 56 211 0)
 (buffers 960 11)
 (heap 1024 29840 825))

bug#18980: 24.4; gnus in 24.4 breaks load-path?

[Katsumi Yamaoka]

On Fri, 07 Nov 2014 10:31:16 +1100, Trent W. Buck wrote:
> After upgrading from 24.3 to 24.4, "emacs -f gnus" stopped working:

>     Cannot open load file: no such file or directory, image

Thanks.  This should have been fixed as the bug#18813[1] in
the Emacs repositories.  The diff is below:

--8<---------------cut here---------------start------------->8---
--- a/lisp/gnus/gnus.el	2014-03-23 23:13:36 +0000
+++ d/lisp/gnus/gnus.el	2014-10-27 03:51:18 +0000
@@ -328,8 +328,9 @@
   (if (fboundp 'find-image)
       (defun gnus-mode-line-buffer-identification (line)
 	(let ((str (car-safe line))
-	      (load-path (mm-image-load-path)))
-	  (if (and (stringp str)
+	      (load-path (append (mm-image-load-path) load-path)))
+	  (if (and (display-graphic-p)
+		   (stringp str)
 		   (string-match "^Gnus:" str))
 	      (progn (add-text-properties
 		      0 5
--8<---------------cut here---------------end--------------->8---

[1] http://thread.gmane.org/gmane.emacs.bugs/95013