From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Katsumi Yamaoka Newsgroups: gmane.emacs.bugs Subject: bug#26862: Quit Gnus prompts about unsent messages, but messages can't be saved as drafts Date: Thu, 11 May 2017 15:01:29 +0900 Organization: Emacsen advocacy group Message-ID: References: <8737cdpdjj.fsf@ericabrahamsen.net> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: blaine.gmane.org 1494482535 3877 195.159.176.226 (11 May 2017 06:02:15 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Thu, 11 May 2017 06:02:15 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (i686-pc-cygwin) Cc: Eric Abrahamsen , 26862@debbugs.gnu.org To: Stephen Berman Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu May 11 08:02:09 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d8hAv-0000rg-LS for geb-bug-gnu-emacs@m.gmane.org; Thu, 11 May 2017 08:02:09 +0200 Original-Received: from localhost ([::1]:46358 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d8hB1-0004Jn-8g for geb-bug-gnu-emacs@m.gmane.org; Thu, 11 May 2017 02:02:15 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:41963) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d8hAv-0004Hm-Bn for bug-gnu-emacs@gnu.org; Thu, 11 May 2017 02:02:10 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1d8hAq-0000EM-Fe for bug-gnu-emacs@gnu.org; Thu, 11 May 2017 02:02:09 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:34821) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1d8hAq-0000E3-CN for bug-gnu-emacs@gnu.org; Thu, 11 May 2017 02:02:04 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1d8hAo-0001jU-BO; Thu, 11 May 2017 02:02:03 -0400 X-Loop: help-debbugs@gnu.org In-Reply-To: <8737cdpdjj.fsf@ericabrahamsen.net> Resent-From: Katsumi Yamaoka Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org, bugs@gnus.org Resent-Date: Thu, 11 May 2017 06:02:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 26862 X-GNU-PR-Package: emacs,gnus X-GNU-PR-Keywords: Original-Received: via spool by 26862-submit@debbugs.gnu.org id=B26862.14944824846606 (code B ref 26862); Thu, 11 May 2017 06:02:02 +0000 Original-Received: (at 26862) by debbugs.gnu.org; 11 May 2017 06:01:24 +0000 Original-Received: from localhost ([127.0.0.1]:37495 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d8hAB-0001iT-NY for submit@debbugs.gnu.org; Thu, 11 May 2017 02:01:23 -0400 Original-Received: from mail-hampton.hostforweb.net ([205.234.186.191]:56148 helo=hampton.hostforweb.net) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d8hA8-0001iF-Oa for 26862@debbugs.gnu.org; Thu, 11 May 2017 02:01:21 -0400 Original-Received: from s70.gtokyofl21.vectant.ne.jp ([202.215.75.70]:60000 helo=localhost) by hampton.hostforweb.net with esmtpsa (TLSv1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.87) (envelope-from ) id 1d8h9w-0039O4-RY; Thu, 11 May 2017 01:01:13 -0500 X-Face: #kKnN,xUnmKia.'[pp`; Omh}odZK)?7wQSl"4o04=EixTF+V[""w~iNbM9ZL+.b*_CxUmFk B#Fu[*?MZZH@IkN:!"\w%I_zt>[$nm7nQosZ<3eu; B:$Q_:p!',P.c0-_Cy[dz4oIpw0ESA^D*1Lw= L&i*6&( Cancel-Lock: sha1:5i19Gl9yJEvFak+xlIsV63n1BdM= X-OutGoing-Spam-Status: No, score=-2.9 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - hampton.hostforweb.net X-AntiAbuse: Original Domain - debbugs.gnu.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - jpl.org X-Get-Message-Sender-Via: hampton.hostforweb.net: authenticated_id: yamaoka/from_h X-Authenticated-Sender: hampton.hostforweb.net: yamaoka@jpl.org X-Source: X-Source-Args: X-Source-Dir: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:132440 Archived-At: On Wed, 10 May 2017 11:27:05 +0200, Stephen Berman wrote: > However, when I restart Gnus, I see that that unsent message is in the > Drafts group, i.e., Gnus in fact saved it. So it's a UI bug but doesn't > lose data. Good point. Yes, nndraft runs the auto-save on a modified draft with a certain period. Prompting a user for a modified draft is a normal operation of `kill-buffer', not Gnus' intention. So we may kill those buffers safely and silently. On Wed, 10 May 2017 18:42:33 +0900, Katsumi Yamaoka wrote: > It seems hard to make `C-c C-d' work in such a case. Instead, > how about killing those modified message buffers unconditionally? Thanks Eric for suggestions and verifying a revised patch. I've committed it in master: Where `do-auto-save' makes sure that latest drafts are saved. (set-buffer-modified-p nil) is necessary to kill modified buffers silently. (setq kill-buffer-hook nil) assumes that a user might set it for a certain purpose (I do it ;-), that might issue a useless prompt. Regards,