bug#16011: [patch] 24.3.50; message-send-mail-with-sendmail kills useful error message buffer

bug#16011: [patch] 24.3.50; message-send-mail-with-sendmail kills useful error message buffer

[Vitalie Spinu]

[-- Attachment #1: Type: text/plain, Size: 309 bytes --]


Hi, 

On error, message-send-mail-with-sendmail pops to the error message
buffer with an obvious intention for the user to see it. But then kills
the buffer.

Consequently the user sees only a completely useless, emacs generated
message like:

   error: "Sending...failed with exit value 78" 


   Vitalie



[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-message-send-mail-with-sendmail-don-t-kill-error-buf.patch --]
[-- Type: text/x-diff, Size: 904 bytes --]

From 757150148ebd6ac841133010b31c807191bf448b Mon Sep 17 00:00:00 2001
From: Vitalie Spinu <spinuvit@gmail.com>
Date: Sat, 30 Nov 2013 00:26:42 -0800
Subject: [PATCH] message-send-mail-with-sendmail: don't kill error buffer on
 error

---
 lisp/gnus/message.el | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/lisp/gnus/message.el b/lisp/gnus/message.el
index b7d0ada..f96cd7a 100644
--- a/lisp/gnus/message.el
+++ b/lisp/gnus/message.el
@@ -4739,7 +4739,9 @@ that instead."
 			    (list resend-to-addresses)
 			  '("-t"))))))
 	    (unless (or (null cpr) (and (numberp cpr) (zerop cpr)))
-              (if errbuf (pop-to-buffer errbuf))
+              (when errbuf
+                (pop-to-buffer errbuf)
+                (setq errbuf nil))
 	      (error "Sending...failed with exit value %d" cpr)))
 	  (when message-interactive
 	    (with-current-buffer errbuf
-- 
1.8.1.2

bug#16011: [patch] 24.3.50; message-send-mail-with-sendmail kills useful error message buffer

[Katsumi Yamaoka]

Vitalie Spinu wrote:
> On error, message-send-mail-with-sendmail pops to the error message
> buffer with an obvious intention for the user to see it. But then kills
> the buffer.

Applied the patch to Emacs trunk and Gnus master.  Thanks.