From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Katsumi Yamaoka Newsgroups: gmane.emacs.bugs Subject: bug#8640: 24.0.50; no pbm support on cygwin Date: Tue, 10 May 2011 17:44:56 +0900 Organization: Emacsen advocacy group Message-ID: References: NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: dough.gmane.org 1305017177 32441 80.91.229.12 (10 May 2011 08:46:17 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Tue, 10 May 2011 08:46:17 +0000 (UTC) Cc: 8640@debbugs.gnu.org To: Juanma Barranquero Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue May 10 10:46:10 2011 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([140.186.70.17]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1QJia2-0005fl-2W for geb-bug-gnu-emacs@m.gmane.org; Tue, 10 May 2011 10:46:10 +0200 Original-Received: from localhost ([::1]:45244 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QJia1-0008Jv-Ib for geb-bug-gnu-emacs@m.gmane.org; Tue, 10 May 2011 04:46:09 -0400 Original-Received: from eggs.gnu.org ([140.186.70.92]:41820) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QJiZw-0008Jq-63 for bug-gnu-emacs@gnu.org; Tue, 10 May 2011 04:46:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QJiZv-0005Iu-2I for bug-gnu-emacs@gnu.org; Tue, 10 May 2011 04:46:04 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:58686) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QJiZv-0005Ij-0f for bug-gnu-emacs@gnu.org; Tue, 10 May 2011 04:46:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1QJiZu-0001XZ-Ak; Tue, 10 May 2011 04:46:02 -0400 X-Loop: help-debbugs@gnu.org In-Reply-To: Resent-From: Katsumi Yamaoka Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 10 May 2011 08:46:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 8640 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 8640-submit@debbugs.gnu.org id=B8640.13050171235873 (code B ref 8640); Tue, 10 May 2011 08:46:02 +0000 Original-Received: (at 8640) by debbugs.gnu.org; 10 May 2011 08:45:23 +0000 Original-Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QJiZH-0001Wg-7z for submit@debbugs.gnu.org; Tue, 10 May 2011 04:45:23 -0400 Original-Received: from orlando.hostforweb.net ([216.246.45.90]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QJiZA-0001WN-Gz for 8640@debbugs.gnu.org; Tue, 10 May 2011 04:45:21 -0400 Original-Received: from localhost ([127.0.0.1]:57873) by orlando.hostforweb.net with esmtpa (Exim 4.69) (envelope-from ) id 1QJiZ1-0000Vr-Sn; Tue, 10 May 2011 03:45:08 -0500 X-Face: #kKnN,xUnmKia.'[pp`; Omh}odZK)?7wQSl"4o04=EixTF+V[""w~iNbM9ZL+.b*_CxUmFk B#Fu[*?MZZH@IkN:!"\w%I_zt>[$nm7nQosZ<3eu; B:$Q_:p!',P.c0-_Cy[dz4oIpw0ESA^D*1Lw= L&i*6&( User-Agent: Gnus/5.110018 (No Gnus v0.18) Emacs/24.0.50 (cygwin) Cancel-Lock: sha1:9s+HgN7zTfbBshV5qjED2XcT5bI= X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - orlando.hostforweb.net X-AntiAbuse: Original Domain - debbugs.gnu.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - jpl.org X-Source: X-Source-Args: X-Source-Dir: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Resent-Date: Tue, 10 May 2011 04:46:02 -0400 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:46369 Archived-At: Juanma Barranquero wrote: >> pbm image is not available in Emacs trunk built on cygwin at least >> after May 6: (image-type-available-p 'pbm) => nil >> Whereas png, jpeg, gif, xpm, etc. are all ok. > xbm is not available either. And of course is not cygwin-specific. Oh, that's bad. I didn't verify it for xbm and other platforms. >> I guess this is due >> to the recent changes in image.c. > Yes. >> Any hint? > More than a hint. I moved the library cache variable to w32 code, > turned CACHE_IMAGE_TYPE into a noop on non-Windows, and removed the > check on init-image-library. But I overlook the fact that the > predefined image types rely on being marked in the library cache as > available. That's because `image-type-available-p' always goes through > `init-image-library'. > Now, the fix is simple (the patch below fixes the problem), but we > should think whether it is cleaner to restore the library-cache to a > non-Windows specific code, or mark the only two predefined image types > in any other way, as the code below does. It's a bit ad-hoc, but > having the image types in the library cache, when they are not, in > fact, loaded from a library, is also a bit ugly. > Opinions and comments anyone? The patch did the trick. I hope it is installed even if it is not smart. It troubles at least Gnus users, since Gnus invokes ImageMagick's `display' whenever an article contains X-Face (it is the default behavior when pbm is unavailable). ;-) Thanks.