all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Katsumi Yamaoka <yamaoka@jpl.org>
To: Filipp Gunbin <fgunbin@fastmail.fm>
Cc: 32706@debbugs.gnu.org
Subject: bug#32706: 27.0.50; Gnus ignores gnus-visual nil after gnus-article-outlook-deuglify-article
Date: Wed, 12 Sep 2018 16:21:55 +0900	[thread overview]
Message-ID: <b4msh2fji3w.fsf@jpl.org> (raw)
In-Reply-To: <m2k1nrdcsr.fsf@fgunbin.playteam.ru>

On Tue, 11 Sep 2018 23:00:52 +0300, Filipp Gunbin wrote:
> I have gnus-visual set to nil and articles are not fontified (correct).

> But if I invoke `W Y f' (gnus-article-outlook-deuglify-article) on an
> article, then it gets fontified.  It's not the only command after which
> I observe such behavior.

I tried this fix at first:

--- deuglify.el~	2018-02-18 21:35:29.069455800 +0000
+++ deuglify.el	2018-09-12 07:18:02.820308500 +0000
@@ -301,3 +301,4 @@
     ;; this is a bug or not.
-    (gnus-article-highlight t)
+    (when (gnus-visual-p 'article-highlight 'highlight)
+      (gnus-article-highlight t))
     (gnus-treat-article nil)

But I found this function is still problematic.  That is,
`(gnus-treat-article nil)' there runs in an article including
headers, so, if gnus-visual is non-nil, the treatments are
performed on not only the article body but also the header ---
the header is buttonized if gnus-treat-buttonize is non-nil even
if gnus-treat-buttonize-head is nil, for example.  So, I've
installed the next one in the trunk:

--- deuglify.el~	2018-02-18 21:35:29.069455800 +0000
+++ deuglify-2.el	2018-09-12 07:18:02.821397300 +0000
@@ -300,6 +300,12 @@
     ;; prepared article removes all MIME parts.  I'm unsure whether
     ;; this is a bug or not.
-    (gnus-article-highlight t)
-    (gnus-treat-article nil)
+    (when (gnus-visual-p 'article-highlight 'highlight)
+      (gnus-article-highlight t))
+    (save-excursion
+      (save-restriction
+	(widen)
+	(article-goto-body)
+	(narrow-to-region (point) (point-max))
+	(gnus-treat-article nil)))
     (gnus-run-hooks 'gnus-article-prepare-hook
 		    'gnus-outlook-display-hook)))

Unfortunately I have no idea not to buttonize the header of a
forwarded message existing in the article as a mime part, though.





  reply	other threads:[~2018-09-12  7:21 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-11 20:00 bug#32706: 27.0.50; Gnus ignores gnus-visual nil after gnus-article-outlook-deuglify-article Filipp Gunbin
2018-09-12  7:21 ` Katsumi Yamaoka [this message]
2018-09-12 15:16   ` Filipp Gunbin
2018-09-13  0:02     ` Katsumi Yamaoka
2018-09-13 23:52       ` Filipp Gunbin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b4msh2fji3w.fsf@jpl.org \
    --to=yamaoka@jpl.org \
    --cc=32706@debbugs.gnu.org \
    --cc=fgunbin@fastmail.fm \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.