all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Katsumi Yamaoka <yamaoka@jpl.org>
To: Christophe.Troestler@umons.ac.be
Cc: 34387@debbugs.gnu.org
Subject: bug#34387: 26.1; Gnus: handle empty message parts
Date: Tue, 12 Feb 2019 13:34:09 +0900	[thread overview]
Message-ID: <b4msgwt7hha.fsf@jpl.org> (raw)
In-Reply-To: <87ef8igwdw.fsf@poincare.umons.ac.be>

On Fri, 08 Feb 2019 15:58:19 +0100, Christophe Troestler wrote:
> Some messages only contain an attachment (no body) and
> (gnus-article-prepare-display) choke on the empty part.
> More specifically, `gnus-mime-display-single' does
> (narrow-to-region beg (point)) which fails if the part is empty.

Could you let me know how it fails?  Otherwise, could you show
me a sample email in question?  Unfortunately I'm not successful
in making such an email that causes the problem so far, and trying
(narrow-to-region beg beg) and (narrow-to-region (point) (point))
cause nothing special.

But I found at least two other kinds of problems in relation to
an empty attachment:

1. In the article buffer, pressing the RET key on an empty
 text/plain attachment conceals the succeeding other attachments,
 does not toggle.  `g' restores them of course, though.

2. Some kind of an empty mail isn't able to be edited using the
 `e' command (gnus-summary-edit-article), that is, a single part
 email whose body is an empty attachment.  Gnus misunderstands
 that the header is its body.

On Fri, 08 Feb 2019 16:39:47 +0100, Christophe Troestler wrote:
> For those who encounter this problem, a fix that does not require to
> modify the body of the function gnus-mime-display-single is:

> (define-advice gnus-mime-display-single (:around (oldfn &rest handle) fix)
>   "Protect against bad handling of empty message parts."
>   (ignore-errors (apply oldfn handle)))

I'd like to fix those problems in the Gnus code. :)

Thanks.
Regards,





  parent reply	other threads:[~2019-02-12  4:34 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-08 14:58 bug#34387: 26.1; Gnus: handle empty message parts Christophe Troestler
     [not found] ` <handler.34387.B.154963794230369.ack@debbugs.gnu.org>
2019-02-08 15:39   ` bug#34387: Acknowledgement (26.1; Gnus: handle empty message parts) Christophe Troestler
2019-02-12  4:34 ` Katsumi Yamaoka [this message]
2019-02-12  7:31   ` bug#34387: 26.1; Gnus: handle empty message parts Christophe Troestler
2019-02-13  4:53     ` Katsumi Yamaoka
2019-02-13 17:26       ` Christophe Troestler
2019-02-13 23:20         ` Katsumi Yamaoka
2019-02-14  2:16           ` Katsumi Yamaoka
2019-02-14 12:30           ` Christophe Troestler
2019-02-14 22:50             ` Katsumi Yamaoka
2019-02-15  8:28               ` Christophe Troestler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b4msgwt7hha.fsf@jpl.org \
    --to=yamaoka@jpl.org \
    --cc=34387@debbugs.gnu.org \
    --cc=Christophe.Troestler@umons.ac.be \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.