From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Katsumi Yamaoka Newsgroups: gmane.emacs.devel,gmane.emacs.gnus.general Subject: Re: Top posting related changes in the cvs Date: Tue, 10 Apr 2007 08:15:00 +0900 Organization: Emacsen advocacy group Message-ID: References: <873b3hm942.fsf@ambire.localdomain> <87ps6ljc3q.fsf@ambire.localdomain> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1176175310 7571 80.91.229.12 (10 Apr 2007 03:21:50 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Tue, 10 Apr 2007 03:21:50 +0000 (UTC) Cc: "Gabor Z. Papp" , ding@gnus.org, emacs-devel@gnu.org To: Thien-Thi Nguyen Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Apr 10 05:20:57 2007 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1Hb34u-0002wQ-25 for ged-emacs-devel@m.gmane.org; Tue, 10 Apr 2007 01:15:16 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Hb38l-0005sf-FA for ged-emacs-devel@m.gmane.org; Mon, 09 Apr 2007 19:19:15 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Hb38i-0005pU-CI for emacs-devel@gnu.org; Mon, 09 Apr 2007 19:19:12 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Hb38h-0005kS-1H for emacs-devel@gnu.org; Mon, 09 Apr 2007 19:19:11 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Hb38g-0005jh-RQ for emacs-devel@gnu.org; Mon, 09 Apr 2007 19:19:10 -0400 Original-Received: from orlando.hostforweb.net ([216.246.45.90]) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1Hb34o-0002nl-80 for emacs-devel@gnu.org; Mon, 09 Apr 2007 19:15:10 -0400 Original-Received: from [66.225.201.151] (port=59634 helo=mail.jpl.org) by orlando.hostforweb.net with esmtpa (Exim 4.63) (envelope-from ) id 1Hb34p-0001Sz-Tr; Mon, 09 Apr 2007 18:15:12 -0500 X-Hashcash: 1:20:070409:ttn@gnuvola.org::8cm8A4KtEs9RNInc:0047BR X-Hashcash: 1:20:070409:gzp@papp.hu::yiz1Fd8/eze9ssaC:0000001oJ1 X-Hashcash: 1:20:070409:ding@gnus.org::bdlbmr1ZEMQ2aaD6:00000VeP X-Hashcash: 1:20:070409:emacs-devel@gnu.org::kiKtRyaTqEQiOVfb:00000000000000000000000000000000000000000027eM X-Face: #kKnN,xUnmKia.'[pp`; Omh}odZK)?7wQSl"4o04=EixTF+V[""w~iNbM9ZL+.b*_CxUmFk B#Fu[*?MZZH@IkN:!"\w%I_zt>[$nm7nQosZ<3eu; B:$Q_:p!',P.c0-_Cy[dz4oIpw0ESA^D*1Lw= L&i*6&( User-Agent: Gnus/5.110006 (No Gnus v0.6) Emacs/22.0.97 (gnu/linux) Cancel-Lock: sha1:P+wtkUhG2OJO5PfGPJzsiB0xIps= X-Antivirus-Scanner: Clean mail though you should still use an Antivirus X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - orlando.hostforweb.net X-AntiAbuse: Original Domain - gnu.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - jpl.org X-Source: X-Source-Args: X-Source-Dir: X-detected-kernel: Linux 2.6, seldom 2.4 (older, 4) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:69246 gmane.emacs.gnus.general:64506 Archived-At: >>>>> In <873b39bdti.fsf@ambire.localdomain> Thien-Thi Nguyen wrote: > () Katsumi Yamaoka > () Mon, 09 Apr 2007 15:40:40 +0900 > * message.el (message-yank-original): > Don't exchange point and mark. > I also removed the `(unless (< (point) (mark-marker)) ...)' test > since I think it will never return nil. > i have no opinion on No Gnus, just on the Gnus distributed w/ Emacs > (that i can play around with (and break, apparently)). Thank you for leaving it to me. >>>>> In >>>>> Reiner Steib wrote: > On Mon, Apr 09 2007, Katsumi Yamaoka wrote: > I'm not sure if I understand correctly. Are you saying we need this > patch in addition to the current code in Emacs (i.e. Gnus v5.11; > lisp/gnus/message.el rev. 1.117)? The code I modified is for making sure that the yanked text ends with a newline. The present one indeed has the code (unless (bolp) (insert ?\n)) , which works only if the point is at the end of yanked text by performing `message-exchange-point-and-mark'. However, Thien-Thi Nguyen's change made `message-exchange-point-and-mark' become not to be used usually (so I'm going to remove it). > If so, we should install it ASAP so that it gets more testing before > and during the next (final?) pretest. > Are you sure about the use of `(insert ?\n)' vs. `(newline)', > i.e. soft or hard newline? (I'm not sure; that's why I ask. :-)) > ,----[ f newline RET ] >| newline is an interactive compiled Lisp function in `simple'. >| It is bound to RET. >| (newline &optional arg) >| >| Insert a newline, and move to left margin of the new line if it's blank. >| If `use-hard-newlines' is non-nil, the newline is marked with the >| text-property `hard'. >| With arg, insert that many newlines. >| Call `auto-fill-function' if the current column number is greater >| than the value of `fill-column' and arg is nil. > `---- Thanks for clarifying it. Though I'm not still sure why `newline', not `(insert ?\n)', is used in the No Gnus version. (if message-cite-reply-above (progn (message-goto-body) (insert body-text) (newline) (message-goto-body) I think it is worth to use `newline' if it is the last function in a Lisp command to determine the cursor position and it is in the middle of a paragraph. However, `newline' used there does not seem to apply to such a case. So, I'll modify the following part of my patch (when message-cite-reply-above (message-goto-body) (insert body-text) (unless (bolp) (insert ?\n)) (newline) (message-goto-body)) into: (when message-cite-reply-above (message-goto-body) (insert body-text) (insert (if (bolp) "\n" "\n\n")) (message-goto-body)) Anyway, we have plentiful time to test it because it is in only No Gnus. :) Regards,