From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Katsumi Yamaoka Newsgroups: gmane.emacs.devel Subject: Re: emacs-25 ea512a7: * lisp/gnus/mm-decode.el (mm-convert-shr-links): Date: Tue, 26 Jul 2016 08:50:13 +0900 Organization: Emacsen advocacy group Message-ID: References: <20160622103320.1424.37554@vcs.savannah.gnu.org> <20160622103321.26666220123@vcs.savannah.gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1469490707 17290 80.91.229.3 (25 Jul 2016 23:51:47 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 25 Jul 2016 23:51:47 +0000 (UTC) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Jul 26 01:51:32 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1bRpel-0007qx-4G for ged-emacs-devel@m.gmane.org; Tue, 26 Jul 2016 01:51:31 +0200 Original-Received: from localhost ([::1]:36255 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bRpek-0008Np-AH for ged-emacs-devel@m.gmane.org; Mon, 25 Jul 2016 19:51:30 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:60567) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bRpe3-0008NN-83 for emacs-devel@gnu.org; Mon, 25 Jul 2016 19:50:48 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bRpdy-0001gF-UX for emacs-devel@gnu.org; Mon, 25 Jul 2016 19:50:46 -0400 Original-Received: from mail-hampton.hostforweb.net ([205.234.186.191]:52660 helo=hampton.hostforweb.net) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bRpdy-0001QJ-QG for emacs-devel@gnu.org; Mon, 25 Jul 2016 19:50:42 -0400 Original-Received: from s70.gtokyofl21.vectant.ne.jp ([202.215.75.70]:60108 helo=localhost) by hampton.hostforweb.net with esmtpsa (TLSv1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.87) (envelope-from ) id 1bRpdH-003dt3-Ns; Mon, 25 Jul 2016 18:50:00 -0500 X-Face: #kKnN,xUnmKia.'[pp`; Omh}odZK)?7wQSl"4o04=EixTF+V[""w~iNbM9ZL+.b*_CxUmFk B#Fu[*?MZZH@IkN:!"\w%I_zt>[$nm7nQosZ<3eu; B:$Q_:p!',P.c0-_Cy[dz4oIpw0ESA^D*1Lw= L&i*6&( User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (i686-pc-cygwin) Cancel-Lock: sha1:Kl3Q0DRlzvfLk1svFxAA6R+LUg0= X-OutGoing-Spam-Status: No, score=-2.9 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - hampton.hostforweb.net X-AntiAbuse: Original Domain - gnu.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - jpl.org X-Get-Message-Sender-Via: hampton.hostforweb.net: authenticated_id: yamaoka/from_h X-Authenticated-Sender: hampton.hostforweb.net: yamaoka@jpl.org X-Source: X-Source-Args: X-Source-Dir: X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x (barebone) [generic] X-Received-From: 205.234.186.191 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:206133 Archived-At: On Wed, 22 Jun 2016 10:33:20 +0000, Katsumi Yamaoka wrote: > branch: emacs-25 > commit ea512a7c2cd30206dd509b193c9faaba25640180 > Author: Katsumi Yamaoka > Commit: Katsumi Yamaoka > * lisp/gnus/mm-decode.el (mm-convert-shr-links): > Mask keys that launch `widget-button-click' (bug#22157). [...] > - (put-text-property start end 'local-map nil) > + ;; Remove keymap that `shr-urlify' adds. > + (put-text-property start end 'keymap nil) ...[1] This was done due to my having misunderstood the old code. So, I'd like to backport the fix (already done in master [2]) to emacs-25. May I do it? The purpose of the old code seems to be to make void a spurious `local-map' that something other might have added. My fault is that I thought `local-map' was a just a misspelling of `keymap'. The key bindings that shr adds must be preserved anyway [3]. [1] [2] [3] Regards,