Re: [Emacs-diffs] /srv/bzr/emacs/trunk r101135: merge the imagemagick branch to trunk

Re: [Emacs-diffs] /srv/bzr/emacs/trunk r101135: merge the imagemagick branch to trunk

[Juanma Barranquero]

A few nitpicks (not related to code, just the merge).

On Thu, Aug 19, 2010 at 09:35, Joakim <joakim@localhost.localdomain> wrote:

> modified:
>  ChangeLog

There's just a ChangeLog entry, at top level, but the changes should
be documented in the respective ChangeLogs (src/ChangeLog for src/*
changes, etc.).

>  configure
>  doc/lispref/display.texi
>  etc/NEWS
>  lisp/image-mode.el

These aren't mentioned in any ChangeLog.

> +2010-06-12 Joakim Verona <joakim@verona.se>

When merging branches, the date of the ChangeLog is the date the merge
is done, not that of the original changes (that information is
preserved by the branch history).

> +        * image.c: Add support for ImageMagick. When HAVE_IMAGEMAGICK is
> +        defined:

Usually that information is conveyed by "[HAVE_IMAGEMAGICK]".

> +        * config.in, Makefile.in, configure.in

These files do not have a change description in the entry.

    Juanma

Re: [Emacs-diffs] /srv/bzr/emacs/trunk r101135: merge the imagemagick branch to trunk

[joakim]

Juanma Barranquero <lekktu@gmail.com> writes:

> A few nitpicks (not related to code, just the merge).
>
> On Thu, Aug 19, 2010 at 09:35, Joakim <joakim@localhost.localdomain> wrote:
>
>> modified:
>>  ChangeLog
>
> There's just a ChangeLog entry, at top level, but the changes should
> be documented in the respective ChangeLogs (src/ChangeLog for src/*
> changes, etc.).
>
>>  configure
>>  doc/lispref/display.texi
>>  etc/NEWS
>>  lisp/image-mode.el
>
> These aren't mentioned in any ChangeLog.
>
>> +2010-06-12 Joakim Verona <joakim@verona.se>
>
> When merging branches, the date of the ChangeLog is the date the merge
> is done, not that of the original changes (that information is
> preserved by the branch history).
>
>> +        * image.c: Add support for ImageMagick. When HAVE_IMAGEMAGICK is
>> +        defined:
>
> Usually that information is conveyed by "[HAVE_IMAGEMAGICK]".
>
>> +        * config.in, Makefile.in, configure.in
>
> These files do not have a change description in the entry.

Ok, Ill try to fix these issues.

>     Juanma
>

-- 

Re: [Emacs-diffs] /srv/bzr/emacs/trunk r101135: merge the imagemagick branch to trunk

[Stefan Monnier]

> Ok, Ill try to fix these issues.

While you're at it, try to move the content of README.imagemagick into
some already existing file (maybe etc/TODO).


        Stefan

Re: [Emacs-diffs] /srv/bzr/emacs/trunk r101135: merge the imagemagick branch to trunk

[Katsumi Yamaoka]

bootstrap failed --with-imagemagick on Fedora 13 when dumping temacs.

gcc ... -o temacs ... -lMagickWand -lMagickCore ...
/usr/lib/gcc/i686-redhat-linux/4.4.4/../../../libMagickWand.so:\
 undefined reference to `__gcc_personality_v0@GCC_3.3.1'

I've installed these imagick packages today:

ImageMagick.i686            6.5.8.10-6.fc13 @anaconda-InstallationRepo-201005130056.i386
ImageMagick-c++.i686        6.5.8.10-6.fc13 @fedora
ImageMagick-c++-devel.i686  6.5.8.10-6.fc13 @fedora
ImageMagick-debuginfo.i686  6.5.8.10-6.fc13 @fedora-debuginfo
ImageMagick-devel.i686      6.5.8.10-6.fc13 @fedora
ImageMagick-djvu.i686       6.5.8.10-6.fc13 @fedora
ImageMagick-doc.i686        6.5.8.10-6.fc13 @fedora
ImageMagick-perl.i686       6.5.8.10-6.fc13 @fedora
gallery2-imagemagick.noarch 2.3.1-1.fc13    @fedora

Any other info I have to add?

Thanks.

Re: [Emacs-diffs] /srv/bzr/emacs/trunk r101135: merge the imagemagick branch to trunk

[Katsumi Yamaoka]

Katsumi Yamaoka wrote:
> bootstrap failed --with-imagemagick on Fedora 13 when dumping temacs.

> gcc ... -o temacs ... -lMagickWand -lMagickCore ...
> /usr/lib/gcc/i686-redhat-linux/4.4.4/../../../libMagickWand.so:\
>  undefined reference to `__gcc_personality_v0@GCC_3.3.1'

I was successful in bootstrapping Emacs after having installed
ImageMagick-6.6.3-7 in /usr/local/ from scratch.  Specifying
LDFLAGS to '-L/usr/local/lib -Xlinker -R/usr/local/lib' was needed.
Works fine so far.

My failure in the first try seems to be due to something wrong in
the imagick packages that Fedora provides.  Sorry for the noise.

> I've installed these imagick packages today:

> ImageMagick.i686            6.5.8.10-6.fc13 @anaconda-InstallationRepo-201005130056.i386
> ImageMagick-c++.i686        6.5.8.10-6.fc13 @fedora
> ImageMagick-c++-devel.i686  6.5.8.10-6.fc13 @fedora
> ImageMagick-debuginfo.i686  6.5.8.10-6.fc13 @fedora-debuginfo
> ImageMagick-devel.i686      6.5.8.10-6.fc13 @fedora
> ImageMagick-djvu.i686       6.5.8.10-6.fc13 @fedora
> ImageMagick-doc.i686        6.5.8.10-6.fc13 @fedora
> ImageMagick-perl.i686       6.5.8.10-6.fc13 @fedora
> gallery2-imagemagick.noarch 2.3.1-1.fc13    @fedora

> Any other info I have to add?

> Thanks.

Re: [Emacs-diffs] /srv/bzr/emacs/trunk r101135: merge the imagemagick branch to trunk

[Eli Zaretskii]

> Date: Fri, 20 Aug 2010 14:56:24 +0900
> From: Katsumi Yamaoka <yamaoka@jpl.org>
> 
> Katsumi Yamaoka wrote:
> > bootstrap failed --with-imagemagick on Fedora 13 when dumping temacs.
> 
> > gcc ... -o temacs ... -lMagickWand -lMagickCore ...
> > /usr/lib/gcc/i686-redhat-linux/4.4.4/../../../libMagickWand.so:\
> >  undefined reference to `__gcc_personality_v0@GCC_3.3.1'
> 
> I was successful in bootstrapping Emacs after having installed
> ImageMagick-6.6.3-7 in /usr/local/ from scratch.  Specifying
> LDFLAGS to '-L/usr/local/lib -Xlinker -R/usr/local/lib' was needed.
> Works fine so far.
> 
> My failure in the first try seems to be due to something wrong in
> the imagick packages that Fedora provides.  Sorry for the noise.

It's not noise.  I think we should have the ImageMagick version
information in README and the problematic versions in etc/PROBLEMS.

Re: [Emacs-diffs] /srv/bzr/emacs/trunk r101135: merge the imagemagick branch to trunk

[joakim]

Katsumi Yamaoka <yamaoka@jpl.org> writes:

> Katsumi Yamaoka wrote:
>> bootstrap failed --with-imagemagick on Fedora 13 when dumping temacs.
>
>> gcc ... -o temacs ... -lMagickWand -lMagickCore ...
>> /usr/lib/gcc/i686-redhat-linux/4.4.4/../../../libMagickWand.so:\
>>  undefined reference to `__gcc_personality_v0@GCC_3.3.1'
>
> I was successful in bootstrapping Emacs after having installed
> ImageMagick-6.6.3-7 in /usr/local/ from scratch.  Specifying
> LDFLAGS to '-L/usr/local/lib -Xlinker -R/usr/local/lib' was needed.
> Works fine so far.
>
> My failure in the first try seems to be due to something wrong in
> the imagick packages that Fedora provides.  Sorry for the noise.
>
>> I've installed these imagick packages today:
>
>> ImageMagick.i686            6.5.8.10-6.fc13 @anaconda-InstallationRepo-201005130056.i386
>> ImageMagick-c++.i686        6.5.8.10-6.fc13 @fedora
>> ImageMagick-c++-devel.i686  6.5.8.10-6.fc13 @fedora
>> ImageMagick-debuginfo.i686  6.5.8.10-6.fc13 @fedora-debuginfo
>> ImageMagick-devel.i686      6.5.8.10-6.fc13 @fedora
>> ImageMagick-djvu.i686       6.5.8.10-6.fc13 @fedora
>> ImageMagick-doc.i686        6.5.8.10-6.fc13 @fedora
>> ImageMagick-perl.i686       6.5.8.10-6.fc13 @fedora
>> gallery2-imagemagick.noarch 2.3.1-1.fc13    @fedora
>
>> Any other info I have to add?

This is odd. I developed the patch on Fedora 12 and 13. I tried a clean
build just now with the same versions you seem to have, withouth
problems.


>> Thanks.

--