Re: gnus-summary-catchup turns ticked into unread

[Katsumi Yamaoka <yamaoka@jpl.org>]

[-- Attachment #1: Type: text/plain, Size: 1155 bytes --]

>>>>> In <20070702160929.C21251C8115@galatea.esat.kuleuven.be>
>>>>>	Luc Van Eycken wrote:

> If I have a newsgroup with ticked persistent articles and I leave this
> group with the "c" key (gnus-summary-catchup-and-exit), all ticked articles
> are turned into unread non-ticked articles. It is a regression from Emacs 21,
> but I also believe this is a bug since it seems to contradict the info
> documentation.

That's a coincidence!  When I was wandering in the Agent code
today, I encountered the same trouble and reached to the same
place in gnus-sum.el.

> As far as I can see, it is due to the addition of gnus-newsgroup-unfetched
> inside the function gnus-summary-catchup (gnus-sum.el line 10517).
> Since this is a Gnus 5.11 addition, I assume that removing it again is not
> the correct solution.

I think regarding unfetched articles as unread articles is
correct.  The problem is that cached articles are not counted as
fetched articles, or Gnus forgot that those cached articles used
to have been fetched.  I'm not quite sure how it happens because
I'm new to the Agent.  But I briefly checked that the patch
attached below does the trick.


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: Type: text/x-patch, Size: 561 bytes --]

--- gnus-sum.el~	2007-06-06 15:39:11 +0000
+++ gnus-sum.el	2007-07-03 10:22:57 +0000
@@ -10514,7 +10514,8 @@
 		      (gnus-sorted-nunion
                        (gnus-sorted-intersection gnus-newsgroup-unreads
 						 gnus-newsgroup-downloadable)
-                       gnus-newsgroup-unfetched)))
+		       (gnus-sorted-difference gnus-newsgroup-unfetched
+					       gnus-newsgroup-cached))))
 	    ;; We actually mark all articles as canceled, which we
 	    ;; have to do when using auto-expiry or adaptive scoring.
 	    (gnus-summary-show-all-threads)

[-- Attachment #3: Type: text/plain, Size: 108 bytes --]


I am going to install it (or other) in the Gnus CVS repository
after learning the Agent further.

Regards,

[-- Attachment #4: Type: text/plain, Size: 149 bytes --]

_______________________________________________
bug-gnu-emacs mailing list
bug-gnu-emacs@gnu.org
http://lists.gnu.org/mailman/listinfo/bug-gnu-emacs