[emacs-w3m:09652] Warning: `mapcar' called for effect; use `mapc' or...

[emacs-w3m:09652] Warning: `mapcar' called for effect; use `mapc' or...

[Katsumi Yamaoka]

Hi,

The most recent Emacs CVS warns about the use of mapcar when
compling emacs-w3m as follows:

In w3m-session-save:
w3m-session.el:126:6:Warning: `mapcar' called for effect; use `mapc' or
    `dolist' instead

In w3m-session-select:
w3m-session.el:242:8:Warning: `mapcar' called for effect; use `mapc' or
    `dolist' instead

In toplevel form:
shimbun/sb-tdiary.el:162:8:Warning: `mapcar' called for effect; use `mapc' or
    `dolist' instead

The beginning two warnings are proper.  Using mapc or dolist makes
the programs run fast, though it is not necessarily necessary.
However, the last one is improper.  The code warned is:

(luna-define-method shimbun-groups ((shimbun shimbun-tdiary))
  (mapcar 'car shimbun-tdiary-group-alist))

It should return a list of the `car's of `shimbun-tdiary-group-alist'.
Why it is warned may be that the bytecomp doesn't know what the
`luna-define-method' macro does.  Any idea?  I think pulling out
the `mapcar' element from `byte-compile-warnings' is not a good idea.

Regards,

Re: Warning: `mapcar' called for effect; use `mapc' or...

[Katsumi Yamaoka]

>>>>> In [emacs-w3m : No.09652] Katsumi Yamaoka wrote:

> In toplevel form:
> shimbun/sb-tdiary.el:162:8:Warning: `mapcar' called for effect; use `mapc' or
>     `dolist' instead

[...]

> However, the last one is improper.  The code warned is:

> (luna-define-method shimbun-groups ((shimbun shimbun-tdiary))
>   (mapcar 'car shimbun-tdiary-group-alist))

I must apologize for my silly misunderstanding.  The warning in
question is issued for the other code.  Please ignore this.

Sorry.

[emacs-w3m:09654] mapcar warnings (was: Warning: `mapcar' called for effect; use `mapc' or...)

[Leo]

On 2007-09-25 03:10 +0100, Katsumi Yamaoka wrote:
> Hi,
>
> The most recent Emacs CVS warns about the use of mapcar when
> compling emacs-w3m as follows:
>
> In w3m-session-save:
> w3m-session.el:126:6:Warning: `mapcar' called for effect; use `mapc' or
>     `dolist' instead
[...]

For info.

I did a fresh install Emacs the day before and there were tons of such
warnings in compiling the elisp files.

-- 
.:  Leo  :.  [ sdl.web AT gmail.com ]  .:  [ GPG Key: 9283AA3F ]  :.

       Use the most powerful email client -- http://gnus.org/