From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Katsumi Yamaoka Newsgroups: gmane.emacs.bugs Subject: bug#18051: trunk r117751: Improve robustness of new string-collation code. Date: Thu, 28 Aug 2014 08:57:19 +0900 Organization: Emacsen advocacy group Message-ID: References: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1409183902 14043 80.91.229.3 (27 Aug 2014 23:58:22 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 27 Aug 2014 23:58:22 +0000 (UTC) Cc: 18051@debbugs.gnu.org To: Paul Eggert Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Aug 28 01:58:15 2014 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1XMn6V-0003X1-92 for geb-bug-gnu-emacs@m.gmane.org; Thu, 28 Aug 2014 01:58:15 +0200 Original-Received: from localhost ([::1]:33701 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XMn6U-0002Gh-U5 for geb-bug-gnu-emacs@m.gmane.org; Wed, 27 Aug 2014 19:58:14 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:46202) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XMn6N-0002GJ-6J for bug-gnu-emacs@gnu.org; Wed, 27 Aug 2014 19:58:12 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XMn6I-0002Hq-5G for bug-gnu-emacs@gnu.org; Wed, 27 Aug 2014 19:58:07 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:46987) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XMn6I-0002Hm-2X for bug-gnu-emacs@gnu.org; Wed, 27 Aug 2014 19:58:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1XMn6H-0000yK-P9 for bug-gnu-emacs@gnu.org; Wed, 27 Aug 2014 19:58:01 -0400 X-Loop: help-debbugs@gnu.org In-Reply-To: <87ha2f5gp8.fsf@web.de> Resent-From: Katsumi Yamaoka Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 27 Aug 2014 23:58:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 18051 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 18051-submit@debbugs.gnu.org id=B18051.14091838383682 (code B ref 18051); Wed, 27 Aug 2014 23:58:01 +0000 Original-Received: (at 18051) by debbugs.gnu.org; 27 Aug 2014 23:57:18 +0000 Original-Received: from localhost ([127.0.0.1]:53930 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XMn5a-0000xJ-7T for submit@debbugs.gnu.org; Wed, 27 Aug 2014 19:57:18 -0400 Original-Received: from mail-hampton.hostforweb.net ([205.234.186.191]:42172 helo=hampton.hostforweb.net) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XMn5W-0000x0-Ew for 18051@debbugs.gnu.org; Wed, 27 Aug 2014 19:57:16 -0400 Original-Received: from localhost.localdomain ([127.0.0.1]:59346 helo=localhost) by hampton.hostforweb.net with smtp (Exim 4.82) (envelope-from ) id 1XMn5K-0044Vh-DH; Wed, 27 Aug 2014 18:57:07 -0500 X-Face: #kKnN,xUnmKia.'[pp`; Omh}odZK)?7wQSl"4o04=EixTF+V[""w~iNbM9ZL+.b*_CxUmFk B#Fu[*?MZZH@IkN:!"\w%I_zt>[$nm7nQosZ<3eu; B:$Q_:p!',P.c0-_Cy[dz4oIpw0ESA^D*1Lw= L&i*6&( User-Agent: Gnus/5.130012 (=?UTF-8?Q?=E7=9C=9F?= Gnus v0.12) Emacs/24.4.50 (i686-pc-cygwin) Cancel-Lock: sha1:yoRwniHfUquawU+h+Hzv3FmFdsg= X-OutGoing-Spam-Status: No, score=-2.9 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - hampton.hostforweb.net X-AntiAbuse: Original Domain - debbugs.gnu.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - jpl.org X-Get-Message-Sender-Via: hampton.hostforweb.net: acl_c_authenticated_local_user: yamaoka X-Source: X-Source-Args: X-Source-Dir: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:92749 Archived-At: On Wed, 27 Aug 2014 18:56:52 +0000, Paul Eggert wrote: > ------------------------------------------------------------ > revno: 117751 [...] > message: > Improve robustness of new string-collation code. > * configure.ac (newlocale): Check for this, not for uselocale. > * src/sysdep.c (LC_COLLATE, LC_COLLATE_MASK, freelocale, locale_t) > (newlocale, wcscoll_l): Define substitutes for platforms that > lack them, so as to simplify the mainline code. > (str_collate): Simplify the code by assuming the above definitions. > Use wcscoll_l, not uselocale, as uselocale is too fragile. For > example, the old version left the Emacs in the wrong locale if > wcscoll reported an error. Use 'int', not ptrdiff_t, for the int > result. Report an error if newlocale fails. Emacs build gets stopped on Cygwin probably due to this change. gcc [...options below...] sysdep.c sysdep.c: In function 'str_collate': sysdep.c:3706:33: error: 'LC_COLLATE_MASK' undeclared (first use in this function) locale_t loc = newlocale (LC_COLLATE_MASK, SSDATA (lc_collate), 0); ^ sysdep.c:3706:33: note: each undeclared identifier is reported only once for each function it appears in Makefile:336: recipe for target 'sysdep.o' failed make[1]: *** [sysdep.o] Error 1 Thanks. gcc options: -std=gnu99 -c -Demacs -I. -I. -I../lib -I../lib -D_REENTRANT -I/usr/include/gtk-3.0 -I/usr/include/at-spi2-atk/2.0 -I/usr/include/gtk-3.0 -I/usr/include/gio-unix-2.0/ I/usr/include/cairo --I/usr/include/pango-1.0 I/usr/include/harfbuzz -I/usr/include/pango-1.0 -I/usr/include/atk-1.0 -I/usr/include/cairo I/usr/include/pixman-1 --I/usr/include/freetype2 I/usr/include/libpng15 -I/usr/include/freetype2 -I/usr/include/libpng15 -I/usr/include/gdk-pixbuf-2.0 -I/usr/include/libpng15 -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -I/usr/include/freetype2 -I/usr/include/libpng15 -I/usr/include/freetype2 I/usr/include/libpng15 --D_REENTRANT -I/usr/include/librsvg-2.0 I/usr/include/gdk-pixbuf-2.0 --I/usr/include/libpng15 I/usr/include/cairo -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -I/usr/include/pixman-1 -I/usr/include/freetype2 -I/usr/include/libpng15 I/usr/include/freetype2 --I/usr/include/libpng15 -fopenmp I/usr/include/ImageMagick --I/usr/include/libpng15 I/usr/include/libxml2 -I/usr/include/dbus-1.0 -I/usr/lib/dbus-1.0/include -D_REENTRANT I/usr/include/glib-2.0 --I/usr/lib/glib-2.0/include D_REENTRANT -I/usr/include/gconf/2 --I/usr/include/dbus-1.0 I/usr/lib/dbus-1.0/include --I/usr/include/glib-2.0 I/usr/lib/glib-2.0/include --I/usr/include/glib-2.0 I/usr/lib/glib-2.0/include --I/usr/include/freetype2 I/usr/include/libpng15 -I/usr/include/freetype2 -I/usr/include/libpng15 -I/usr/include/freetype2 I/usr/include/libpng15 --MMD -MF deps/sysdep.d -MP I/usr/include/p11-kit-1 -D_REENTRANT --I/usr/include/glib-2.0 I/usr/lib/glib-2.0/include -g3 -O2