From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Katsumi Yamaoka Newsgroups: gmane.emacs.devel Subject: Re: emacs-25 ea512a7: * lisp/gnus/mm-decode.el (mm-convert-shr-links): Date: Tue, 27 Sep 2016 07:35:34 +0900 Organization: Emacsen advocacy group Message-ID: References: <20160622103320.1424.37554@vcs.savannah.gnu.org> <20160622103321.26666220123@vcs.savannah.gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: blaine.gmane.org 1474929443 28764 195.159.176.226 (26 Sep 2016 22:37:23 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 26 Sep 2016 22:37:23 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2.50 (i686-pc-cygwin) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Sep 27 00:37:19 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1boeWC-00055z-UZ for ged-emacs-devel@m.gmane.org; Tue, 27 Sep 2016 00:37:01 +0200 Original-Received: from localhost ([::1]:46948 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1boeWB-0006ny-Bs for ged-emacs-devel@m.gmane.org; Mon, 26 Sep 2016 18:36:59 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:58161) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1boeVf-0006iE-4i for emacs-devel@gnu.org; Mon, 26 Sep 2016 18:36:28 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1boeVa-0005lv-45 for emacs-devel@gnu.org; Mon, 26 Sep 2016 18:36:26 -0400 Original-Received: from mail-hampton.hostforweb.net ([205.234.186.191]:37889 helo=hampton.hostforweb.net) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1boeVZ-0005WP-W5 for emacs-devel@gnu.org; Mon, 26 Sep 2016 18:36:22 -0400 Original-Received: from s70.gtokyofl21.vectant.ne.jp ([202.215.75.70]:60000 helo=localhost) by hampton.hostforweb.net with esmtpsa (TLSv1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.87) (envelope-from ) id 1boeUq-004AW3-DN; Mon, 26 Sep 2016 17:35:37 -0500 X-Face: #kKnN,xUnmKia.'[pp`; Omh}odZK)?7wQSl"4o04=EixTF+V[""w~iNbM9ZL+.b*_CxUmFk B#Fu[*?MZZH@IkN:!"\w%I_zt>[$nm7nQosZ<3eu; B:$Q_:p!',P.c0-_Cy[dz4oIpw0ESA^D*1Lw= L&i*6&( Cancel-Lock: sha1:fCJZ8DeJ6ajU778TXRzXwi709qA= X-OutGoing-Spam-Status: No, score=-2.9 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - hampton.hostforweb.net X-AntiAbuse: Original Domain - gnu.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - jpl.org X-Get-Message-Sender-Via: hampton.hostforweb.net: authenticated_id: yamaoka/from_h X-Authenticated-Sender: hampton.hostforweb.net: yamaoka@jpl.org X-Source: X-Source-Args: X-Source-Dir: X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x (barebone) [generic] X-Received-From: 205.234.186.191 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:207824 Archived-At: On Tue, 26 Jul 2016 08:50:13 +0900, Katsumi Yamaoka wrote: > On Wed, 22 Jun 2016 10:33:20 +0000, Katsumi Yamaoka wrote: >> branch: emacs-25 >> commit ea512a7c2cd30206dd509b193c9faaba25640180 >> Author: Katsumi Yamaoka >> Commit: Katsumi Yamaoka >> * lisp/gnus/mm-decode.el (mm-convert-shr-links): >> Mask keys that launch `widget-button-click' (bug#22157). > [...] >> - (put-text-property start end 'local-map nil) >> + ;; Remove keymap that `shr-urlify' adds. >> + (put-text-property start end 'keymap nil) > ...[1] > This was done due to my having misunderstood the old code. So, > I'd like to backport the fix (already done in master [2]) to > emacs-25. May I do it? I've backported the fix from master. > The purpose of the old code seems to be to make void a spurious > `local-map' that something other might have added. My fault is > that I thought `local-map' was a just a misspelling of `keymap'. > The key bindings that shr adds must be preserved anyway [3]. > [1] > [2] > [3] Regards,