all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Katsumi Yamaoka <yamaoka@jpl.org>
To: emacs-devel@gnu.org
Subject: Re: emacs-25 ea512a7: * lisp/gnus/mm-decode.el (mm-convert-shr-links):
Date: Tue, 27 Sep 2016 07:35:34 +0900	[thread overview]
Message-ID: <b4mmviu2ssp.fsf@jpl.org> (raw)
In-Reply-To: b4mpoq1uvka.fsf@jpl.org

On Tue, 26 Jul 2016 08:50:13 +0900, Katsumi Yamaoka wrote:
> On Wed, 22 Jun 2016 10:33:20 +0000, Katsumi Yamaoka wrote:
>> branch: emacs-25
>> commit ea512a7c2cd30206dd509b193c9faaba25640180
>> Author: Katsumi Yamaoka <yamaoka@jpl.org>
>> Commit: Katsumi Yamaoka <yamaoka@jpl.org>

>>     * lisp/gnus/mm-decode.el (mm-convert-shr-links):
>>     Mask keys that launch `widget-button-click' (bug#22157).
> [...]
>> -	(put-text-property start end 'local-map nil)
>> +	;; Remove keymap that `shr-urlify' adds.
>> +	(put-text-property start end 'keymap nil)
> ...[1]

> This was done due to my having misunderstood the old code.  So,
> I'd like to backport the fix (already done in master [2]) to
> emacs-25.  May I do it?

I've backported the fix from master.

> The purpose of the old code seems to be to make void a spurious
> `local-map' that something other might have added.  My fault is
> that I thought `local-map' was a just a misspelling of `keymap'.
> The key bindings that shr adds must be preserved anyway [3].

> [1] <http://lists.gnu.org/archive/html/emacs-diffs/2016-06/msg00173.html>
> [2] <http://article.gmane.org/gmane.emacs.diffs/136469>
> [3] <http://lists.gnu.org/archive/html/bug-gnu-emacs/2016-07/msg00729.html>

Regards,



      reply	other threads:[~2016-09-26 22:35 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20160622103320.1424.37554@vcs.savannah.gnu.org>
     [not found] ` <20160622103321.26666220123@vcs.savannah.gnu.org>
2016-07-25 23:50   ` emacs-25 ea512a7: * lisp/gnus/mm-decode.el (mm-convert-shr-links): Katsumi Yamaoka
2016-09-26 22:35     ` Katsumi Yamaoka [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b4mmviu2ssp.fsf@jpl.org \
    --to=yamaoka@jpl.org \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.