From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Katsumi Yamaoka Newsgroups: gmane.emacs.bugs Subject: bug#37515: 27.0.50; button.el doesn't support help-echo function Date: Thu, 26 Sep 2019 10:26:58 +0900 Organization: Emacsen advocacy group Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="153194"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (x86_64-pc-cygwin) Cc: "Jose A. Ortega Ruiz" To: 37515@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Sep 26 03:28:16 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iDIZr-000dij-O3 for geb-bug-gnu-emacs@m.gmane.org; Thu, 26 Sep 2019 03:28:15 +0200 Original-Received: from localhost ([::1]:58768 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iDIZo-0000e3-QA for geb-bug-gnu-emacs@m.gmane.org; Wed, 25 Sep 2019 21:28:12 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:40823) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iDIZf-0000dv-BN for bug-gnu-emacs@gnu.org; Wed, 25 Sep 2019 21:28:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iDIZe-0002Y2-Eb for bug-gnu-emacs@gnu.org; Wed, 25 Sep 2019 21:28:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:33729) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iDIZe-0002Xy-Bm for bug-gnu-emacs@gnu.org; Wed, 25 Sep 2019 21:28:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iDIZe-000341-6F for bug-gnu-emacs@gnu.org; Wed, 25 Sep 2019 21:28:02 -0400 X-Loop: help-debbugs@gnu.org In-Reply-To: Resent-From: Katsumi Yamaoka Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 26 Sep 2019 01:28:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 37515 X-GNU-PR-Package: emacs Original-Received: via spool by 37515-submit@debbugs.gnu.org id=B37515.156946123711701 (code B ref 37515); Thu, 26 Sep 2019 01:28:02 +0000 Original-Received: (at 37515) by debbugs.gnu.org; 26 Sep 2019 01:27:17 +0000 Original-Received: from localhost ([127.0.0.1]:42544 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iDIYu-00032f-O5 for submit@debbugs.gnu.org; Wed, 25 Sep 2019 21:27:16 -0400 Original-Received: from black.elm.relay.mailchannels.net ([23.83.212.19]:57443) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iDIYs-00032R-DT for 37515@debbugs.gnu.org; Wed, 25 Sep 2019 21:27:15 -0400 X-Sender-Id: tih5qno0ow|x-authuser|yamaoka@hampton.hostforweb.net Original-Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id 9EE12211FC; Thu, 26 Sep 2019 01:27:10 +0000 (UTC) Original-Received: from hampton.hostforweb.net (100-96-169-22.trex.outbound.svc.cluster.local [100.96.169.22]) (Authenticated sender: tih5qno0ow) by relay.mailchannels.net (Postfix) with ESMTPA id C64CF2137C; Thu, 26 Sep 2019 01:27:09 +0000 (UTC) X-Sender-Id: tih5qno0ow|x-authuser|yamaoka@hampton.hostforweb.net Original-Received: from hampton.hostforweb.net ([TEMPUNAVAIL]. [172.245.115.217]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384) by 0.0.0.0:2500 (trex/5.18.1); Thu, 26 Sep 2019 01:27:10 +0000 X-MC-Relay: Neutral X-MailChannels-SenderId: tih5qno0ow|x-authuser|yamaoka@hampton.hostforweb.net X-MailChannels-Auth-Id: tih5qno0ow X-White-Tank: 5458fb26480dc8b8_1569461230264_976741643 X-MC-Loop-Signature: 1569461230264:3684931518 X-MC-Ingress-Time: 1569461230264 Original-Received: from s70.gtokyofl21.vectant.ne.jp ([202.215.75.70]:60000 helo=localhost) by hampton.hostforweb.net with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1iDIYf-0063W5-5p; Wed, 25 Sep 2019 20:27:02 -0500 X-Face: #kKnN,xUnmKia.'[pp`; Omh}odZK)?7wQSl"4o04=EixTF+V[""w~iNbM9ZL+.b*_CxUmFk B#Fu[*?MZZH@IkN:!"\w%I_zt>[$nm7nQosZ<3eu; B:$Q_:p!',P.c0-_Cy[dz4oIpw0ESA^D*1Lw= L&i*6&( Cancel-Lock: sha1:UcyOi2YplsdM7wlghadHSsC8t9k= X-OutGoing-Spam-Status: No, score=-0.2 X-AuthUser: yamaoka@hampton.hostforweb.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:167200 Archived-At: On Thu, 26 Sep 2019 10:14:52 +0900, Katsumi Yamaoka wrote: > So, `forward-button' should be fixed to something like this: The patch I posted last was incomplete. Please replace it with: --8<---------------cut here---------------start------------->8--- --- button.el~ 2019-07-30 21:20:12.288879200 +0000 +++ button.el 2019-09-26 01:26:25.210300000 +0000 @@ -513,6 +513,9 @@ nil (user-error (if wrap "No buttons!" "No more buttons"))) (let ((msg (and display-message (button-get button 'help-echo)))) + (when (functionp msg) + (setq msg (funcall msg (selected-window) (current-buffer) + (button-start button)))) (when msg (message "%s" msg))) button))) --8<---------------cut here---------------end--------------->8--- Thanks.