From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Katsumi Yamaoka Newsgroups: gmane.emacs.bugs Subject: bug#8657: 24.0.50; Emacs code that seems to use `*-single-char-property-change' incorrectly Date: Tue, 07 Feb 2012 07:56:54 +0900 Organization: Emacsen advocacy group Message-ID: References: <87bopcnjt6.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: dough.gmane.org 1328569043 4538 80.91.229.3 (6 Feb 2012 22:57:23 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Mon, 6 Feb 2012 22:57:23 +0000 (UTC) Cc: 8657@debbugs.gnu.org To: Chong Yidong Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Feb 06 23:57:22 2012 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([140.186.70.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1RuXUo-0006mJ-IT for geb-bug-gnu-emacs@m.gmane.org; Mon, 06 Feb 2012 23:57:14 +0100 Original-Received: from localhost ([::1]:40256 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RuXUo-0004rQ-6Z for geb-bug-gnu-emacs@m.gmane.org; Mon, 06 Feb 2012 17:57:14 -0500 Original-Received: from eggs.gnu.org ([140.186.70.92]:40400) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RuXUl-0004r9-DK for bug-gnu-emacs@gnu.org; Mon, 06 Feb 2012 17:57:12 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RuXUk-0006L6-Aj for bug-gnu-emacs@gnu.org; Mon, 06 Feb 2012 17:57:11 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:54134) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RuXUk-0006L2-7v for bug-gnu-emacs@gnu.org; Mon, 06 Feb 2012 17:57:10 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1RuXVa-0003QV-41 for bug-gnu-emacs@gnu.org; Mon, 06 Feb 2012 17:58:02 -0500 X-Loop: help-debbugs@gnu.org In-Reply-To: Resent-From: Katsumi Yamaoka Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 06 Feb 2012 22:58:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 8657 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 8657-submit@debbugs.gnu.org id=B8657.132856903413108 (code B ref 8657); Mon, 06 Feb 2012 22:58:01 +0000 Original-Received: (at 8657) by debbugs.gnu.org; 6 Feb 2012 22:57:14 +0000 Original-Received: from localhost ([127.0.0.1]:57757 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1RuXUo-0003PN-7g for submit@debbugs.gnu.org; Mon, 06 Feb 2012 17:57:14 -0500 Original-Received: from orlando.hostforweb.net ([216.246.45.90]:59905) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1RuXUm-0003PG-Jg for 8657@debbugs.gnu.org; Mon, 06 Feb 2012 17:57:13 -0500 Original-Received: from localhost ([127.0.0.1]:37208) by orlando.hostforweb.net with smtp (Exim 4.69) (envelope-from ) id 1RuXTs-0005XJ-Ez; Mon, 06 Feb 2012 16:56:17 -0600 X-Face: #kKnN,xUnmKia.'[pp`; Omh}odZK)?7wQSl"4o04=EixTF+V[""w~iNbM9ZL+.b*_CxUmFk B#Fu[*?MZZH@IkN:!"\w%I_zt>[$nm7nQosZ<3eu; B:$Q_:p!',P.c0-_Cy[dz4oIpw0ESA^D*1Lw= L&i*6&( User-Agent: Gnus/5.130002 (=?UTF-8?Q?=E7=9C=9F?= Gnus v0.2) Emacs/24.0.93 (i686-pc-cygwin) Cancel-Lock: sha1:5XpPKyllXvB7y9c2eTsMZZ+x+1U= X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - orlando.hostforweb.net X-AntiAbuse: Original Domain - debbugs.gnu.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - jpl.org X-Source: X-Source-Args: X-Source-Dir: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:56604 Archived-At: Chong Yidong wrote: > Eli Zaretskii writes: >>> The behavior might have changed at some point in time, explaining the >>> above code. >> >> Or maybe the author was confusing next-single-char-property-change >> with next-single-property-change. >> >> In any case, those tests are redundant, because >> next-single-char-property-change already returns point-max when it >> finds no change in properties. > I went ahead and fixed them accordingly. But in XEmacs next-single-char-property-change will return nil if no property change is found. So I've modified the gnus-sum.el code into: (if (featurep 'xemacs) (or (next-single-char-property-change end 'invisible) (point-max)) (next-single-char-property-change end 'invisible))