all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Katsumi Yamaoka <yamaoka@jpl.org>
To: larsi@gnus.org
Cc: 24004-done@debbugs.gnu.org
Subject: bug#24004: 25.1.50; Animated images are no longer animated
Date: Tue, 19 Jul 2016 16:35:29 +0900	[thread overview]
Message-ID: <b4mk2gif5bx.fsf@jpl.org> (raw)
In-Reply-To: <m3d1mdc0en.fsf@gnus.org>

On Sat, 16 Jul 2016 13:01:04 +0200, Lars wrote:
> Test to reproduce:

> `M-x eww RET
> https://dropboxtechblog.files.wordpress.com/2016/07/lepton-4.gif RET'

> That's an animated GIF, but Emacs does not animate it.  I don't know
> when this started happening.

Started with 9c969e1.  In the beginning of `image-animate-timeout',
the 1st `when' will always get nil:

(defun image-animate-timeout (image n count time-elapsed limit target-time)
  "docstring"
  (when (and (buffer-live-p (plist-get (cdr image) :animate-buffer))
             ;; Delayed more than two seconds more than expected.
             (when (> (- (float-time) target-time) 2)
               (message "Stopping animation; animation possibly too big")
               nil))

So, the animation will never proceed.  I've fixed the logic as:

(defun image-animate-timeout (image n count time-elapsed limit target-time)
  "docstring"
  (when (and (buffer-live-p (plist-get (cdr image) :animate-buffer))
             ;; Delayed more than two seconds more than expected.
             (or (<= (- (float-time) target-time) 2)
                 (progn
                   (message "Stopping animation; animation possibly too big")
                   nil)))





  reply	other threads:[~2016-07-19  7:35 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-16 11:01 bug#24004: 25.1.50; Animated images are no longer animated Lars Ingebrigtsen
2016-07-19  7:35 ` Katsumi Yamaoka [this message]
2016-07-20 12:43   ` Lars Ingebrigtsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b4mk2gif5bx.fsf@jpl.org \
    --to=yamaoka@jpl.org \
    --cc=24004-done@debbugs.gnu.org \
    --cc=larsi@gnus.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.