From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Katsumi Yamaoka Newsgroups: gmane.emacs.bugs Subject: bug#23964: 25.1.50; `+' no longer works on images in Gnus article buffers Date: Fri, 22 Jul 2016 20:08:42 +0900 Organization: Emacsen advocacy group Message-ID: References: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Trace: ger.gmane.org 1469185768 13307 80.91.229.3 (22 Jul 2016 11:09:28 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 22 Jul 2016 11:09:28 +0000 (UTC) Cc: 23964@debbugs.gnu.org To: larsi@gnus.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Jul 22 13:09:18 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1bQYKP-0008A4-C1 for geb-bug-gnu-emacs@m.gmane.org; Fri, 22 Jul 2016 13:09:14 +0200 Original-Received: from localhost ([::1]:46498 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bQYKO-0000Sy-1Q for geb-bug-gnu-emacs@m.gmane.org; Fri, 22 Jul 2016 07:09:12 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:60389) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bQYKI-0000Sp-19 for bug-gnu-emacs@gnu.org; Fri, 22 Jul 2016 07:09:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bQYKD-0003eC-Sc for bug-gnu-emacs@gnu.org; Fri, 22 Jul 2016 07:09:04 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:48486) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bQYKD-0003e2-Pb for bug-gnu-emacs@gnu.org; Fri, 22 Jul 2016 07:09:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1bQYKD-0006th-Hj for bug-gnu-emacs@gnu.org; Fri, 22 Jul 2016 07:09:01 -0400 X-Loop: help-debbugs@gnu.org In-Reply-To: Resent-From: Katsumi Yamaoka Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 22 Jul 2016 11:09:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 23964 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 23964-submit@debbugs.gnu.org id=B23964.146918572726488 (code B ref 23964); Fri, 22 Jul 2016 11:09:01 +0000 Original-Received: (at 23964) by debbugs.gnu.org; 22 Jul 2016 11:08:47 +0000 Original-Received: from localhost ([127.0.0.1]:60823 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bQYJy-0006tA-SZ for submit@debbugs.gnu.org; Fri, 22 Jul 2016 07:08:47 -0400 Original-Received: from mail-hampton.hostforweb.net ([205.234.186.191]:40827 helo=hampton.hostforweb.net) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bQYJw-0006sx-Nv for 23964@debbugs.gnu.org; Fri, 22 Jul 2016 07:08:45 -0400 Original-Received: from s70.gtokyofl21.vectant.ne.jp ([202.215.75.70]:62326 helo=localhost) by hampton.hostforweb.net with esmtpsa (TLSv1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.87) (envelope-from ) id 1bQYJl-001ORk-GT; Fri, 22 Jul 2016 06:08:38 -0500 X-Face: #kKnN,xUnmKia.'[pp`; Omh}odZK)?7wQSl"4o04=EixTF+V[""w~iNbM9ZL+.b*_CxUmFk B#Fu[*?MZZH@IkN:!"\w%I_zt>[$nm7nQosZ<3eu; B:$Q_:p!',P.c0-_Cy[dz4oIpw0ESA^D*1Lw= L&i*6&( User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (i686-pc-cygwin) Cancel-Lock: sha1:IcuesPFVA1FlqrxtVJEIkpHo+vk= X-OutGoing-Spam-Status: No, score=-2.9 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - hampton.hostforweb.net X-AntiAbuse: Original Domain - debbugs.gnu.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - jpl.org X-Get-Message-Sender-Via: hampton.hostforweb.net: authenticated_id: yamaoka/from_h X-Authenticated-Sender: hampton.hostforweb.net: yamaoka@jpl.org X-Source: X-Source-Args: X-Source-Dir: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:121408 Archived-At: --=-=-= On Thu, 21 Jul 2016 17:46:18 +0900, Katsumi Yamaoka wrote: > I realized `+' works for some html mails but doesn't for others. I'm not quite sure this is the right approach, but I seem to have found the cause and the solution. `shr-image-fetched', that `shr-tag-img' calls, overrides the keymap text property on an image with the value that was there before inserting the image, that is, nil. Could you please test this patch? --=-=-= Content-Type: text/x-patch Content-Disposition: inline --- shr.el~ 2016-07-21 08:35:17.668496000 +0000 +++ shr.el 2016-07-22 11:05:56.349491100 +0000 @@ -937,7 +937,7 @@ (while properties (let ((type (pop properties)) (value (pop properties))) - (unless (memq type '(display image-size)) + (unless (memq type '(display image-size keymap)) (put-text-property start (point) type value)))))))))) (kill-buffer image-buffer))) --=-=-=--