* bug#26103: 25.1; Typo in rfc2231-encode-string docstring
@ 2017-03-15 1:24 Tim Landscheidt
2017-03-15 5:54 ` Katsumi Yamaoka
2017-05-13 18:39 ` bug#26103: [PATCH] fix typos in doc of mail RFCs Ruslan Bekenev
0 siblings, 2 replies; 4+ messages in thread
From: Tim Landscheidt @ 2017-03-15 1:24 UTC (permalink / raw)
To: 26103
In:
| (defun rfc2231-encode-string (param value)
| "Return and PARAM=VALUE string encoded according to RFC2231.
| Use `mml-insert-parameter' or `mml-insert-parameter-string' to insert
| the result of this function."
| […]
it should read: "Return a PARAM=VALUE string […]."
^ permalink raw reply [flat|nested] 4+ messages in thread
* bug#26103: 25.1; Typo in rfc2231-encode-string docstring
2017-03-15 1:24 bug#26103: 25.1; Typo in rfc2231-encode-string docstring Tim Landscheidt
@ 2017-03-15 5:54 ` Katsumi Yamaoka
2017-05-13 18:39 ` bug#26103: [PATCH] fix typos in doc of mail RFCs Ruslan Bekenev
1 sibling, 0 replies; 4+ messages in thread
From: Katsumi Yamaoka @ 2017-03-15 5:54 UTC (permalink / raw)
To: Tim Landscheidt; +Cc: 26103
On Wed, 15 Mar 2017 01:24:38 +0000, Tim Landscheidt wrote:
> In:
>| (defun rfc2231-encode-string (param value)
>| "Return and PARAM=VALUE string encoded according to RFC2231.
>| Use `mml-insert-parameter' or `mml-insert-parameter-string' to insert
>| the result of this function."
>| […]
> it should read: "Return a PARAM=VALUE string […]."
I think so, too. Furthermore, there are two similar ones:
(defun rfc2045-encode-string (param value)
"Return and PARAM=VALUE string encoded according to RFC2045."
(defun rfc2047-encode-parameter (param value)
"Return and PARAM=VALUE string encoded in the RFC2047-like style.
Lars wrote rfc2231- and rfc2045- 18 years ago, and rfc2047- is
what I made 13 years ago following in Lars' footsteps.
All those are typo errors, aren't they? ;-)
^ permalink raw reply [flat|nested] 4+ messages in thread
* bug#26103: [PATCH] fix typos in doc of mail RFCs
2017-03-15 1:24 bug#26103: 25.1; Typo in rfc2231-encode-string docstring Tim Landscheidt
2017-03-15 5:54 ` Katsumi Yamaoka
@ 2017-05-13 18:39 ` Ruslan Bekenev
2017-05-19 11:37 ` Eli Zaretskii
1 sibling, 1 reply; 4+ messages in thread
From: Ruslan Bekenev @ 2017-05-13 18:39 UTC (permalink / raw)
To: 26103
[-- Attachment #1: Type: text/plain, Size: 2091 bytes --]
Hi :)
yeah, it really looks like typos.
If it is ok I attached a patch that changes `and` to `a`.
---
lisp/mail/rfc2045.el | 2 +-
lisp/mail/rfc2047.el | 2 +-
lisp/mail/rfc2231.el | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/lisp/mail/rfc2045.el b/lisp/mail/rfc2045.el
index f6000500e1..11a6151887 100644
--- a/lisp/mail/rfc2045.el
+++ b/lisp/mail/rfc2045.el
@@ -28,7 +28,7 @@
(require 'ietf-drums)
(defun rfc2045-encode-string (param value)
- "Return and PARAM=VALUE string encoded according to RFC2045."
+ "Return a PARAM=VALUE string encoded according to RFC2045."
(if (or (string-match (concat "[" ietf-drums-no-ws-ctl-token "]") value)
(string-match (concat "[" ietf-drums-tspecials "]") value)
(string-match "[ \n\t]" value)
diff --git a/lisp/mail/rfc2047.el b/lisp/mail/rfc2047.el
index bcbdc17631..d276e2117f 100644
--- a/lisp/mail/rfc2047.el
+++ b/lisp/mail/rfc2047.el
@@ -851,7 +851,7 @@ Point moves to the end of the region."
(buffer-string)))
(defun rfc2047-encode-parameter (param value)
- "Return and PARAM=VALUE string encoded in the RFC2047-like style.
+ "Return a PARAM=VALUE string encoded in the RFC2047-like style.
This is a substitution for the `rfc2231-encode-string' function, that
is the standard but many mailers don't support it."
(let ((rfc2047-encoding-type 'mime)
diff --git a/lisp/mail/rfc2231.el b/lisp/mail/rfc2231.el
index ba972c7346..66f539f698 100644
--- a/lisp/mail/rfc2231.el
+++ b/lisp/mail/rfc2231.el
@@ -234,7 +234,7 @@ These look like:
(decode-coding-string (buffer-string) coding-system)))))
(defun rfc2231-encode-string (param value)
- "Return and PARAM=VALUE string encoded according to RFC2231.
+ "Return a PARAM=VALUE string encoded according to RFC2231.
Use `mml-insert-parameter' or `mml-insert-parameter-string' to insert
the result of this function."
(let ((control (ietf-drums-token-to-list ietf-drums-no-ws-ctl-token))
--
2.11.0 (Apple Git-81)
--
Ruslan Bekenev
[-- Attachment #2: Type: text/html, Size: 6022 bytes --]
^ permalink raw reply related [flat|nested] 4+ messages in thread
* bug#26103: [PATCH] fix typos in doc of mail RFCs
2017-05-13 18:39 ` bug#26103: [PATCH] fix typos in doc of mail RFCs Ruslan Bekenev
@ 2017-05-19 11:37 ` Eli Zaretskii
0 siblings, 0 replies; 4+ messages in thread
From: Eli Zaretskii @ 2017-05-19 11:37 UTC (permalink / raw)
To: Ruslan Bekenev; +Cc: 26103-done
> Date: Sat, 13 May 2017 21:39:18 +0300
> From: Ruslan Bekenev <furyinbox@gmail.com>
>
> Hi :)
> yeah, it really looks like typos.
> If it is ok I attached a patch that changes `and` to `a`.
Thanks, pushed.
In the future, please include a ChangeLog-style commit log message
describing your changes (I made them this time for you).
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-05-19 11:37 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-03-15 1:24 bug#26103: 25.1; Typo in rfc2231-encode-string docstring Tim Landscheidt
2017-03-15 5:54 ` Katsumi Yamaoka
2017-05-13 18:39 ` bug#26103: [PATCH] fix typos in doc of mail RFCs Ruslan Bekenev
2017-05-19 11:37 ` Eli Zaretskii
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.