From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Katsumi Yamaoka Newsgroups: gmane.emacs.bugs Subject: bug#29696: Reading summary keys from article changes window configuration Date: Thu, 14 Dec 2017 13:45:57 +0900 Organization: Emacsen advocacy group Message-ID: References: <87lgi6pe9g.fsf@gmail.com> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: blaine.gmane.org 1513226834 2417 195.159.176.226 (14 Dec 2017 04:47:14 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Thu, 14 Dec 2017 04:47:14 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.90 (i686-pc-cygwin) Cc: 29696-done@debbugs.gnu.org To: Basil L. Contovounesios Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Dec 14 05:47:10 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ePLQM-0000Ps-Ej for geb-bug-gnu-emacs@m.gmane.org; Thu, 14 Dec 2017 05:47:10 +0100 Original-Received: from localhost ([::1]:39121 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ePLQT-0000s4-N5 for geb-bug-gnu-emacs@m.gmane.org; Wed, 13 Dec 2017 23:47:17 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:51250) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ePLQJ-0000r4-DV for bug-gnu-emacs@gnu.org; Wed, 13 Dec 2017 23:47:08 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ePLQG-0000rG-AD for bug-gnu-emacs@gnu.org; Wed, 13 Dec 2017 23:47:07 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:52429) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ePLQG-0000r7-6g for bug-gnu-emacs@gnu.org; Wed, 13 Dec 2017 23:47:04 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ePLQE-0005J4-Rv; Wed, 13 Dec 2017 23:47:02 -0500 In-Reply-To: <87lgi6pe9g.fsf@gmail.com> Resent-From: Katsumi Yamaoka Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org, bugs@gnus.org Resent-Date: Thu, 14 Dec 2017 04:47:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 29696 X-GNU-PR-Package: emacs,gnus X-GNU-PR-Keywords: Mail-Followup-To: 29696@debbugs.gnu.org, yamaoka@jpl.org, contovob@tcd.ie Original-Received: via spool by 29696-done@debbugs.gnu.org id=D29696.151322676920328 (code D ref 29696); Thu, 14 Dec 2017 04:47:02 +0000 Original-Received: (at 29696-done) by debbugs.gnu.org; 14 Dec 2017 04:46:09 +0000 Original-Received: from localhost ([127.0.0.1]:32873 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ePLPN-0005Hn-1G for submit@debbugs.gnu.org; Wed, 13 Dec 2017 23:46:09 -0500 Original-Received: from mail-hampton.hostforweb.net ([205.234.186.191]:47887 helo=hampton.hostforweb.net) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ePLPJ-0005Gy-9Y for 29696-done@debbugs.gnu.org; Wed, 13 Dec 2017 23:46:07 -0500 Original-Received: from s70.gtokyofl21.vectant.ne.jp ([202.215.75.70]:60000 helo=localhost) by hampton.hostforweb.net with esmtpsa (TLSv1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.89) (envelope-from ) id 1ePLPA-003dN1-DY; Wed, 13 Dec 2017 22:45:57 -0600 X-Face: #kKnN,xUnmKia.'[pp`; Omh}odZK)?7wQSl"4o04=EixTF+V[""w~iNbM9ZL+.b*_CxUmFk B#Fu[*?MZZH@IkN:!"\w%I_zt>[$nm7nQosZ<3eu; B:$Q_:p!',P.c0-_Cy[dz4oIpw0ESA^D*1Lw= L&i*6&( Cancel-Lock: sha1:iSAfQn4bI8/tLmluCxHGux0cN+s= X-OutGoing-Spam-Status: No, score=-1.5 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - hampton.hostforweb.net X-AntiAbuse: Original Domain - debbugs.gnu.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - jpl.org X-Get-Message-Sender-Via: hampton.hostforweb.net: authenticated_id: yamaoka/from_h X-Authenticated-Sender: hampton.hostforweb.net: yamaoka@jpl.org X-Source: X-Source-Args: X-Source-Dir: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:141051 Archived-At: On Wed, 13 Dec 2017 20:24:43 +0000, Basil L. Contovounesios wrote: > Using Gnus with the user option pop-up-frames set to 'graphic-only, I > observe the following behaviour: > 1. Visit an article. > 2. Make article window the sole window in its containing frame. > 3. Type = (gnus-summary-expand-window). > Expected result: The article's summary replaces the article in the > frame's sole window. > Actual result: The expected result plus an additional frame displaying > the corresponding summary buffer. In other words, expanding the article > window causes an extraneous frame to be created. Confirmed and applied your patch in the emacs-26 branch. Thanks. > I believe this is caused by a call to pop-to-buffer within > save-window-excursion in the function gnus-article-read-summary-keys. > Is the call to pop-to-buffer really necessary for the purpose of key > lookup? Wouldn't changing the current buffer suffice, so as not to > affect the window configuration in the first place? I agree, only changing the buffer is sufficient in that case. I don't know why pop-to-buffer is used, but it seems to be there from the beginning (it is as is in Red Gnus 0.01 of 1996). I guess it was beyond imagination that pop-to-buffer may raise a new frame when there is no frame visiting the buffer, and why this wasn't discovered so far is that those who set pop-up-frames to nin-nil normally are not so many. > If so, please consider the attached patch which addresses this. The > docstring of save-window-excursion even warns of the possibility of > behaviour like the one I describe. > The information gathered by gnus-bug follows my signature. > Thanks,