From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Katsumi Yamaoka Newsgroups: gmane.emacs.bugs Subject: bug#23964: 25.1.50; `+' no longer works on images in Gnus article buffers Date: Mon, 25 Jul 2016 07:53:13 +0900 Organization: Emacsen advocacy group Message-ID: References: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1469400873 18033 80.91.229.3 (24 Jul 2016 22:54:33 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 24 Jul 2016 22:54:33 +0000 (UTC) Cc: 23964@debbugs.gnu.org To: larsi@gnus.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Jul 25 00:54:22 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1bRSHt-0007hL-Jt for geb-bug-gnu-emacs@m.gmane.org; Mon, 25 Jul 2016 00:54:21 +0200 Original-Received: from localhost ([::1]:57785 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bRSHp-00042r-CL for geb-bug-gnu-emacs@m.gmane.org; Sun, 24 Jul 2016 18:54:17 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:39144) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bRSHc-0003zd-Un for bug-gnu-emacs@gnu.org; Sun, 24 Jul 2016 18:54:05 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bRSHZ-00014i-SB for bug-gnu-emacs@gnu.org; Sun, 24 Jul 2016 18:54:04 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:52005) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bRSHZ-00014c-Oz for bug-gnu-emacs@gnu.org; Sun, 24 Jul 2016 18:54:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1bRSHZ-0000yb-Jc for bug-gnu-emacs@gnu.org; Sun, 24 Jul 2016 18:54:01 -0400 X-Loop: help-debbugs@gnu.org In-Reply-To: Resent-From: Katsumi Yamaoka Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 24 Jul 2016 22:54:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 23964 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 23964-submit@debbugs.gnu.org id=B23964.14694007913686 (code B ref 23964); Sun, 24 Jul 2016 22:54:01 +0000 Original-Received: (at 23964) by debbugs.gnu.org; 24 Jul 2016 22:53:11 +0000 Original-Received: from localhost ([127.0.0.1]:36109 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bRSGl-0000xO-0t for submit@debbugs.gnu.org; Sun, 24 Jul 2016 18:53:11 -0400 Original-Received: from mail-hampton.hostforweb.net ([205.234.186.191]:43191 helo=hampton.hostforweb.net) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bRSGj-0000xC-8j for 23964@debbugs.gnu.org; Sun, 24 Jul 2016 18:53:09 -0400 Original-Received: from s70.gtokyofl21.vectant.ne.jp ([202.215.75.70]:60467 helo=localhost) by hampton.hostforweb.net with esmtpsa (TLSv1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.87) (envelope-from ) id 1bRSGa-0026CE-6x; Sun, 24 Jul 2016 17:53:01 -0500 X-Face: #kKnN,xUnmKia.'[pp`; Omh}odZK)?7wQSl"4o04=EixTF+V[""w~iNbM9ZL+.b*_CxUmFk B#Fu[*?MZZH@IkN:!"\w%I_zt>[$nm7nQosZ<3eu; B:$Q_:p!',P.c0-_Cy[dz4oIpw0ESA^D*1Lw= L&i*6&( User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (i686-pc-cygwin) Cancel-Lock: sha1:BlKoYvh4KS7eWFbe3Iu9MimoBAM= X-OutGoing-Spam-Status: No, score=-2.9 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - hampton.hostforweb.net X-AntiAbuse: Original Domain - debbugs.gnu.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - jpl.org X-Get-Message-Sender-Via: hampton.hostforweb.net: authenticated_id: yamaoka/from_h X-Authenticated-Sender: hampton.hostforweb.net: yamaoka@jpl.org X-Source: X-Source-Args: X-Source-Dir: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:121502 Archived-At: On Sun, 24 Jul 2016 10:27:51 +0200, Lars Ingebrigtsen wrote: > It works for `+', but commands like `a' and `RET' no still doesn't work > on links. :-) I was confused about what key bindings should be there. :-) But this would probably be the right way: --8<---------------cut here---------------start------------->8--- --- mm-decode.el~ 2016-07-14 02:18:17.358607500 +0000 +++ mm-decode.el 2016-07-24 22:48:23.134292500 +0000 @@ -1853,8 +1853,6 @@ :help-echo (get-text-property start 'help-echo) :keymap (setq keymap (copy-keymap shr-image-map)) (get-text-property start 'shr-url)) - ;; Remove keymap that `shr-urlify' adds. - (put-text-property start end 'keymap nil) ;; Mask keys that launch `widget-button-click'. ;; Those bindings are provided by `widget-keymap' ;; that is a parent of `gnus-article-mode-map'. --8<---------------cut here---------------end--------------->8--- (Don't apply my last patch to shr.el.) How about it? This used to be making `local-map', not `keymap', void: The reason I did it was there's no code using `local-map', and so it was never effective. So, the patch above only restores the old behavior. :-)