From: Katsumi Yamaoka <yamaoka@jpl.org>
To: larsi@gnus.org
Cc: 23964@debbugs.gnu.org
Subject: bug#23964: 25.1.50; `+' no longer works on images in Gnus article buffers
Date: Mon, 25 Jul 2016 07:53:13 +0900 [thread overview]
Message-ID: <b4ma8h6d4x2.fsf@jpl.org> (raw)
In-Reply-To: <m3k2gqxc5y.fsf@gnus.org>
On Sun, 24 Jul 2016 10:27:51 +0200, Lars Ingebrigtsen wrote:
> It works for `+', but commands like `a' and `RET' no still doesn't work
> on <a><img></a> links. :-)
I was confused about what key bindings should be there. :-) But
this would probably be the right way:
--8<---------------cut here---------------start------------->8---
--- mm-decode.el~ 2016-07-14 02:18:17.358607500 +0000
+++ mm-decode.el 2016-07-24 22:48:23.134292500 +0000
@@ -1853,8 +1853,6 @@
:help-echo (get-text-property start 'help-echo)
:keymap (setq keymap (copy-keymap shr-image-map))
(get-text-property start 'shr-url))
- ;; Remove keymap that `shr-urlify' adds.
- (put-text-property start end 'keymap nil)
;; Mask keys that launch `widget-button-click'.
;; Those bindings are provided by `widget-keymap'
;; that is a parent of `gnus-article-mode-map'.
--8<---------------cut here---------------end--------------->8---
(Don't apply my last patch to shr.el.)
How about it?
This used to be making `local-map', not `keymap', void:
<http://article.gmane.org/gmane.emacs.diffs/136052>
The reason I did it was there's no code using `local-map', and
so it was never effective. So, the patch above only restores
the old behavior. :-)
next prev parent reply other threads:[~2016-07-24 22:53 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-13 6:52 bug#23964: 25.1.50; `+' no longer works on images in Gnus article buffers Lars Ingebrigtsen
2016-07-14 2:09 ` Katsumi Yamaoka
2016-07-20 12:47 ` Lars Ingebrigtsen
2016-07-21 8:46 ` Katsumi Yamaoka
2016-07-22 11:08 ` Katsumi Yamaoka
2016-07-22 11:11 ` Lars Ingebrigtsen
2016-07-24 8:27 ` Lars Ingebrigtsen
2016-07-24 22:53 ` Katsumi Yamaoka [this message]
2016-07-25 18:44 ` Lars Ingebrigtsen
2016-07-25 23:50 ` Katsumi Yamaoka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b4ma8h6d4x2.fsf@jpl.org \
--to=yamaoka@jpl.org \
--cc=23964@debbugs.gnu.org \
--cc=larsi@gnus.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.