From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Katsumi Yamaoka Newsgroups: gmane.emacs.bugs Subject: bug#29047: 26.0.90; shr hang (regression from 25.3) Date: Mon, 30 Oct 2017 15:21:17 +0900 Organization: Emacsen advocacy group Message-ID: References: <24901.1509235100@alto> <8360ayujx5.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Trace: blaine.gmane.org 1509344543 11665 195.159.176.226 (30 Oct 2017 06:22:23 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 30 Oct 2017 06:22:23 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.90 (i686-pc-cygwin) Cc: 29047@debbugs.gnu.org, Lars Ingebrigtsen , Mike Kupfer To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Oct 30 07:22:17 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e93Sd-0001l3-13 for geb-bug-gnu-emacs@m.gmane.org; Mon, 30 Oct 2017 07:22:11 +0100 Original-Received: from localhost ([::1]:38855 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e93Sk-00023G-BH for geb-bug-gnu-emacs@m.gmane.org; Mon, 30 Oct 2017 02:22:18 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:55340) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e93SX-00021S-J9 for bug-gnu-emacs@gnu.org; Mon, 30 Oct 2017 02:22:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1e93SU-00088q-C1 for bug-gnu-emacs@gnu.org; Mon, 30 Oct 2017 02:22:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:60765) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1e93SU-00088e-92 for bug-gnu-emacs@gnu.org; Mon, 30 Oct 2017 02:22:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1e93SU-0006rm-10 for bug-gnu-emacs@gnu.org; Mon, 30 Oct 2017 02:22:02 -0400 X-Loop: help-debbugs@gnu.org In-Reply-To: <24901.1509235100@alto> Resent-From: Katsumi Yamaoka Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 30 Oct 2017 06:22:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 29047 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 29047-submit@debbugs.gnu.org id=B29047.150934449026358 (code B ref 29047); Mon, 30 Oct 2017 06:22:01 +0000 Original-Received: (at 29047) by debbugs.gnu.org; 30 Oct 2017 06:21:30 +0000 Original-Received: from localhost ([127.0.0.1]:41213 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e93Ry-0006r2-Hx for submit@debbugs.gnu.org; Mon, 30 Oct 2017 02:21:30 -0400 Original-Received: from mail-hampton.hostforweb.net ([205.234.186.191]:58582 helo=hampton.hostforweb.net) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e93Rx-0006qo-60 for 29047@debbugs.gnu.org; Mon, 30 Oct 2017 02:21:29 -0400 Original-Received: from s70.gtokyofl21.vectant.ne.jp ([202.215.75.70]:60000 helo=localhost) by hampton.hostforweb.net with esmtpsa (TLSv1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.89) (envelope-from ) id 1e93Rn-000Yv9-LY; Mon, 30 Oct 2017 01:21:21 -0500 X-Face: #kKnN,xUnmKia.'[pp`; Omh}odZK)?7wQSl"4o04=EixTF+V[""w~iNbM9ZL+.b*_CxUmFk B#Fu[*?MZZH@IkN:!"\w%I_zt>[$nm7nQosZ<3eu; B:$Q_:p!',P.c0-_Cy[dz4oIpw0ESA^D*1Lw= L&i*6&( Cancel-Lock: sha1:OsA5AvB3tCVXqpu0LdNHBFO17o4= X-OutGoing-Spam-Status: No, score=-2.9 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - hampton.hostforweb.net X-AntiAbuse: Original Domain - debbugs.gnu.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - jpl.org X-Get-Message-Sender-Via: hampton.hostforweb.net: authenticated_id: yamaoka/from_h X-Authenticated-Sender: hampton.hostforweb.net: yamaoka@jpl.org X-Source: X-Source-Args: X-Source-Dir: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:139175 Archived-At: --=-=-= On Sun, 29 Oct 2017 16:07:34 +0200, Eli Zaretskii wrote: > Thanks, this bug was introduced by 9eb028f, and the problematic > property is 'display' with value '(space :align-to (NNN))'. It > causes shr-fill-line to infloop when this property is put on a > newline. Sorry, I did the 9eb028f change for fixing bug#24034: > I can prevent the loop with the patch below. I'm not sure this is the > right fix, though. Comments? That's ok, but the properties necessary to copy there are only `face' and `image-displayer'. How about this one? * lisp/net/shr.el (shr-fill-line): Copy only face and image-displayer properties to gaps (bug#29047). --=-=-= Content-Type: text/x-patch Content-Disposition: inline --- shr.el~ 2017-10-29 22:05:08.139411500 +0000 +++ shr.el 2017-10-30 06:19:48.874402200 +0000 @@ -700,12 +700,16 @@ ;; Success; continue. (when (= (preceding-char) ?\s) (delete-char -1)) - (let ((props (text-properties-at (point))) + (let ((props `(face ,(get-text-property (point) 'face) + ;; Don't break the image-displayer property + ;; as it will cause `gnus-article-show-images' + ;; to show the two or more same images. + image-displayer + ,(get-text-property (point) 'image-displayer))) (gap-start (point))) (insert "\n") (shr-indent) - (when props - (add-text-properties gap-start (point) props))) + (add-text-properties gap-start (point) props)) (setq start (point)) (shr-vertical-motion shr-internal-width) (when (looking-at " $") --=-=-=--