From: Katsumi Yamaoka <yamaoka@jpl.org>
To: ding@gnus.org
Cc: emacs-jabber-general@lists.sourceforge.net,
Ami Fischman <ami@fischman.org>,
emacs-devel@gnu.org
Subject: Re: gnus shouldn't be making general-purpose variables buffer-local
Date: Wed, 24 Dec 2008 11:32:12 +0900 [thread overview]
Message-ID: <b4m7i5q2thv.fsf@jpl.org> (raw)
In-Reply-To: 87bpv4ca5g.fsf@marauder.physik.uni-ulm.de
>>>>> Reiner Steib wrote:
> However, I wonder if the more general patch suggested by David Engster
> is better. Does anyone see a problem with it?
> Ami, does David's patch solve your problem?
> --- a/lisp/gnus-sum.el
> +++ b/lisp/gnus-sum.el
> @@ -3831,6 +3831,7 @@ This function is intended to be used in
> (and (consp elem) ; Has to be a cons.
> (consp (cdr elem)) ; The cdr has to be a list.
> (symbolp (car elem)) ; Has to be a symbol in there.
> + (boundp (car elem)) ; Has to be already bound
> (not (memq (car elem) vars))
> (ignore-errors ; So we set it.
> (push (car elem) vars)
>>>>> In <b4mfxkms7yl.fsf@jpl.org> Katsumi Yamaoka wrote:
> Cool! But I agree not to use it. :)
But I found no evil with that patch so far. Variables like gnus-*
globally bound need to get to be buffer-local but it's harmless.
Moreover, those parameters have been to be set as (VAR VAL), not
(VAR . VAL). OTOH, parameters used as just parameters, e.g.
`timestamp', should not need to be bound; those are set in the
`gnus-parameters' variable or the newsrc database. Only one anxiety
is the case that a user or some program binds such a variable, but
the fault will lie with the user or what should be complained will
be the program. So, I've installed David Engster's patch with a
comment: http://article.gmane.org/gmane.emacs.gnus.commits/6091
Regards,
prev parent reply other threads:[~2008-12-24 2:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <9aa0cfde0812112242o38d885a1h12d9e4ac490021@mail.gmail.com>
[not found] ` <863agokpas.fsf@lifelogs.com>
[not found] ` <b4mvdtjive8.fsf@jpl.org>
[not found] ` <87vdtj41ux.fsf@engster.org>
[not found] ` <b4miqpjp399.fsf@jpl.org>
[not found] ` <b4mr647ksqa.fsf@jpl.org>
2008-12-22 18:55 ` gnus shouldn't be making general-purpose variables buffer-local Reiner Steib
2008-12-22 20:53 ` Ami Fischman
2008-12-24 2:32 ` Katsumi Yamaoka [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b4m7i5q2thv.fsf@jpl.org \
--to=yamaoka@jpl.org \
--cc=ami@fischman.org \
--cc=ding@gnus.org \
--cc=emacs-devel@gnu.org \
--cc=emacs-jabber-general@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.