From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Katsumi Yamaoka Newsgroups: gmane.emacs.devel Subject: Re: master 11abc4a: Merge remote-tracking branch 'origin/scratch/lexical-gnus' into trunk Date: Tue, 02 Feb 2021 09:44:57 +0900 Organization: Emacsen advocacy group Message-ID: References: <20210131223952.429.10439@vcs0.savannah.gnu.org> <20210131223954.A429420DF3@vcs0.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="26069"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-cygwin) To: emacs-devel@gnu.org Cancel-Lock: sha1:CAYVM3jaXyAEQntMoe3m5xmHlnM= Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Feb 02 01:46:47 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1l6jqB-0006dZ-Qr for ged-emacs-devel@m.gmane-mx.org; Tue, 02 Feb 2021 01:46:47 +0100 Original-Received: from localhost ([::1]:58204 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l6jqA-0004RN-Td for ged-emacs-devel@m.gmane-mx.org; Mon, 01 Feb 2021 19:46:46 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:44998) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l6jpH-0003yV-S2 for emacs-devel@gnu.org; Mon, 01 Feb 2021 19:45:53 -0500 Original-Received: from beige.elm.relay.mailchannels.net ([23.83.212.16]:38602) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l6jpE-00038s-Vv for emacs-devel@gnu.org; Mon, 01 Feb 2021 19:45:51 -0500 X-Sender-Id: tih5qno0ow|x-authuser|yamaoka@cloud1.hostforweb.net Original-Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id 22D1F123A20; Tue, 2 Feb 2021 00:45:03 +0000 (UTC) Original-Received: from cloud1.hostforweb.net (100-96-18-11.trex.outbound.svc.cluster.local [100.96.18.11]) (Authenticated sender: tih5qno0ow) by relay.mailchannels.net (Postfix) with ESMTPA id 5FA45123890; Tue, 2 Feb 2021 00:45:02 +0000 (UTC) X-Sender-Id: tih5qno0ow|x-authuser|yamaoka@cloud1.hostforweb.net Original-Received: from cloud1.hostforweb.net (cloud1.hostforweb.net [154.16.119.57]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384) by 100.96.18.11 (trex/6.0.2); Tue, 02 Feb 2021 00:45:02 +0000 X-MC-Relay: Neutral X-MailChannels-SenderId: tih5qno0ow|x-authuser|yamaoka@cloud1.hostforweb.net X-MailChannels-Auth-Id: tih5qno0ow X-Inform-Bitter: 2c18e51343fabe62_1612226702775_2090334755 X-MC-Loop-Signature: 1612226702775:4109010238 X-MC-Ingress-Time: 1612226702775 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=jpl.org; s=default; h=Content-Type:MIME-Version:References:Subject:To:From:Message-ID: Date:Sender:Reply-To:Cc:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=cLko3ZOk2WQl0LsDYr0QKMesVVH2FcRQpX8k8m2LcNI=; b=IPj6ZD9U+xG8u+czSuUufnJzCK DomGY3XyIQSMyiyDL70Uxbc7Pa4Kq9Te6mRoLrXb+j3277q8YlK1Aw9sA/WsrCit9qCuSgXnrlrHV VPZYxheOlBvGo3vLAdxWKYx118DnB6cqvoqYB3Y8A0RO4z4Br+eEJvSydhuK04tOOrDUCbNr64jrY im+ElGbempMoId/jL9oLwUQg6q9t/5/OZwIcZ2fUkNBlT5aFUL2OaV300/Hdz65EB2PWSU0EmvCIR kr/Hy77UF20EIpPWWrPoSKC8yaeIhNQQ6ek7WRxivsbjySWNv4taoMJjuBeT1AJY7XnIoNf8i1YhO Fx2OZoPA==; Original-Received: from 113x33x36x204.ap113.ftth.ucom.ne.jp ([113.33.36.204]:42425 helo=localhost) by cloud1.hostforweb.net with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.93) (envelope-from ) id 1l6joS-005W3t-Vi; Mon, 01 Feb 2021 19:45:01 -0500 X-Face: #kKnN,xUnmKia.'[pp`; Omh}odZK)?7wQSl"4o04=EixTF+V[""w~iNbM9ZL+.b*_CxUmFk B#Fu[*?MZZH@IkN:!"\w%I_zt>[$nm7nQosZ<3eu; B:$Q_:p!',P.c0-_Cy[dz4oIpw0ESA^D*1Lw= L&i*6&( X-AuthUser: yamaoka@cloud1.hostforweb.net Received-SPF: pass client-ip=23.83.212.16; envelope-from=yamaoka@jpl.org; helo=beige.elm.relay.mailchannels.net X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:263702 Archived-At: On Sun, 31 Jan 2021 17:39:54 -0500, Stefan Monnier wrote: > branch: master > commit 11abc4aef42ceaea451c264e5a7292e765d4f31b > Merge: cb72b83 d2341eb > Author: Stefan Monnier > Commit: Stefan Monnier > Merge remote-tracking branch 'origin/scratch/lexical-gnus' into trunk It's not a bug but my custom face setting got to malfunction by this change, i.e., to turn lexical-binding on on the gnus files. My custom face setting is something like the following: (push '((string-match "REGEX" group) . custom-face) gnus-group-highlight) Where `group' is a group name; it aimed to highlight groups of which the name match "REGEX" by `custom-face' in the Group buffer. However, `group' is no longer a bound variable now. So, I'd like to add `group' to an env list in `gnus-group-update-eval-form' as the patch below. Is it ok? Thanks. --- gnus-group.el~ 2021-02-01 22:35:19.611070900 +0000 +++ gnus-group.el 2021-02-02 00:41:32.041329700 +0000 @@ -1639,5 +1639,6 @@ (cons 'score (or (gnus-info-score info) 0)) (cons 'ticked (gnus-range-length (cdr (assq 'tick marked)))) - (cons 'group-age (gnus-group-timestamp-delta group))))) + (cons 'group-age (gnus-group-timestamp-delta group)) + (cons 'group group)))) (while (and list (not (eval (caar list) env)))