From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Katsumi Yamaoka Newsgroups: gmane.emacs.bugs Subject: bug#33653: 27.0.50; Change Gnus obarrays-as-hash-tables into real hash tables Date: Wed, 27 Mar 2019 13:54:42 +0900 Organization: Emacsen advocacy group Message-ID: References: <8736raz3ec.fsf@ericabrahamsen.net> <87y392xoht.fsf@ericabrahamsen.net> <87imxzxa4s.fsf@ericabrahamsen.net> <87a7hn3h3w.fsf@ericabrahamsen.net> <87a7hhtinz.fsf@ericabrahamsen.net> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="122430"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (x86_64-pc-cygwin) Cc: 33653@debbugs.gnu.org To: Eric Abrahamsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Mar 27 05:55:14 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1h90ao-000VjR-2a for geb-bug-gnu-emacs@m.gmane.org; Wed, 27 Mar 2019 05:55:14 +0100 Original-Received: from localhost ([127.0.0.1]:41919 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h90an-0007if-3D for geb-bug-gnu-emacs@m.gmane.org; Wed, 27 Mar 2019 00:55:13 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:40762) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h90ad-0007ia-7q for bug-gnu-emacs@gnu.org; Wed, 27 Mar 2019 00:55:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1h90ac-0000bv-3X for bug-gnu-emacs@gnu.org; Wed, 27 Mar 2019 00:55:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:47240) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1h90ab-0000bp-TR for bug-gnu-emacs@gnu.org; Wed, 27 Mar 2019 00:55:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1h90ab-0003Yi-PK for bug-gnu-emacs@gnu.org; Wed, 27 Mar 2019 00:55:01 -0400 X-Loop: help-debbugs@gnu.org In-Reply-To: <8736raz3ec.fsf@ericabrahamsen.net> Resent-From: Katsumi Yamaoka Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 27 Mar 2019 04:55:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 33653 X-GNU-PR-Package: emacs Original-Received: via spool by 33653-submit@debbugs.gnu.org id=B33653.155366249213658 (code B ref 33653); Wed, 27 Mar 2019 04:55:01 +0000 Original-Received: (at 33653) by debbugs.gnu.org; 27 Mar 2019 04:54:52 +0000 Original-Received: from localhost ([127.0.0.1]:60784 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1h90aS-0003YE-E1 for submit@debbugs.gnu.org; Wed, 27 Mar 2019 00:54:52 -0400 Original-Received: from palegreen.birch.relay.mailchannels.net ([23.83.209.140]:27538) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1h90aQ-0003Y5-C4 for 33653@debbugs.gnu.org; Wed, 27 Mar 2019 00:54:51 -0400 X-Sender-Id: tih5qno0ow|x-authuser|yamaoka@hampton.hostforweb.net Original-Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id B47103E4DC5; Wed, 27 Mar 2019 04:54:48 +0000 (UTC) Original-Received: from hampton.hostforweb.net (unknown [100.96.39.118]) (Authenticated sender: tih5qno0ow) by relay.mailchannels.net (Postfix) with ESMTPA id 19E433E4F22; Wed, 27 Mar 2019 04:54:47 +0000 (UTC) X-Sender-Id: tih5qno0ow|x-authuser|yamaoka@hampton.hostforweb.net Original-Received: from hampton.hostforweb.net (hampton.hostforweb.net [172.245.115.217]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384) by 0.0.0.0:2500 (trex/5.17.2); Wed, 27 Mar 2019 04:54:48 +0000 X-MC-Relay: Neutral X-MailChannels-SenderId: tih5qno0ow|x-authuser|yamaoka@hampton.hostforweb.net X-MailChannels-Auth-Id: tih5qno0ow X-Troubled-Occur: 36820cb6762abd33_1553662488474_31324354 X-MC-Loop-Signature: 1553662488473:3923679862 X-MC-Ingress-Time: 1553662488473 Original-Received: from s70.gtokyofl21.vectant.ne.jp ([202.215.75.70]:60000 helo=localhost) by hampton.hostforweb.net with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.89_1) (envelope-from ) id 1h90aI-008JsZ-UI; Tue, 26 Mar 2019 23:54:44 -0500 X-Face: #kKnN,xUnmKia.'[pp`; Omh}odZK)?7wQSl"4o04=EixTF+V[""w~iNbM9ZL+.b*_CxUmFk B#Fu[*?MZZH@IkN:!"\w%I_zt>[$nm7nQosZ<3eu; B:$Q_:p!',P.c0-_Cy[dz4oIpw0ESA^D*1Lw= L&i*6&( Cancel-Lock: sha1:Kg/4jE7ZBJ5+WQzwyzH6qwXKrhA= X-OutGoing-Spam-Status: No, score=-0.2 X-AuthUser: yamaoka@hampton.hostforweb.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:156846 Archived-At: --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On Tue, 26 Mar 2019 14:44:32 -0700, Eric Abrahamsen wrote: > Thanks for this report. When you have a moment will you please try the > attached patch and see if it fixes the problem? Works great. Now I can enter and read the nnml:=E3=83=86=E3=82=B9=E3=83=88= group. Thank you. But there seem to be some more fix needed. The group level of nnml:=E3=83=86=E3=82=B9=E3=83=88 is 1 and there are some= unread articles in it, however the group is not listed in the Group buffer when I launch Gnus by `C-u 1 M-x gnus RET' (it also happened when I worked on non-ASCII group names years ago, but I don't recall how I fixed it, sorry). Typing L helps it. I tried changing `assoc' with `assoc-string' in nnrss.el, too. It works for non-ASCII group names so far, though only I glanced a few feeds. A diff is attached. Regards, --=-=-= Content-Type: text/x-patch Content-Disposition: attachment --- nnrss.el~ 2019-02-20 21:21:21.909516900 +0000 +++ nnrss.el 2019-03-27 04:49:26.756386000 +0000 @@ -340,10 +340,10 @@ (let (elem) ;; There may be two or more entries in `nnrss-group-alist' since ;; this function didn't delete them formerly. - (while (setq elem (assoc group nnrss-group-alist)) + (while (setq elem (assoc-string group nnrss-group-alist)) (setq nnrss-group-alist (delq elem nnrss-group-alist)))) (setq nnrss-server-data - (delq (assoc group nnrss-server-data) nnrss-server-data)) + (delq (assoc-string group nnrss-server-data) nnrss-server-data)) (nnrss-save-server-data server) (ignore-errors (let ((file-name-coding-system nnmail-pathname-coding-system)) @@ -367,7 +367,7 @@ (with-current-buffer nntp-server-buffer (erase-buffer) (dolist (group groups) - (let ((elem (assoc (gnus-group-decoded-name group) nnrss-server-data))) + (let ((elem (assoc-string (gnus-group-decoded-name group) nnrss-server-data))) (insert (format "%S %s 1 y\n" group (or (cadr elem) 0))))) 'active)) @@ -539,7 +539,7 @@ (if (hash-table-p nnrss-group-hashtb) (clrhash nnrss-group-hashtb) (setq nnrss-group-hashtb (make-hash-table :test 'equal))) - (let ((pair (assoc group nnrss-server-data))) + (let ((pair (assoc-string group nnrss-server-data))) (setq nnrss-group-max (or (cadr pair) 0)) (setq nnrss-group-min (+ nnrss-group-max 1))) (let ((file (nnrss-make-filename group server)) @@ -644,8 +644,8 @@ (concat group ".xml")) nnrss-directory)))) (setq xml (nnrss-fetch file t)) - (setq url (or (nth 2 (assoc group nnrss-server-data)) - (cadr (assoc group nnrss-group-alist)))) + (setq url (or (nth 2 (assoc-string group nnrss-server-data)) + (cadr (assoc-string group nnrss-group-alist)))) (unless url (setq url (cdr @@ -653,7 +653,7 @@ (nnrss-discover-feed (read-string (format "URL to search for %s: " group) "http://"))))) - (let ((pair (assoc group nnrss-server-data))) + (let ((pair (assoc-string group nnrss-server-data))) (if pair (setcdr (cdr pair) (list url)) (push (list group nnrss-group-max url) nnrss-server-data))) @@ -721,7 +721,7 @@ (setq extra nil)) (when changed (nnrss-save-group-data group server) - (let ((pair (assoc group nnrss-server-data))) + (let ((pair (assoc-string group nnrss-server-data))) (if pair (setcar (cdr pair) nnrss-group-max) (push (list group nnrss-group-max) nnrss-server-data))) @@ -792,7 +792,7 @@ (insert "RSSDIR='" (expand-file-name nnrss-directory) "'\n") (dolist (elem nnrss-server-data) (let ((url (or (nth 2 elem) - (cadr (assoc (car elem) nnrss-group-alist))))) + (cadr (assoc-string (car elem) nnrss-group-alist))))) (insert "$WGET -q -O \"$RSSDIR\"/'" (nnrss-translate-file-chars (concat (car elem) ".xml")) "' '" url "'\n")))) --=-=-=--