From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Daniel Sausner Newsgroups: gmane.emacs.bugs Subject: bug#52003: Unexpected advising behavior due to recursive implementation Date: Sun, 21 Nov 2021 09:32:43 +0000 Message-ID: References: <43094E20-7F74-4CE0-ABE7-4348ADFFFCE0@acm.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="3832"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 52003@debbugs.gnu.org To: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Nov 21 18:18:11 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1moqTi-0000pc-NR for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 21 Nov 2021 18:18:10 +0100 Original-Received: from localhost ([::1]:43898 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1moqTg-0006eC-Q4 for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 21 Nov 2021 12:18:08 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:56326) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1moqTa-0006av-2p for bug-gnu-emacs@gnu.org; Sun, 21 Nov 2021 12:18:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:34345) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1moqTZ-0000Nz-QQ for bug-gnu-emacs@gnu.org; Sun, 21 Nov 2021 12:18:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1moqTZ-0001CD-IL for bug-gnu-emacs@gnu.org; Sun, 21 Nov 2021 12:18:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Daniel Sausner Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 21 Nov 2021 17:18:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 52003 X-GNU-PR-Package: emacs Original-Received: via spool by 52003-submit@debbugs.gnu.org id=B52003.16375150734582 (code B ref 52003); Sun, 21 Nov 2021 17:18:01 +0000 Original-Received: (at 52003) by debbugs.gnu.org; 21 Nov 2021 17:17:53 +0000 Original-Received: from localhost ([127.0.0.1]:45891 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1moqTQ-0001Bq-Up for submit@debbugs.gnu.org; Sun, 21 Nov 2021 12:17:53 -0500 Original-Received: from mout01.posteo.de ([185.67.36.65]:58649) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mojDP-0001FJ-Qp for 52003@debbugs.gnu.org; Sun, 21 Nov 2021 04:32:53 -0500 Original-Received: from submission (posteo.de [89.146.220.130]) by mout01.posteo.de (Postfix) with ESMTPS id 04D14240029 for <52003@debbugs.gnu.org>; Sun, 21 Nov 2021 10:32:44 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.de; s=2017; t=1637487165; bh=sDJ6bHaIdt+hUmQgcAJCNAkq5pYfyUCQ9kILcUacDqs=; h=Subject:To:Cc:From:Date:From; b=od2J9438yPq6vet/mL/8JxHnhxAPd78YT/Aini5XRBhZBi7jyWWr70tnRw9JemBZF O9DtB29DzGbYLTj5KCz13sQNu2qh5VJN3otUKHtF92kfLBd85MTepO2JLMnbrpRJpr VVFATCd+Aa6fov7FC/iyx4NRA3x2YyubVzT2/IqYaNeYTfuCN3bHX1mMZ8UGM4I9d1 9FBNvKdEyieadC4taCnXLdSFTk2Gk6Q0zbxqU5xGaL2xhSND4b6AwyZZhMLj4eZ4JG Vuh/VaU0WCoeGRY+wPRgwVeQ8SHh4D2lX+F3paMoJIcuiVJze1Fbi+Haf0vYrNjeNe 1VHyE1C1r1mlA== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4HxlYm0rSMz6tny; Sun, 21 Nov 2021 10:32:43 +0100 (CET) In-Reply-To: <43094E20-7F74-4CE0-ABE7-4348ADFFFCE0@acm.org> Content-Language: de-DE X-Mailman-Approved-At: Sun, 21 Nov 2021 12:17:52 -0500 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:220567 Archived-At: > Do remember that you are always on your own when using advice; Emacs > cannot reasonably promise any compatibility on that level. I see. I somehow assumed that functions at that level would aim to be compliant to the max. > That said, it would be straightforward to straighten out the control flow by extracting the bulk of the code to a new (internal) function which is called with or without `condition-case`. It would be slightly slower since it entails an extra function call in the non-interactive case, and forward-sexp and its ilk are workhorses in many language modes. It may not matter much, of course. Well, I'd say that in that case the non-interactive performance outweighs this particular corner case of advising these core functions, which I came to understand is a hot iron. Therefore I'd say this bug report can be closed from my point of view. I guess I still have to use advising as I currently see no other feasible way out, but I can make it sensitive to `interactive` as well. Thanks for the helpful input!