From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Jim Porter Newsgroups: gmane.emacs.bugs Subject: bug#71666: 30.0.50; [PATCH] Fix zooming images with SHR Date: Fri, 28 Jun 2024 20:31:31 -0700 Message-ID: References: <3cdca8d0-9729-d8ae-5b3a-ed9473a2bef4@gmail.com> <86frt5ibou.fsf@gnu.org> <86o77sfeue.fsf@gnu.org> <14b4d89a-4947-c8e5-9216-adf201875c21@gmail.com> <88f17922-a833-ea6f-6d5e-bd01261b9068@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="8622"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 71666@debbugs.gnu.org To: Stefan Kangas , Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Jun 29 05:33:17 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sNOpx-00022Q-CS for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 29 Jun 2024 05:33:17 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sNOpj-0000Hq-WA; Fri, 28 Jun 2024 23:33:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sNOpi-0000HH-Lp for bug-gnu-emacs@gnu.org; Fri, 28 Jun 2024 23:33:02 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sNOpi-0004ZL-Dt for bug-gnu-emacs@gnu.org; Fri, 28 Jun 2024 23:33:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sNOph-0008Pd-JI for bug-gnu-emacs@gnu.org; Fri, 28 Jun 2024 23:33:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Jim Porter Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 29 Jun 2024 03:33:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 71666 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 71666-submit@debbugs.gnu.org id=B71666.171963195932304 (code B ref 71666); Sat, 29 Jun 2024 03:33:01 +0000 Original-Received: (at 71666) by debbugs.gnu.org; 29 Jun 2024 03:32:39 +0000 Original-Received: from localhost ([127.0.0.1]:36566 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sNOpK-0008Oy-O8 for submit@debbugs.gnu.org; Fri, 28 Jun 2024 23:32:39 -0400 Original-Received: from mail-pl1-f182.google.com ([209.85.214.182]:58573) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sNOpJ-0008Om-AB for 71666@debbugs.gnu.org; Fri, 28 Jun 2024 23:32:37 -0400 Original-Received: by mail-pl1-f182.google.com with SMTP id d9443c01a7336-1f9d9b57b90so9366405ad.0 for <71666@debbugs.gnu.org>; Fri, 28 Jun 2024 20:32:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1719631892; x=1720236692; darn=debbugs.gnu.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:mime-version:date:message-id:from:to:cc :subject:date:message-id:reply-to; bh=Kh2Nu9yI3uhSrRgp8Y429YreDWshoQGLkwGBcPRQ/V0=; b=ZOiscU8q6uYbI+j7+FnDLtx6nbK3FamhjhuIvGfjHra9ynrXYPXgwj6E5HBWBtjNpL yc2psiUBIOp2Dbcdb8XNBdmP/GtGIUBFCwoLnwjxRHSlAH8ssUZOon/6khqJROiv384R Z4rWnj6Om1u9Um0kTUzi6c0I3ZuBewIUoXgqwSKygnfd7hRs/qcmtHE1MYciN9QjwZlA cce0ovsy93OMPA1XQKRNOMKaCgyvgkIJcuCQlFpxor+3mK9cH01Mzw7aw++7qjTaqzRQ 9tWxDpP5EvLO2lbfk/2DuQ42+iT3s6hE/swvU3I3mAFI/omi73ln0y+nDTpfKQ+faUDW IYWA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719631892; x=1720236692; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Kh2Nu9yI3uhSrRgp8Y429YreDWshoQGLkwGBcPRQ/V0=; b=QRTqMkWVtm3xO/kwBWAZID0AquE5uF/jm1G88J0T0sPJ5GPC5UPyySGUsA9O0+QLVC NTfu8V1s0fWSlc9yGKXA09bjswwayba0mynTWxh1rX+wdv4a4qtcBflT1+iiaTJICToq o+SnMUOk6GrnYV36Cn3ncuxapvuGjJAf7ObplQyGPnqTtA8gw7WWlrzWMSHuWcEwkN45 oIt9hLDgClsP0hTvo21yW07+w3gfNLI/vB7fPtQrVAKeB5bX/vIgq91pUXFDeUROyKKb 9f43i446Q5A66jZjWvCnmGFFwyovaS9W4hb5C08ZA0MMG1rD79b+bWSPPbQxmAodT4iR N/Xw== X-Gm-Message-State: AOJu0YwCvGsBUdhNfVu3kJzIWHMnHBDWHv4MfiNPotkUwpN2HkjydPso mzhoFSHkfgfdrwakxMtZti9YCwjBI8jTsj5VfugeNj7CABfMuqHA X-Google-Smtp-Source: AGHT+IH/WM9N3gX4gD1UcXnAy83zBHoXF8v2HEEh/rgGpQGJNt0z0wXKBkbxhH4c3pRF7EAodeN1pw== X-Received: by 2002:a17:902:e810:b0:1fa:7f7e:2e0a with SMTP id d9443c01a7336-1fa7f7e3232mr121866725ad.65.1719631891837; Fri, 28 Jun 2024 20:31:31 -0700 (PDT) Original-Received: from [192.168.1.2] (syn-023-240-098-037.res.spectrum.com. [23.240.98.37]) by smtp.googlemail.com with ESMTPSA id d9443c01a7336-1fac11d8be9sm22782925ad.113.2024.06.28.20.31.31 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 28 Jun 2024 20:31:31 -0700 (PDT) Content-Language: en-US In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:288093 Archived-At: On 6/28/2024 8:08 PM, Stefan Kangas wrote: > Jim Porter writes: > >> Assuming there are no comments/concerns, I'll merge this to the master >> branch in the next few days. > > This is a regression, right? So should it not go to emacs-30? The initial bug report is fixed on emacs-30, but then based on Eli's message (and some further examination of the code on my part), I found some more closely-related issues. One of these issues (#3 - the "full" zoom level didn't zoom to the full window height) is a regression, but it regressed over a decade ago as far as I can tell, so I'd lean towards keeping the current behavior on emacs-30. That way, if I misunderstood what the regression was, we have plenty of time in the 31 release cycle to address that. (After searching, I now see that this particular regression was filed previously as bug#63344.) The other changes aren't so much regressions as they are long-standing bugs or limitations of the image-zooming code. Of course, if you and Eli prefer that I merge some or all of these patches to the release branch, I don't mind. But they seemed a bit risky to me.