From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#58839: [Patch] Re: bug#58839: 29.0.50; project-kill-buffer fails when Eglot is running Date: Sun, 30 Oct 2022 21:13:51 +0200 Message-ID: References: <87sfj8umwb.fsf@posteo.net> <87edur3lil.fsf@posteo.net> <87a65f3j40.fsf@posteo.net> <213f3549-de4e-25a7-5e27-d13893e557bc@yandex.ru> <87zgdfwkle.fsf@gmail.com> <8e31a89d-e35e-6dd0-a8e3-f0b9684c8bfa@yandex.ru> <87v8o3wgq1.fsf@gmail.com> <87ilk2x1si.fsf@gmail.com> <871qqq7l9p.fsf@posteo.net> <87eduqwekz.fsf@gmail.com> <87wn8invbx.fsf@posteo.net> <877d0iw8iq.fsf@gmail.com> <837d0hhlke.fsf@gnu.org> <46ff0065-5645-ef1e-2621-242fb6a73f98@yandex.ru> <838rkxfep9.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="13716"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Cc: philipk@posteo.net, 58839@debbugs.gnu.org, manuel.uberti@inventati.org, joaotavora@gmail.com To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Oct 30 20:15:31 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1opDmN-0003Pr-7L for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 30 Oct 2022 20:15:31 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1opDlx-0006vE-Pi; Sun, 30 Oct 2022 15:15:05 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1opDlv-0006ug-VO for bug-gnu-emacs@gnu.org; Sun, 30 Oct 2022 15:15:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1opDlu-00040T-TY for bug-gnu-emacs@gnu.org; Sun, 30 Oct 2022 15:15:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1opDlu-0005OB-Hx for bug-gnu-emacs@gnu.org; Sun, 30 Oct 2022 15:15:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 30 Oct 2022 19:15:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58839 X-GNU-PR-Package: emacs Original-Received: via spool by 58839-submit@debbugs.gnu.org id=B58839.166715724220621 (code B ref 58839); Sun, 30 Oct 2022 19:15:02 +0000 Original-Received: (at 58839) by debbugs.gnu.org; 30 Oct 2022 19:14:02 +0000 Original-Received: from localhost ([127.0.0.1]:39019 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1opDkv-0005MJ-S2 for submit@debbugs.gnu.org; Sun, 30 Oct 2022 15:14:02 -0400 Original-Received: from mail-wm1-f50.google.com ([209.85.128.50]:53194) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1opDkt-0005M5-Nd for 58839@debbugs.gnu.org; Sun, 30 Oct 2022 15:14:00 -0400 Original-Received: by mail-wm1-f50.google.com with SMTP id l32so6072143wms.2 for <58839@debbugs.gnu.org>; Sun, 30 Oct 2022 12:13:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :sender:from:to:cc:subject:date:message-id:reply-to; bh=bIIjv5oTgAJFmWnpB2kEzeKUDgoaKEB5Wb0ZOJslAw0=; b=ZjgsmgiR7hkuYLnKfXQhPF4vC15+FRXlt+RQyuTyethi84GbmPma1KK5gcsv7uHEH5 JPxEGBQ+U3pwcVOpI+78wzgMBAV9zkPbzqiTmG6tyRK0uMRUjasnLg80iEJWZqLnpkuB T6u4BDMcZx9y/PfJ5h82QSBh7ZOFhP/mShHMRPUPOrhy8Hvhb44rKGg+nCGoB7BTPZ2X q0Etrv1d69KzjdsQokyGiujldCiNdiUv7879N87jU4Y8DPUfrfLgR1dqR+LYvD+294Tp 4OXGssxjclPyXuEfe9rU5zA36uJFQjliIdzTwXsa3fe3nIFRl2oJU47yW9DcL88BGLlm yjuQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :sender:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=bIIjv5oTgAJFmWnpB2kEzeKUDgoaKEB5Wb0ZOJslAw0=; b=FYEbahzpeEPY2QohJRvKbABSRU2notmJsoqfvnZNh8LNIH2JQ+HR9PmGmCyLP+GSZO cYWuXB9nr/CDGnogJpgg3roa4Ds1ey6+pCGqcLYPhxkBD14NIP70lbqDpLuQKKKXjsBi 8Aq11F1+jBTCW9psBol2fXMQwrf8s75FPcd7oGUffjDlvYGxymu5jMgmtnouGsxSpfjD 54UjUfjQos1aWZTAlegEyVVA2UtvGBZCvC5q9L8l6Ky/L4KcNc4u7cHQwaCpxUTZvA09 fYBWizlzRh/H3/C8UE8g9vP4H0AoqoPU2hgIEDjtQLGY3evNRwEAbRjzXTIiLJtiOGBf tuQA== X-Gm-Message-State: ACrzQf1hBZ9BdFfy8HTVNRmghgB+wWPqxrglixqMA6ngVCFdd7uDucFI 7kqDHYJqKof1oJ6rV4wqp40= X-Google-Smtp-Source: AMsMyM4KU94J9dSV229BoV2KvmD9t1uF7vgt1GgloJss5l+WhXfWKkLBn4ABviU09Ik+oxmVVVxZuA== X-Received: by 2002:a1c:448b:0:b0:3cf:6fcd:e171 with SMTP id r133-20020a1c448b000000b003cf6fcde171mr1690689wma.163.1667157233625; Sun, 30 Oct 2022 12:13:53 -0700 (PDT) Original-Received: from [192.168.0.6] ([46.251.119.176]) by smtp.googlemail.com with ESMTPSA id k3-20020a05600c1c8300b003c6b7f5567csm19859877wms.0.2022.10.30.12.13.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 30 Oct 2022 12:13:53 -0700 (PDT) Content-Language: en-US In-Reply-To: <838rkxfep9.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: "bug-gnu-emacs" Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:246644 Archived-At: On 30.10.2022 18:39, Eli Zaretskii wrote: >> Date: Sun, 30 Oct 2022 17:58:18 +0200 >> Cc: philipk@posteo.net, 58839@debbugs.gnu.org, manuel.uberti@inventati.org >> From: Dmitry Gutov >> >> On 30.10.2022 08:28, Eli Zaretskii wrote: >>>> Those are relatively safe. Then have a buffer-local variable for >>>> packages to opt into -- not opt out of -- your scheme. >>> I believe I made a similar argument with Dmitry back when project.el >>> was added to Emacs. Dmitry didn't like my suggestion back then, and I >>> have doubts that he changed his mind. >> >> Do you have a link to that message? Details matter. > > Not anymore, sorry. It doesn't really matter, if you are now okay > with making buffers that don't visit files by default not belong to a > project, regardless of their default-directory. It would help remind you of the original explanation, instead of putting me on the defensive. And recall the supporting voices from the others in the same discussion. And maybe add the explanation to the docs, if it looks that non-obvious. To reiterate: we usually want to consider VC-Dir, Diff, Dired and Compilation buffers as part of the project. Even though they are not associated with a file. Because 'C-x p b' can be handy to switch to particular one, and 'C-x p k' can clean them up (when you're "closing" the project). People who think differently, can use project-ignore-buffer-conditions and/or use some special backend (probably defined by themselves) that overrides 'project-buffers' with a different logic. The issue Joao is having, however, is with particular "hidden" non-file-visiting buffers (in fundamental-mode). And here the argument could be made both ways.