bug#59122: 29.0.50; global-text-scale-adjust not working

bug#59122: 29.0.50; global-text-scale-adjust not working

[Rudolf Adamkovič via Bug reports for GNU Emacs, the Swiss army knife of text editors]

Reproduction:

  1. emacs -Q
  2. type M-x global-text-scale-adjust RET
  4. type -

Expected:

  font size decreases

Actual:

  nothing happens

Notes:

  text-scale-adjust, which does not share code with
  global-text-scale-adjust, works correctly.

Rudy


In GNU Emacs 29.0.50 (build 6, aarch64-apple-darwin21.6.0, NS
 appkit-2113.60 Version 12.6 (Build 21G115)) of 2022-11-08 built on
 Rudolfs-MacBook-Air.local
Repository revision: 80c3fadfd57ee797404c80b8e88371c53edecfe5
Repository branch: master
Windowing system distributor 'Apple', version 10.3.2113
System Description:  macOS 12.6

Configured using:
 'configure --with-native-compilation=aot --with-json'

Configured features:
ACL DBUS GLIB GNUTLS JSON LCMS2 LIBXML2 MODULES NATIVE_COMP NOTIFY
KQUEUE NS PDUMPER PNG RSVG SQLITE3 THREADS TOOLKIT_SCROLL_BARS WEBP XIM
ZLIB

Important settings:
  value of $LC_ALL: en_US.UTF-8
  locale-coding-system: utf-8-unix

Major mode: ELisp/l

Minor modes in effect:
  text-scale-mode: t
  paredit-mode: t
  flyspell-mode: t
  global-hl-todo-mode: t
  hl-todo-mode: t
  yas-global-mode: t
  yas-minor-mode: t
  shell-dirtrack-mode: t
  sly-symbol-completion-mode: t
  whitespace-mode: t
  display-fill-column-indicator-mode: t
  display-line-numbers-mode: t
  savehist-mode: t
  delete-selection-mode: t
  global-goto-address-mode: t
  goto-address-mode: t
  global-subword-mode: t
  subword-mode: t
  save-place-mode: t
  bug-reference-prog-mode: t
  global-auto-revert-mode: t
  tooltip-mode: t
  global-eldoc-mode: t
  eldoc-mode: t
  show-paren-mode: t
  electric-indent-mode: t
  mouse-wheel-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  context-menu-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  size-indication-mode: t
  column-number-mode: t
  line-number-mode: t
  transient-mark-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t

Load-path shadows:
/Users/salutis/.emacs.d/elpa/transient-20221028.1430/transient hides /Users/salutis/src/emacs/nextstep/Emacs.app/Contents/Resources/lisp/transient
/Users/salutis/.emacs.d/elpa/eglot/eglot hides /Users/salutis/src/emacs/nextstep/Emacs.app/Contents/Resources/lisp/progmodes/eglot
~/src/org-mode/lisp/ob-exp hides /Users/salutis/src/emacs/nextstep/Emacs.app/Contents/Resources/lisp/org/ob-exp
~/src/org-mode/lisp/ob-emacs-lisp hides /Users/salutis/src/emacs/nextstep/Emacs.app/Contents/Resources/lisp/org/ob-emacs-lisp
~/src/org-mode/lisp/oc hides /Users/salutis/src/emacs/nextstep/Emacs.app/Contents/Resources/lisp/org/oc
~/src/org-mode/lisp/ob-css hides /Users/salutis/src/emacs/nextstep/Emacs.app/Contents/Resources/lisp/org/ob-css
~/src/org-mode/lisp/ob-lob hides /Users/salutis/src/emacs/nextstep/Emacs.app/Contents/Resources/lisp/org/ob-lob
~/src/org-mode/lisp/ol-irc hides /Users/salutis/src/emacs/nextstep/Emacs.app/Contents/Resources/lisp/org/ol-irc
~/src/org-mode/lisp/ob-forth hides /Users/salutis/src/emacs/nextstep/Emacs.app/Contents/Resources/lisp/org/ob-forth
~/src/org-mode/lisp/org-macs hides /Users/salutis/src/emacs/nextstep/Emacs.app/Contents/Resources/lisp/org/org-macs
~/src/org-mode/lisp/ob hides /Users/salutis/src/emacs/nextstep/Emacs.app/Contents/Resources/lisp/org/ob
~/src/org-mode/lisp/org-version hides /Users/salutis/src/emacs/nextstep/Emacs.app/Contents/Resources/lisp/org/org-version
~/src/org-mode/lisp/ob-scheme hides /Users/salutis/src/emacs/nextstep/Emacs.app/Contents/Resources/lisp/org/ob-scheme
~/src/org-mode/lisp/ox hides /Users/salutis/src/emacs/nextstep/Emacs.app/Contents/Resources/lisp/org/ox
~/src/org-mode/lisp/ob-C hides /Users/salutis/src/emacs/nextstep/Emacs.app/Contents/Resources/lisp/org/ob-C
~/src/org-mode/lisp/org-capture hides /Users/salutis/src/emacs/nextstep/Emacs.app/Contents/Resources/lisp/org/org-capture
~/src/org-mode/lisp/ob-ref hides /Users/salutis/src/emacs/nextstep/Emacs.app/Contents/Resources/lisp/org/ob-ref
~/src/org-mode/lisp/ob-clojure hides /Users/salutis/src/emacs/nextstep/Emacs.app/Contents/Resources/lisp/org/ob-clojure
~/src/org-mode/lisp/org-mouse hides /Users/salutis/src/emacs/nextstep/Emacs.app/Contents/Resources/lisp/org/org-mouse
~/src/org-mode/lisp/org-ctags hides /Users/salutis/src/emacs/nextstep/Emacs.app/Contents/Resources/lisp/org/org-ctags
~/src/org-mode/lisp/org-entities hides /Users/salutis/src/emacs/nextstep/Emacs.app/Contents/Resources/lisp/org/org-entities
~/src/org-mode/lisp/org-archive hides /Users/salutis/src/emacs/nextstep/Emacs.app/Contents/Resources/lisp/org/org-archive
~/src/org-mode/lisp/ob-screen hides /Users/salutis/src/emacs/nextstep/Emacs.app/Contents/Resources/lisp/org/ob-screen
~/src/org-mode/lisp/ol-bibtex hides /Users/salutis/src/emacs/nextstep/Emacs.app/Contents/Resources/lisp/org/ol-bibtex
~/src/org-mode/lisp/ob-haskell hides /Users/salutis/src/emacs/nextstep/Emacs.app/Contents/Resources/lisp/org/ob-haskell
~/src/org-mode/lisp/org-loaddefs hides /Users/salutis/src/emacs/nextstep/Emacs.app/Contents/Resources/lisp/org/org-loaddefs
~/src/org-mode/lisp/org-table hides /Users/salutis/src/emacs/nextstep/Emacs.app/Contents/Resources/lisp/org/org-table
~/src/org-mode/lisp/ol-eww hides /Users/salutis/src/emacs/nextstep/Emacs.app/Contents/Resources/lisp/org/ol-eww
~/src/org-mode/lisp/ol-man hides /Users/salutis/src/emacs/nextstep/Emacs.app/Contents/Resources/lisp/org/ol-man
~/src/org-mode/lisp/ox-org hides /Users/salutis/src/emacs/nextstep/Emacs.app/Contents/Resources/lisp/org/ox-org
~/src/org-mode/lisp/org-num hides /Users/salutis/src/emacs/nextstep/Emacs.app/Contents/Resources/lisp/org/org-num
~/src/org-mode/lisp/org-plot hides /Users/salutis/src/emacs/nextstep/Emacs.app/Contents/Resources/lisp/org/org-plot
~/src/org-mode/lisp/ol-rmail hides /Users/salutis/src/emacs/nextstep/Emacs.app/Contents/Resources/lisp/org/ol-rmail
~/src/org-mode/lisp/ob-awk hides /Users/salutis/src/emacs/nextstep/Emacs.app/Contents/Resources/lisp/org/ob-awk
~/src/org-mode/lisp/ob-groovy hides /Users/salutis/src/emacs/nextstep/Emacs.app/Contents/Resources/lisp/org/ob-groovy
~/src/org-mode/lisp/ob-octave hides /Users/salutis/src/emacs/nextstep/Emacs.app/Contents/Resources/lisp/org/ob-octave
~/src/org-mode/lisp/org-faces hides /Users/salutis/src/emacs/nextstep/Emacs.app/Contents/Resources/lisp/org/org-faces
~/src/org-mode/lisp/oc-biblatex hides /Users/salutis/src/emacs/nextstep/Emacs.app/Contents/Resources/lisp/org/oc-biblatex
~/src/org-mode/lisp/org-colview hides /Users/salutis/src/emacs/nextstep/Emacs.app/Contents/Resources/lisp/org/org-colview
~/src/org-mode/lisp/ob-R hides /Users/salutis/src/emacs/nextstep/Emacs.app/Contents/Resources/lisp/org/ob-R
~/src/org-mode/lisp/org-refile hides /Users/salutis/src/emacs/nextstep/Emacs.app/Contents/Resources/lisp/org/org-refile
~/src/org-mode/lisp/org-timer hides /Users/salutis/src/emacs/nextstep/Emacs.app/Contents/Resources/lisp/org/org-timer
~/src/org-mode/lisp/org-mobile hides /Users/salutis/src/emacs/nextstep/Emacs.app/Contents/Resources/lisp/org/org-mobile
~/src/org-mode/lisp/ob-fortran hides /Users/salutis/src/emacs/nextstep/Emacs.app/Contents/Resources/lisp/org/ob-fortran
~/src/org-mode/lisp/ob-shell hides /Users/salutis/src/emacs/nextstep/Emacs.app/Contents/Resources/lisp/org/ob-shell
~/src/org-mode/lisp/ob-perl hides /Users/salutis/src/emacs/nextstep/Emacs.app/Contents/Resources/lisp/org/ob-perl
~/src/org-mode/lisp/ob-sqlite hides /Users/salutis/src/emacs/nextstep/Emacs.app/Contents/Resources/lisp/org/ob-sqlite
~/src/org-mode/lisp/oc-basic hides /Users/salutis/src/emacs/nextstep/Emacs.app/Contents/Resources/lisp/org/oc-basic
~/src/org-mode/lisp/ob-sed hides /Users/salutis/src/emacs/nextstep/Emacs.app/Contents/Resources/lisp/org/ob-sed
~/src/org-mode/lisp/org-list hides /Users/salutis/src/emacs/nextstep/Emacs.app/Contents/Resources/lisp/org/org-list
~/src/org-mode/lisp/ob-ruby hides /Users/salutis/src/emacs/nextstep/Emacs.app/Contents/Resources/lisp/org/ob-ruby
~/src/org-mode/lisp/ob-eval hides /Users/salutis/src/emacs/nextstep/Emacs.app/Contents/Resources/lisp/org/ob-eval
~/src/org-mode/lisp/org-habit hides /Users/salutis/src/emacs/nextstep/Emacs.app/Contents/Resources/lisp/org/org-habit
~/src/org-mode/lisp/org-clock hides /Users/salutis/src/emacs/nextstep/Emacs.app/Contents/Resources/lisp/org/org-clock
~/src/org-mode/lisp/org-goto hides /Users/salutis/src/emacs/nextstep/Emacs.app/Contents/Resources/lisp/org/org-goto
~/src/org-mode/lisp/ox-html hides /Users/salutis/src/emacs/nextstep/Emacs.app/Contents/Resources/lisp/org/ox-html
~/src/org-mode/lisp/org-src hides /Users/salutis/src/emacs/nextstep/Emacs.app/Contents/Resources/lisp/org/org-src
~/src/org-mode/lisp/ob-lisp hides /Users/salutis/src/emacs/nextstep/Emacs.app/Contents/Resources/lisp/org/ob-lisp
~/src/org-mode/lisp/ol-eshell hides /Users/salutis/src/emacs/nextstep/Emacs.app/Contents/Resources/lisp/org/ol-eshell
~/src/org-mode/lisp/ob-ditaa hides /Users/salutis/src/emacs/nextstep/Emacs.app/Contents/Resources/lisp/org/ob-ditaa
~/src/org-mode/lisp/org-pcomplete hides /Users/salutis/src/emacs/nextstep/Emacs.app/Contents/Resources/lisp/org/org-pcomplete
~/src/org-mode/lisp/org-lint hides /Users/salutis/src/emacs/nextstep/Emacs.app/Contents/Resources/lisp/org/org-lint
~/src/org-mode/lisp/ox-latex hides /Users/salutis/src/emacs/nextstep/Emacs.app/Contents/Resources/lisp/org/ox-latex
~/src/org-mode/lisp/ob-sass hides /Users/salutis/src/emacs/nextstep/Emacs.app/Contents/Resources/lisp/org/ob-sass
~/src/org-mode/lisp/ob-tangle hides /Users/salutis/src/emacs/nextstep/Emacs.app/Contents/Resources/lisp/org/ob-tangle
~/src/org-mode/lisp/ob-calc hides /Users/salutis/src/emacs/nextstep/Emacs.app/Contents/Resources/lisp/org/ob-calc
~/src/org-mode/lisp/ob-java hides /Users/salutis/src/emacs/nextstep/Emacs.app/Contents/Resources/lisp/org/ob-java
~/src/org-mode/lisp/ox-icalendar hides /Users/salutis/src/emacs/nextstep/Emacs.app/Contents/Resources/lisp/org/ox-icalendar
~/src/org-mode/lisp/ol-mhe hides /Users/salutis/src/emacs/nextstep/Emacs.app/Contents/Resources/lisp/org/ol-mhe
~/src/org-mode/lisp/org-attach-git hides /Users/salutis/src/emacs/nextstep/Emacs.app/Contents/Resources/lisp/org/org-attach-git
~/src/org-mode/lisp/ox-md hides /Users/salutis/src/emacs/nextstep/Emacs.app/Contents/Resources/lisp/org/ox-md
~/src/org-mode/lisp/ox-beamer hides /Users/salutis/src/emacs/nextstep/Emacs.app/Contents/Resources/lisp/org/ox-beamer
~/src/org-mode/lisp/org-element hides /Users/salutis/src/emacs/nextstep/Emacs.app/Contents/Resources/lisp/org/org-element
~/src/org-mode/lisp/oc-natbib hides /Users/salutis/src/emacs/nextstep/Emacs.app/Contents/Resources/lisp/org/oc-natbib
~/src/org-mode/lisp/org-protocol hides /Users/salutis/src/emacs/nextstep/Emacs.app/Contents/Resources/lisp/org/org-protocol
~/src/org-mode/lisp/ob-gnuplot hides /Users/salutis/src/emacs/nextstep/Emacs.app/Contents/Resources/lisp/org/ob-gnuplot
~/src/org-mode/lisp/org-tempo hides /Users/salutis/src/emacs/nextstep/Emacs.app/Contents/Resources/lisp/org/org-tempo
~/src/org-mode/lisp/ob-latex hides /Users/salutis/src/emacs/nextstep/Emacs.app/Contents/Resources/lisp/org/ob-latex
~/src/org-mode/lisp/ol-w3m hides /Users/salutis/src/emacs/nextstep/Emacs.app/Contents/Resources/lisp/org/ol-w3m
~/src/org-mode/lisp/org-id hides /Users/salutis/src/emacs/nextstep/Emacs.app/Contents/Resources/lisp/org/org-id
~/src/org-mode/lisp/ox-man hides /Users/salutis/src/emacs/nextstep/Emacs.app/Contents/Resources/lisp/org/ox-man
~/src/org-mode/lisp/ol-doi hides /Users/salutis/src/emacs/nextstep/Emacs.app/Contents/Resources/lisp/org/ol-doi
~/src/org-mode/lisp/org-feed hides /Users/salutis/src/emacs/nextstep/Emacs.app/Contents/Resources/lisp/org/org-feed
~/src/org-mode/lisp/ob-julia hides /Users/salutis/src/emacs/nextstep/Emacs.app/Contents/Resources/lisp/org/ob-julia
~/src/org-mode/lisp/ob-lua hides /Users/salutis/src/emacs/nextstep/Emacs.app/Contents/Resources/lisp/org/ob-lua
~/src/org-mode/lisp/ob-table hides /Users/salutis/src/emacs/nextstep/Emacs.app/Contents/Resources/lisp/org/ob-table
~/src/org-mode/lisp/ob-ocaml hides /Users/salutis/src/emacs/nextstep/Emacs.app/Contents/Resources/lisp/org/ob-ocaml
~/src/org-mode/lisp/oc-csl hides /Users/salutis/src/emacs/nextstep/Emacs.app/Contents/Resources/lisp/org/oc-csl
~/src/org-mode/lisp/ol-gnus hides /Users/salutis/src/emacs/nextstep/Emacs.app/Contents/Resources/lisp/org/ol-gnus
~/src/org-mode/lisp/org-indent hides /Users/salutis/src/emacs/nextstep/Emacs.app/Contents/Resources/lisp/org/org-indent
~/src/org-mode/lisp/ob-lilypond hides /Users/salutis/src/emacs/nextstep/Emacs.app/Contents/Resources/lisp/org/ob-lilypond
~/src/org-mode/lisp/ob-matlab hides /Users/salutis/src/emacs/nextstep/Emacs.app/Contents/Resources/lisp/org/ob-matlab
~/src/org-mode/lisp/org-datetree hides /Users/salutis/src/emacs/nextstep/Emacs.app/Contents/Resources/lisp/org/org-datetree
~/src/org-mode/lisp/ol-docview hides /Users/salutis/src/emacs/nextstep/Emacs.app/Contents/Resources/lisp/org/ol-docview
~/src/org-mode/lisp/ob-python hides /Users/salutis/src/emacs/nextstep/Emacs.app/Contents/Resources/lisp/org/ob-python
~/src/org-mode/lisp/ob-makefile hides /Users/salutis/src/emacs/nextstep/Emacs.app/Contents/Resources/lisp/org/ob-makefile
~/src/org-mode/lisp/org-duration hides /Users/salutis/src/emacs/nextstep/Emacs.app/Contents/Resources/lisp/org/org-duration
~/src/org-mode/lisp/org-agenda hides /Users/salutis/src/emacs/nextstep/Emacs.app/Contents/Resources/lisp/org/org-agenda
~/src/org-mode/lisp/ob-dot hides /Users/salutis/src/emacs/nextstep/Emacs.app/Contents/Resources/lisp/org/ob-dot
~/src/org-mode/lisp/ob-js hides /Users/salutis/src/emacs/nextstep/Emacs.app/Contents/Resources/lisp/org/ob-js
~/src/org-mode/lisp/ox-publish hides /Users/salutis/src/emacs/nextstep/Emacs.app/Contents/Resources/lisp/org/ox-publish
~/src/org-mode/lisp/org-inlinetask hides /Users/salutis/src/emacs/nextstep/Emacs.app/Contents/Resources/lisp/org/org-inlinetask
~/src/org-mode/lisp/ob-org hides /Users/salutis/src/emacs/nextstep/Emacs.app/Contents/Resources/lisp/org/ob-org
~/src/org-mode/lisp/org-keys hides /Users/salutis/src/emacs/nextstep/Emacs.app/Contents/Resources/lisp/org/org-keys
~/src/org-mode/lisp/ob-core hides /Users/salutis/src/emacs/nextstep/Emacs.app/Contents/Resources/lisp/org/ob-core
~/src/org-mode/lisp/org-compat hides /Users/salutis/src/emacs/nextstep/Emacs.app/Contents/Resources/lisp/org/org-compat
~/src/org-mode/lisp/ol hides /Users/salutis/src/emacs/nextstep/Emacs.app/Contents/Resources/lisp/org/ol
~/src/org-mode/lisp/ox-odt hides /Users/salutis/src/emacs/nextstep/Emacs.app/Contents/Resources/lisp/org/ox-odt
~/src/org-mode/lisp/ol-info hides /Users/salutis/src/emacs/nextstep/Emacs.app/Contents/Resources/lisp/org/ol-info
~/src/org-mode/lisp/ob-plantuml hides /Users/salutis/src/emacs/nextstep/Emacs.app/Contents/Resources/lisp/org/ob-plantuml
~/src/org-mode/lisp/ob-eshell hides /Users/salutis/src/emacs/nextstep/Emacs.app/Contents/Resources/lisp/org/ob-eshell
~/src/org-mode/lisp/ox-ascii hides /Users/salutis/src/emacs/nextstep/Emacs.app/Contents/Resources/lisp/org/ox-ascii
~/src/org-mode/lisp/ox-koma-letter hides /Users/salutis/src/emacs/nextstep/Emacs.app/Contents/Resources/lisp/org/ox-koma-letter
~/src/org-mode/lisp/ob-maxima hides /Users/salutis/src/emacs/nextstep/Emacs.app/Contents/Resources/lisp/org/ob-maxima
~/src/org-mode/lisp/org hides /Users/salutis/src/emacs/nextstep/Emacs.app/Contents/Resources/lisp/org/org
~/src/org-mode/lisp/ol-bbdb hides /Users/salutis/src/emacs/nextstep/Emacs.app/Contents/Resources/lisp/org/ol-bbdb
~/src/org-mode/lisp/org-macro hides /Users/salutis/src/emacs/nextstep/Emacs.app/Contents/Resources/lisp/org/org-macro
~/src/org-mode/lisp/ob-sql hides /Users/salutis/src/emacs/nextstep/Emacs.app/Contents/Resources/lisp/org/ob-sql
~/src/org-mode/lisp/org-attach hides /Users/salutis/src/emacs/nextstep/Emacs.app/Contents/Resources/lisp/org/org-attach
~/src/org-mode/lisp/ob-processing hides /Users/salutis/src/emacs/nextstep/Emacs.app/Contents/Resources/lisp/org/ob-processing
~/src/org-mode/lisp/ox-texinfo hides /Users/salutis/src/emacs/nextstep/Emacs.app/Contents/Resources/lisp/org/ox-texinfo
~/src/org-mode/lisp/org-crypt hides /Users/salutis/src/emacs/nextstep/Emacs.app/Contents/Resources/lisp/org/org-crypt
~/src/org-mode/lisp/org-footnote hides /Users/salutis/src/emacs/nextstep/Emacs.app/Contents/Resources/lisp/org/org-footnote
~/src/org-mode/lisp/ob-comint hides /Users/salutis/src/emacs/nextstep/Emacs.app/Contents/Resources/lisp/org/ob-comint

Features:
(shadow sort notmuch notmuch-tree notmuch-jump notmuch-hello
notmuch-show notmuch-print notmuch-crypto notmuch-mua notmuch-message
notmuch-draft notmuch-maildir-fcc notmuch-address notmuch-company
notmuch-parser notmuch-wash coolj icalendar diary-lib diary-loaddefs
notmuch-tag crm notmuch-lib notmuch-version notmuch-compat hl-line
mail-extr pulse color face-remap emacsbug paredit edmacro kmacro
flyspell ispell orderless hl-todo compat compat-macs
modus-operandi-theme modus-themes pdf-loader yasnippet finder-inf
package-vc vc lisp-mnt ox-texinfo ox-md oc-csl citeproc
citeproc-itemgetters citeproc-biblatex citeproc-bibtex parsebib
citeproc-cite citeproc-subbibs citeproc-sort citeproc-name
citeproc-formatters citeproc-number rst citeproc-proc citeproc-disamb
citeproc-itemdata citeproc-generic-elements citeproc-macro
citeproc-choose citeproc-date citeproc-context citeproc-prange
citeproc-style citeproc-locale citeproc-term f f-shortdoc shortdoc
citeproc-rt citeproc-lib citeproc-s s let-alist queue dash ox-odt
rng-loc rng-uri rng-parse rng-match rng-dt rng-util rng-pttrn nxml-parse
nxml-ns nxml-enc xmltok nxml-util ox-latex ox-icalendar org-habit
org-agenda ox-html table ox-ascii ox-publish ox org-clock ob-lisp
ob-makefile ob-latex ob-scheme geiser ob-dot ob-R ob-C cc-mode cc-fonts
cc-guess cc-menus cc-cmds cc-styles cc-align cc-engine cc-vars cc-defs
ob-shell shell ob-java ob-sqlite ob-sql ob-org flymake-proc flymake sly
gud compile sly-completion pcase sly-buttons sly-messages sly-common
apropos etags fileloop xref project arc-mode archive-mode hyperspec
whitespace display-fill-column-indicator display-line-numbers fortune
savehist comp comp-cstr warnings delsel goto-addr cap-words superword
subword saveplace ls-lisp cus-edit pp cus-load bug-reference autorevert
vc-git diff-mode easy-mmode vc-dispatcher oc-basic cl-extra org-element
org-persist org-id org-refile avl-tree generator ol-eww eww xdg
url-queue thingatpt mm-url ol-rmail ol-mhe ol-irc ol-info ol-gnus
nnselect gnus-art mm-uu mml2015 mm-view mml-smime smime gnutls dig
gnus-sum shr pixel-fill kinsoku url-file svg dom gnus-group gnus-undo
gnus-start gnus-dbus dbus xml gnus-cloud nnimap nnmail mail-source utf7
nnoo parse-time gnus-spec gnus-int gnus-range message sendmail
yank-media puny rfc822 mml mml-sec epa derived epg rfc6068 epg-config
mm-decode mm-bodies mm-encode mail-parse rfc2231 rfc2047 rfc2045
ietf-drums mailabbrev gmm-utils mailheader gnus-win gnus nnheader
gnus-util text-property-search mail-utils range mm-util mail-prsvr
wid-edit ol-docview doc-view filenotify jka-compr image-mode exif dired
dired-loaddefs ol-bibtex bibtex iso8601 ol-bbdb ol-w3m ol-doi
org-link-doi org ob ob-tangle ob-ref ob-lob ob-table ob-exp org-macro
org-footnote org-src ob-comint org-pcomplete pcomplete comint ansi-osc
ansi-color org-list org-faces org-entities time-date noutline outline
icons ob-emacs-lisp ob-core ob-eval org-cycle org-table ol rx org-fold
org-fold-core org-keys oc org-loaddefs find-func cal-menu calendar
cal-loaddefs org-version org-compat org-macs format-spec
flyspell-correct-autoloads eglot-autoloads markdown-mode-autoloads
org-drill-autoloads bbdb-autoloads vterm-autoloads swift-mode-autoloads
htmlize-autoloads emms-autoloads yaml-mode-autoloads citar-autoloads
citeproc-autoloads f-autoloads bnf-mode-autoloads kotlin-mode-autoloads
magit-autoloads persist-autoloads embark-autoloads ebnf-mode-autoloads
queue-autoloads cape-autoloads rainbow-mode-autoloads
flymake-grammarly-autoloads grammarly-autoloads websocket-autoloads
git-commit-autoloads modus-themes-autoloads paredit-autoloads
telega-autoloads rainbow-identifiers-autoloads password-store-autoloads
with-editor-autoloads s-autoloads orderless-autoloads
string-inflection-autoloads sly-autoloads diff-hl-autoloads
parsebib-autoloads magit-section-autoloads dash-autoloads
visual-fill-column-autoloads yasnippet-autoloads hl-todo-autoloads
graphviz-dot-mode-autoloads org-pomodoro-autoloads pdf-tools-autoloads
tablist-autoloads mentor-autoloads url-scgi-autoloads async-autoloads
xml-rpc-autoloads alert-autoloads log4e-autoloads gntp-autoloads
elfeed-tube-mpv-autoloads mpv-autoloads sql-indent-autoloads
sqlup-mode-autoloads auctex-autoloads tex-site elfeed-tube-autoloads
aio-autoloads elfeed-autoloads request-autoloads geiser-guile-autoloads
geiser-impl help-fns radix-tree help-mode geiser-custom geiser-base ring
geiser-autoloads transient-autoloads compat-autoloads info ess-autoloads
package browse-url url url-proxy url-privacy url-expand url-methods
url-history url-cookie generate-lisp-file url-domsuf url-util mailcap
url-handlers url-parse auth-source cl-seq eieio eieio-core cl-macs
password-cache json subr-x map byte-opt gv bytecomp byte-compile
url-vars cl-loaddefs cl-lib rmc iso-transl tooltip cconv eldoc paren
electric uniquify ediff-hook vc-hooks lisp-float-type elisp-mode mwheel
term/ns-win ns-win ucs-normalize mule-util term/common-win tool-bar dnd
fontset image regexp-opt fringe tabulated-list replace newcomment
text-mode lisp-mode prog-mode register page tab-bar menu-bar rfn-eshadow
isearch easymenu timer select scroll-bar mouse jit-lock font-lock syntax
font-core term/tty-colors frame minibuffer nadvice seq simple cl-generic
indonesian philippine cham georgian utf-8-lang misc-lang vietnamese
tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek
romanian slovak czech european ethiopic indian cyrillic chinese
composite emoji-zwj charscript charprop case-table epa-hook
jka-cmpr-hook help abbrev obarray oclosure cl-preloaded button loaddefs
theme-loaddefs faces cus-face macroexp files window text-properties
overlay sha1 md5 base64 format env code-pages mule custom widget keymap
hashtable-print-readable backquote threads dbusbind kqueue cocoa ns
lcms2 multi-tty make-network-process native-compile emacs)

Memory information:
((conses 16 892803 84886)
 (symbols 48 44223 26)
 (strings 32 156059 7869)
 (string-bytes 1 5552735)
 (vectors 16 73982)
 (vector-slots 8 1958557 93521)
 (floats 8 558 119)
 (intervals 56 5794 448)
 (buffers 984 18))

-- 
"'Contrariwise,' continued Tweedledee, 'if it was so, it might be; and
if it were so, it would be; but as it isn't, it ain't.  That's logic.'"
-- Lewis Carroll, Through the Looking Glass, 1871/1872

Rudolf Adamkovič <salutis@me.com> [he/him]
Studenohorská 25
84103 Bratislava
Slovakia

bug#59122: 29.0.50; global-text-scale-adjust not working

[Eli Zaretskii]

> Date: Tue, 08 Nov 2022 13:28:46 +0100
> From:  Rudolf Adamkovič via "Bug reports for GNU Emacs,
>  the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
> 
>   1. emacs -Q
>   2. type M-x global-text-scale-adjust RET
>   4. type -
> 
> Expected:
> 
>   font size decreases
> 
> Actual:
> 
>   nothing happens

I cannot reproduce this, it works as expected for me.  But I'm not on
macOS.

bug#59122: 29.0.50; global-text-scale-adjust not working

[Gregory Heytings]

>
> Reproduction:
>
> 1. emacs -Q
> 2. type M-x global-text-scale-adjust RET
> 4. type -
>

Is there a 3. missing in your recipe?

>
> Expected:
>
> font size decreases
>
> Actual:
>
> nothing happens
>

Really nothing?  Do you see something in the echo area?  What happens if 
you press + instead?  Also, can you try again after M-x 
toggle-debug-on-error RET?

bug#59122: 29.0.50; global-text-scale-adjust not working

[Rudolf Adamkovič via Bug reports for GNU Emacs, the Swiss army knife of text editors]

Gregory Heytings <gregory@heytings.org> writes:

> Is there a 3. missing in your recipe?

No.

> Really nothing?

Really.

> Do you see something in the echo area?

"Use +, =, -, 0, ESC for further adjustment"

> What happens if you press + instead?

`+' works.

(Also, for some reason, `global-text-scale-adjust' increases the font
size once when executed, without me typing `+'.  Should that happen?)

> Also, can you try again after M-x toggle-debug-on-error RET?

No errors.

Rudy
-- 
"Be especially critical of any statement following the word
'obviously.'"
-- Anna Pell Wheeler, 1883-1966

Rudolf Adamkovič <salutis@me.com> [he/him]
Studenohorská 25
84103 Bratislava
Slovakia

bug#59122: 29.0.50; global-text-scale-adjust not working

[Eli Zaretskii]

> Cc: 59122@debbugs.gnu.org
> Date: Tue, 08 Nov 2022 22:48:53 +0100
> From:  Rudolf =?UTF-8?Q?Adamkovi=C4=8D?= via "Bug reports for GNU Emacs,
>  the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
> 
> > What happens if you press + instead?
> 
> `+' works.

What does "C-h l" show after you press '-' and after you press '+'?

bug#59122: 29.0.50; global-text-scale-adjust not working

[Gregory Heytings]

>> What happens if you press + instead?
>
> `+' works.
>

Okay, and after you press '+', does '-' work?  Also, as Eli asked, can you 
type C-h l after pressing '+' and '-' a few times?  You should see 
something like this:

+    ;; global-text-scale-adjust
+    ;; global-text-scale-adjust
-    ;; global-text-scale-adjust
-    ;; global-text-scale-adjust

>
> (Also, for some reason, `global-text-scale-adjust' increases the font 
> size once when executed, without me typing `+'.  Should that happen?)
>

Yes.

bug#59122: 29.0.50; global-text-scale-adjust not working

[Stefan Kangas]

Gregory Heytings <gregory@heytings.org> writes:

> >> What happens if you press + instead?
> >
> > `+' works.
> >
>
> Okay, and after you press '+', does '-' work?  Also, as Eli asked, can you
> type C-h l after pressing '+' and '-' a few times?  You should see
> something like this:

I can reproduce this bug on macOS 12.6.1 (OP is on 12.6).

After pressing '+', '-' still doesn't decrease the font size.  I can
only increase it using '+'.

Output of C-h l:

 M-x      ;; execute-extended-command
 g      ;; self-insert-command
 l      ;; self-insert-command
 o      ;; self-insert-command
 b      ;; self-insert-command
 a      ;; self-insert-command
 l      ;; self-insert-command
 <tab>      ;; minibuffer-complete
 t      ;; self-insert-command
 e      ;; self-insert-command
 x      ;; self-insert-command
 t      ;; self-insert-command
 <tab>      ;; minibuffer-complete
 <return> ;; minibuffer-complete-and-exit
 -      ;; global-text-scale-adjust
 -      ;; global-text-scale-adjust
 +      ;; global-text-scale-adjust
 -      ;; global-text-scale-adjust
 +      ;; global-text-scale-adjust
 -      ;; global-text-scale-adjust
 -      ;; global-text-scale-adjust
 -      ;; global-text-scale-adjust
 C-h l      ;; view-lossage

bug#59122: 29.0.50; global-text-scale-adjust not working

[Gregory Heytings]

>
> I can reproduce this bug on macOS 12.6.1 (OP is on 12.6).
>
> After pressing '+', '-' still doesn't decrease the font size.  I can 
> only increase it using '+'.
>
> Output of C-h l:
>

Thanks.  What do you get when you eval

(face-attribute 'default :height)

?  And what happens when you eval

(set-face-attribute 'default nil :height (- (face-attribute 'default :height) 5))

?  If nothing happens, can you try with 6, 7, 8... instead of 5, until 
something happens?

bug#59122: 29.0.50; global-text-scale-adjust not working

[Stefan Kangas]

Gregory Heytings <gregory@heytings.org> writes:

> What do you get when you eval
>
> (face-attribute 'default :height)

(face-attribute 'default :height) => 150

> ?  And what happens when you eval
>
> (set-face-attribute 'default nil :height (- (face-attribute 'default :height) 5))

Nothing happens.

> ?  If nothing happens, can you try with 6, 7, 8... instead of 5, until
> something happens?

With

(set-face-attribute 'default nil :height (- (face-attribute 'default
:height) 6))

the font size is decreased.  If I evaluate it more than once, the font
size decreases more with each additional invocation.

bug#59122: 29.0.50; global-text-scale-adjust not working

[Robert Pluim]

>>>>> On Wed, 9 Nov 2022 15:30:15 +0100, Stefan Kangas <stefankangas@gmail.com> said:
    Stefan> With

    Stefan> (set-face-attribute 'default nil :height (- (face-attribute 'default
    Stefan> :height) 6))

    Stefan> the font size is decreased.  If I evaluate it more than once, the font
    Stefan> size decreases more with each additional invocation.

But it actually decreases by 10, right? (and similarly for increases)

Robert
-- 

bug#59122: 29.0.50; global-text-scale-adjust not working

[Stefan Kangas]

Robert Pluim <rpluim@gmail.com> writes:

> >>>>> On Wed, 9 Nov 2022 15:30:15 +0100, Stefan Kangas <stefankangas@gmail.com> said:
>     Stefan> With
>
>     Stefan> (set-face-attribute 'default nil :height (- (face-attribute 'default
>     Stefan> :height) 6))
>
>     Stefan> the font size is decreased.  If I evaluate it more than once, the font
>     Stefan> size decreases more with each additional invocation.
>
> But it actually decreases by 10, right? (and similarly for increases)

It would seem so:

(cons (face-attribute 'default :height)
      (progn
    (set-face-attribute 'default nil
                :height (- (face-attribute 'default :height) 6))
    (face-attribute 'default :height)))
=> (120 . 110)

With 'global-text-scale-adjust', in a fresh emacs -Q, I see that:

(cons (face-attribute 'default :height)
      (progn
    (global-text-scale-adjust 1)
    (face-attribute 'default :height)))
=> (120 . 130)

bug#59122: 29.0.50; global-text-scale-adjust not working

[Robert Pluim]

>>>>> On Wed, 9 Nov 2022 15:43:05 +0100, Stefan Kangas <stefankangas@gmail.com> said:
    >> But it actually decreases by 10, right? (and similarly for increases)

    Stefan> It would seem so:

    Stefan> (cons (face-attribute 'default :height)
    Stefan>       (progn
    Stefan>     (set-face-attribute 'default nil
    Stefan>                 :height (- (face-attribute 'default :height) 6))
    Stefan>     (face-attribute 'default :height)))
    Stefan> => (120 . 110)

    Stefan> With 'global-text-scale-adjust', in a fresh emacs -Q, I see that:

    Stefan> (cons (face-attribute 'default :height)
    Stefan>       (progn
    Stefan>     (global-text-scale-adjust 1)
    Stefan>     (face-attribute 'default :height)))
    Stefan> => (120 . 130)

And on my X build it goes

181 -> 173 -> 166

and

181 -> 188 -> 196

(using 5 or 6 as the adjustment makes no difference to the sequence on
X for me)

Robert
-- 

bug#59122: 29.0.50; global-text-scale-adjust not working

[Gregory Heytings]

>> With
>>
>> (set-face-attribute 'default nil :height (- (face-attribute 'default :height) 6))
>>
>> the font size is decreased.  If I evaluate it more than once, the font 
>> size decreases more with each additional invocation.
>
> But it actually decreases by 10, right? (and similarly for increases)
>

That might be what it does on macOS, but it's not what it does on 
GNU/Linux.  With my configuration the successive values are 109, 105, 102, 
98, 94, 90, 87, 83, ... or with 6 instead of 5: 109, 102, 98, 90, 83, ...

So it seems that after all simply remplacing 5 by 6 isn't optimal.

Is this bug specific to the most recent version of macOS?

bug#59122: 29.0.50; global-text-scale-adjust not working

[Stefan Kangas]

Gregory Heytings <gregory@heytings.org> writes:

> Is this bug specific to the most recent version of macOS?

I unfortunately only have access to the most recent version (12.6.1)
for testing.

(BTW, macOS 12.6 is dog-slow on older hardware, and AFAICT has no
useful new features - not one.  But Apple is no longer releasing
security fixes for older versions, so you are effectively forced to
upgrade if you care about security.)

bug#59122: 29.0.50; global-text-scale-adjust not working

[Robert Pluim]

>>>>> On Wed, 9 Nov 2022 15:59:30 +0100, Stefan Kangas <stefankangas@gmail.com> said:

    Stefan> Gregory Heytings <gregory@heytings.org> writes:
    >> Is this bug specific to the most recent version of macOS?

    Stefan> I unfortunately only have access to the most recent version (12.6.1)
    Stefan> for testing.

12.6 behaves the same

    Stefan> (BTW, macOS 12.6 is dog-slow on older hardware, and AFAICT has no
    Stefan> useful new features - not one.  But Apple is no longer releasing
    Stefan> security fixes for older versions, so you are effectively forced to
    Stefan> upgrade if you care about security.)

Every time I upgrade I sit through the "this is what we changed"
slideshow, and none of it ever matters to me.

Robert
-- 

bug#59122: 29.0.50; global-text-scale-adjust not working

[Gregory Heytings]

>
> (set-face-attribute 'default nil :height (- (face-attribute 'default :height) 6))
>
> the font size is decreased.  If I evaluate it more than once, the font 
> size decreases more with each additional invocation.
>

Thanks.  The safe fix should be to change 5 to 6 here.  Eli, do you agree, 
or is there something else to investigate?

bug#59122: 29.0.50; global-text-scale-adjust not working

[Eli Zaretskii]

> Cc: Rudolf Adamkovič <salutis@me.com>, 59122@debbugs.gnu.org
> Date: Wed, 09 Nov 2022 14:36:47 +0000
> From: Gregory Heytings <gregory@heytings.org>
> 
> > (set-face-attribute 'default nil :height (- (face-attribute 'default :height) 6))
> >
> > the font size is decreased.  If I evaluate it more than once, the font 
> > size decreases more with each additional invocation.
> >
> 
> Thanks.  The safe fix should be to change 5 to 6 here.  Eli, do you agree, 
> or is there something else to investigate?

Can you tell more?  I don't think I understand why decreasing the face
height by 5 doesn't work, but decreasing it by 6 does.  If you do
understand, please tell.

bug#59122: 29.0.50; global-text-scale-adjust not working

[Eli Zaretskii]

> Cc: 59122@debbugs.gnu.org, salutis@me.com, stefankangas@gmail.com
> Date: Wed, 09 Nov 2022 16:51:26 +0200
> From: Eli Zaretskii <eliz@gnu.org>
> 
> > Thanks.  The safe fix should be to change 5 to 6 here.  Eli, do you agree, 
> > or is there something else to investigate?
> 
> Can you tell more?  I don't think I understand why decreasing the face
> height by 5 doesn't work, but decreasing it by 6 does.  If you do
> understand, please tell.

Also, how come text-scale-adjust does work on the same platform?

bug#59122: 29.0.50; global-text-scale-adjust not working

[Robert Pluim]

>>>>> On Wed, 09 Nov 2022 16:59:04 +0200, Eli Zaretskii <eliz@gnu.org> said:

    >> Cc: 59122@debbugs.gnu.org, salutis@me.com, stefankangas@gmail.com
    >> Date: Wed, 09 Nov 2022 16:51:26 +0200
    >> From: Eli Zaretskii <eliz@gnu.org>
    >> 
    >> > Thanks.  The safe fix should be to change 5 to 6 here.  Eli, do you agree, 
    >> > or is there something else to investigate?
    >> 
    >> Can you tell more?  I don't think I understand why decreasing the face
    >> height by 5 doesn't work, but decreasing it by 6 does.  If you do
    >> understand, please tell.

    Eli> Also, how come text-scale-adjust does work on the same platform?

As far as I can tell from its somewhat convoluted code and docstrings,
that scales up and down by 20% every time.

Robert
-- 

bug#59122: 29.0.50; global-text-scale-adjust not working

[Gregory Heytings]

>
> Also, how come text-scale-adjust does work on the same platform?
>

Because text-scale-adjust is cruder: it uses a factor instead of an 
increment.  The effect of global-text-scale-adjust is much smoother.

bug#59122: 29.0.50; global-text-scale-adjust not working

[Eli Zaretskii]

> Date: Wed, 09 Nov 2022 16:02:44 +0000
> From: Gregory Heytings <gregory@heytings.org>
> cc: 59122@debbugs.gnu.org, salutis@me.com, stefankangas@gmail.com
> 
> > Also, how come text-scale-adjust does work on the same platform?
> >
> 
> Because text-scale-adjust is cruder: it uses a factor instead of an 
> increment.  The effect of global-text-scale-adjust is much smoother.

This subtle difference should probably be in the doc string, as users
will normally assume that global-text-scale-adjust is just a
globalized version of text-scale-adjust.

bug#59122: 29.0.50; global-text-scale-adjust not working

[Stefan Kangas]

Eli Zaretskii <eliz@gnu.org> writes:

> > Because text-scale-adjust is cruder: it uses a factor instead of an
> > increment.  The effect of global-text-scale-adjust is much smoother.
>
> This subtle difference should probably be in the doc string, as users
> will normally assume that global-text-scale-adjust is just a
> globalized version of text-scale-adjust.

Is 'global-text-scale-adjust' new in Emacs 29?  Maybe it would be
better if they both work the same, presumably the same way as
'text-scale-adjust' does now (or the other way, if that's better).
Then we could introduce a new defcustom to make them both behave the
other way.  Would that make sense?

bug#59122: 29.0.50; global-text-scale-adjust not working

[Eli Zaretskii]

> From: Stefan Kangas <stefankangas@gmail.com>
> Date: Thu, 10 Nov 2022 01:44:18 +0100
> Cc: Gregory Heytings <gregory@heytings.org>, 59122@debbugs.gnu.org, salutis@me.com
> 
> Eli Zaretskii <eliz@gnu.org> writes:
> 
> > > Because text-scale-adjust is cruder: it uses a factor instead of an
> > > increment.  The effect of global-text-scale-adjust is much smoother.
> >
> > This subtle difference should probably be in the doc string, as users
> > will normally assume that global-text-scale-adjust is just a
> > globalized version of text-scale-adjust.
> 
> Is 'global-text-scale-adjust' new in Emacs 29?  Maybe it would be
> better if they both work the same, presumably the same way as
> 'text-scale-adjust' does now (or the other way, if that's better).
> Then we could introduce a new defcustom to make them both behave the
> other way.  Would that make sense?

Gregory says the different operation of the global mode is a feature,
so making them behave the same would either mean losing the feature or
an incompatible change to text-scale-adjust.

bug#59122: 29.0.50; global-text-scale-adjust not working

[Gregory Heytings]

>
> Can you tell more?  I don't think I understand why decreasing the face 
> height by 5 doesn't work, but decreasing it by 6 does.  If you do 
> understand, please tell.
>

It's because of rounding.  Face heights on macOS are multiples of 10 (100 
for 10.0 pt, 110 for 11.0 pt, ...).  Setting the face height to 105 
actually sets it to 110.

So I think what we should do here is to check, after set-face-attribute, 
whether the face height has actually changed, and if not try again with a 
bigger increment.

bug#59122: 29.0.50; global-text-scale-adjust not working

[Eli Zaretskii]

> Date: Wed, 09 Nov 2022 16:01:04 +0000
> From: Gregory Heytings <gregory@heytings.org>
> cc: 59122@debbugs.gnu.org, salutis@me.com, stefankangas@gmail.com
> 
> It's because of rounding.  Face heights on macOS are multiples of 10 (100 
> for 10.0 pt, 110 for 11.0 pt, ...).  Setting the face height to 105 
> actually sets it to 110.
> 
> So I think what we should do here is to check, after set-face-attribute, 
> whether the face height has actually changed, and if not try again with a 
> bigger increment.

Yes, SGTM.

bug#59122: 29.0.50; global-text-scale-adjust not working

[Gregory Heytings]

[-- Attachment #1: Type: text/plain, Size: 88 bytes --]


Stefan, Rudolf, can you try the attached patch and see if it fixes the 
issue?

Thanks.

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: Fix-global-face-scaling-bug-due-to-rounding.patch --]
[-- Type: text/x-diff; name=Fix-global-face-scaling-bug-due-to-rounding.patch, Size: 2347 bytes --]

From 288401146162e67efa8f4a23c790fadeb1b92d6a Mon Sep 17 00:00:00 2001
From: Gregory Heytings <gregory@heytings.org>
Date: Wed, 9 Nov 2022 16:16:22 +0000
Subject: [PATCH] Fix global face scaling bug due to rounding.

* lisp/face-remap.el (global-text-scale-adjust): Try again if the face
height did not actually change.
(global-text-scale-adjust--increment-factor): New internal variable.
Fixes bug#59122.
---
 lisp/face-remap.el | 14 +++++++++++---
 1 file changed, 11 insertions(+), 3 deletions(-)

diff --git a/lisp/face-remap.el b/lisp/face-remap.el
index 432385587b..2d83d804c6 100644
--- a/lisp/face-remap.el
+++ b/lisp/face-remap.el
@@ -461,6 +461,8 @@ global-text-scale-adjust-limits
 
 (defvar global-text-scale-adjust--default-height nil)
 
+(defvar global-text-scale-adjust--increment-factor 5)
+
 ;;;###autoload (define-key ctl-x-map [(control meta ?+)] 'global-text-scale-adjust)
 ;;;###autoload (define-key ctl-x-map [(control meta ?=)] 'global-text-scale-adjust)
 ;;;###autoload (define-key ctl-x-map [(control meta ?-)] 'global-text-scale-adjust)
@@ -499,16 +501,22 @@ global-text-scale-adjust
            (cur (face-attribute 'default :height))
            (inc
             (pcase key
-              (?- (* (- increment) 5))
+              (?- (* (- increment)
+                     global-text-scale-adjust--increment-factor))
               (?0 (- global-text-scale-adjust--default-height cur))
-              (_ (* increment 5))))
+              (_ (* increment
+                    global-text-scale-adjust--increment-factor))))
            (new (+ cur inc)))
       (when (< (car global-text-scale-adjust-limits)
                new
                (cdr global-text-scale-adjust-limits))
         (let ((frame-inhibit-implied-resize
                (not global-text-scale-adjust-resizes-frames)))
-          (set-face-attribute 'default nil :height new)))
+          (set-face-attribute 'default nil :height new)
+          (when (= cur (face-attribute 'default :height))
+            (setq global-text-scale-adjust--increment-factor
+                  (1+ global-text-scale-adjust--increment-factor))
+            (global-text-scale-adjust increment))))
       (when (characterp key)
         (set-transient-map
          (let ((map (make-sparse-keymap)))
-- 
2.35.1

bug#59122: 29.0.50; global-text-scale-adjust not working

[Rudolf Adamkovič via Bug reports for GNU Emacs, the Swiss army knife of text editors]

Gregory Heytings <gregory@heytings.org> writes:

> Stefan, Rudolf, can you try the attached patch and see if it fixes the
> issue?

I apologize for replying late.

So, I tried the patch (applied on top of 04ade0508d) and it does not fix
the problem.  After `M-x global-text-scale-adjust RET', the command
immediately makes the font larger (without me ever pressing `+'), and
`-' still does nothing.

Rudy
-- 
"Genius is 1% inspiration and 99% perspiration."
-- Thomas Alva Edison, 1932

Rudolf Adamkovič <salutis@me.com> [he/him]
Studenohorská 25
84103 Bratislava
Slovakia

bug#59122: 29.0.50; global-text-scale-adjust not working

[Gregory Heytings]

[-- Attachment #1: Type: text/plain, Size: 338 bytes --]


>
> So, I tried the patch (applied on top of 04ade0508d) and it does not fix 
> the problem.  After `M-x global-text-scale-adjust RET', the command 
> immediately makes the font larger (without me ever pressing `+'), and 
> `-' still does nothing.
>

Thanks.  Can you try the attached patch instead, and post what you see in 
*Messages*?

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: debug.patch --]
[-- Type: text/x-diff; name=debug.patch, Size: 2083 bytes --]

diff --git a/lisp/face-remap.el b/lisp/face-remap.el
index 432385587b..28ab3d2fb1 100644
--- a/lisp/face-remap.el
+++ b/lisp/face-remap.el
@@ -461,6 +461,8 @@ global-text-scale-adjust-limits
 
 (defvar global-text-scale-adjust--default-height nil)
 
+(defvar global-text-scale-adjust--increment-factor 5)
+
 ;;;###autoload (define-key ctl-x-map [(control meta ?+)] 'global-text-scale-adjust)
 ;;;###autoload (define-key ctl-x-map [(control meta ?=)] 'global-text-scale-adjust)
 ;;;###autoload (define-key ctl-x-map [(control meta ?-)] 'global-text-scale-adjust)
@@ -499,16 +501,26 @@ global-text-scale-adjust
            (cur (face-attribute 'default :height))
            (inc
             (pcase key
-              (?- (* (- increment) 5))
+              (?- (* (- increment)
+                     global-text-scale-adjust--increment-factor))
               (?0 (- global-text-scale-adjust--default-height cur))
-              (_ (* increment 5))))
+              (_ (* increment
+                    global-text-scale-adjust--increment-factor))))
            (new (+ cur inc)))
       (when (< (car global-text-scale-adjust-limits)
                new
                (cdr global-text-scale-adjust-limits))
         (let ((frame-inhibit-implied-resize
                (not global-text-scale-adjust-resizes-frames)))
-          (set-face-attribute 'default nil :height new)))
+          (message "global-text-scale-adjust %d -> %d" cur new)
+          (set-face-attribute 'default nil :height new)
+          (when (= cur (face-attribute 'default :height))
+            (setq global-text-scale-adjust--increment-factor
+                  (1+ global-text-scale-adjust--increment-factor))
+            (message "global-text-scale-adjust %d, trying again with %d"
+                     (face-attribute 'default :height)
+                     global-text-scale-adjust--increment-factor)
+            (global-text-scale-adjust increment))))
       (when (characterp key)
         (set-transient-map
          (let ((map (make-sparse-keymap)))

bug#59122: 29.0.50; global-text-scale-adjust not working

[Stefan Kangas]

Gregory Heytings <gregory@heytings.org> writes:

> Thanks.  Can you try the attached patch instead, and post what you see in
> *Messages*?

Here's the result of 'M-x global-text-scale-adjust RET' and then
typing '-' repeatedly (in emacs -Q):

For information about GNU Emacs and the GNU system, type C-h C-a.
global-text-scale-adjust 120 -> 125
Use +, =, -, 0, ESC for further adjustment
global-text-scale-adjust 130 -> 125
Use +, =, -, 0, ESC for further adjustment
global-text-scale-adjust 130 -> 125
Use +, =, -, 0, ESC for further adjustment
global-text-scale-adjust 130 -> 125
Use +, =, -, 0, ESC for further adjustment
You can run the command ‘global-text-scale-adjust’ with C-x C-M-0
Use +, =, -, 0, ESC for further adjustment
global-text-scale-adjust 130 -> 125

bug#59122: 29.0.50; global-text-scale-adjust not working

[Gregory Heytings]

[-- Attachment #1: Type: text/plain, Size: 207 bytes --]


>
> Here's the result of 'M-x global-text-scale-adjust RET' and then typing 
> '-' repeatedly (in emacs -Q):
>

Thanks.  A call to redisplay was missing in the previous patch; the 
attached one should work.

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: Fix-global-face-scaling-bug-due-to-rounding.patch --]
[-- Type: text/x-diff; name=Fix-global-face-scaling-bug-due-to-rounding.patch, Size: 2380 bytes --]

From fa0825822c3ef344a3c18d3466fc4ac1820f91f6 Mon Sep 17 00:00:00 2001
From: Gregory Heytings <gregory@heytings.org>
Date: Thu, 10 Nov 2022 16:58:06 +0000
Subject: [PATCH] Fix global face scaling bug due to rounding.

* lisp/face-remap.el (global-text-scale-adjust): Try again if the face
height did not actually change.
(global-text-scale-adjust--increment-factor): New internal variable.
Fixes bug#59122.
---
 lisp/face-remap.el | 15 ++++++++++++---
 1 file changed, 12 insertions(+), 3 deletions(-)

diff --git a/lisp/face-remap.el b/lisp/face-remap.el
index 432385587b..3c14085a63 100644
--- a/lisp/face-remap.el
+++ b/lisp/face-remap.el
@@ -461,6 +461,8 @@ global-text-scale-adjust-limits
 
 (defvar global-text-scale-adjust--default-height nil)
 
+(defvar global-text-scale-adjust--increment-factor 5)
+
 ;;;###autoload (define-key ctl-x-map [(control meta ?+)] 'global-text-scale-adjust)
 ;;;###autoload (define-key ctl-x-map [(control meta ?=)] 'global-text-scale-adjust)
 ;;;###autoload (define-key ctl-x-map [(control meta ?-)] 'global-text-scale-adjust)
@@ -499,16 +501,23 @@ global-text-scale-adjust
            (cur (face-attribute 'default :height))
            (inc
             (pcase key
-              (?- (* (- increment) 5))
+              (?- (* (- increment)
+                     global-text-scale-adjust--increment-factor))
               (?0 (- global-text-scale-adjust--default-height cur))
-              (_ (* increment 5))))
+              (_ (* increment
+                    global-text-scale-adjust--increment-factor))))
            (new (+ cur inc)))
       (when (< (car global-text-scale-adjust-limits)
                new
                (cdr global-text-scale-adjust-limits))
         (let ((frame-inhibit-implied-resize
                (not global-text-scale-adjust-resizes-frames)))
-          (set-face-attribute 'default nil :height new)))
+          (set-face-attribute 'default nil :height new)
+          (redisplay 'force)
+          (when (= cur (face-attribute 'default :height))
+            (setq global-text-scale-adjust--increment-factor
+                  (1+ global-text-scale-adjust--increment-factor))
+            (global-text-scale-adjust increment))))
       (when (characterp key)
         (set-transient-map
          (let ((map (make-sparse-keymap)))
-- 
2.35.1

bug#59122: 29.0.50; global-text-scale-adjust not working

[Stefan Kangas]

Gregory Heytings <gregory@heytings.org> writes:

> Thanks.  A call to redisplay was missing in the previous patch; the
> attached one should work.

Thanks, I can confirm that this patch works.

bug#59122: 29.0.50; global-text-scale-adjust not working

[Rudolf Adamkovič via Bug reports for GNU Emacs, the Swiss army knife of text editors]

Stefan Kangas <stefankangas@gmail.com> writes:

> Thanks, I can confirm that this patch works.

Works here too, but the function still increases the font size right
after I execute it.

In other words, to have *no change* in font size, I have do:

1. type `M-x' and `global-text-scale-adjust' and `RET'
2. type `-'
3. type `q'

`text-scale-adjust' does this too, so I guess ... a feature?

Also, the two function now scale super-duper differently. :-/

Rudy
-- 
"Genius is 1% inspiration and 99% perspiration."
-- Thomas Alva Edison, 1932

Rudolf Adamkovič <salutis@me.com> [he/him]
Studenohorská 25
84103 Bratislava
Slovakia

bug#59122: 29.0.50; global-text-scale-adjust not working

[Stefan Kangas]

Rudolf Adamkovič <salutis@me.com> writes:

> Works here too, but the function still increases the font size right
> after I execute it.
>
> In other words, to have *no change* in font size, I have do:
>
> 1. type `M-x' and `global-text-scale-adjust' and `RET'
> 2. type `-'
> 3. type `q'
>
> `text-scale-adjust' does this too, so I guess ... a feature?

I guess the idea is that you should invoke it with `C-x C-M-0'?  But
that seems to have another problem with the patch - when I type it I
get:

Debugger entered--Lisp error: (error "Lisp nesting exceeds
‘max-lisp-eval-depth’")
  redisplay--unhighlight-overlay-function(nil)
  redisplay--update-region-highlight(#<window 3 on *scratch*>)
  run-hook-with-args(redisplay--update-region-highlight #<window 3 on
*scratch*>)
  redisplay--pre-redisplay-functions(nil)
  redisplay_internal\ \(C\ function\)()
  redisplay(force)
  global-text-scale-adjust(1)
[[[... 1590 identical lines elided /SK ...]]
  global-text-scale-adjust(1)
  funcall-interactively(global-text-scale-adjust 1)
  call-interactively(global-text-scale-adjust nil nil)
  command-execute(global-text-scale-adjust)

> Also, the two function now scale super-duper differently. :-/

Do you mean 'text-scale-adjust' and 'global-text-scale-adjust'?  I see
the same here.

bug#59122: 29.0.50; global-text-scale-adjust not working

[Eli Zaretskii]

> Cc: Gregory Heytings <gregory@heytings.org>, 59122@debbugs.gnu.org
> From: Stefan Kangas <stefankangas@gmail.com>
> Date: Sun, 13 Nov 2022 04:05:56 +0100
> 
> Rudolf Adamkovič <salutis@me.com> writes:
> 
> > Works here too, but the function still increases the font size right
> > after I execute it.
> >
> > In other words, to have *no change* in font size, I have do:
> >
> > 1. type `M-x' and `global-text-scale-adjust' and `RET'
> > 2. type `-'
> > 3. type `q'
> >
> > `text-scale-adjust' does this too, so I guess ... a feature?
> 
> I guess the idea is that you should invoke it with `C-x C-M-0'?  But
> that seems to have another problem with the patch - when I type it I
> get:
> 
> Debugger entered--Lisp error: (error "Lisp nesting exceeds
> ‘max-lisp-eval-depth’")

I cannot reproduce this error, "C-x C-M-0" works as expected here.

Do you see this in "emacs -Q"?

bug#59122: 29.0.50; global-text-scale-adjust not working

[Stefan Kangas]

Eli Zaretskii <eliz@gnu.org> writes:

>> Debugger entered--Lisp error: (error "Lisp nesting exceeds
>> ‘max-lisp-eval-depth’")
>
> I cannot reproduce this error, "C-x C-M-0" works as expected here.

I only tried reproducing it on macOS, so it could be macOS specific.

> Do you see this in "emacs -Q"?

Yes.

bug#59122: 29.0.50; global-text-scale-adjust not working

[Gregory Heytings]

[-- Attachment #1: Type: text/plain, Size: 622 bytes --]


>
> I guess the idea is that you should invoke it with `C-x C-M-0'?  But 
> that seems to have another problem with the patch - when I type it I 
> get:
>

Thanks.  This bug is fixed in the attached patch.

>> Also, the two function now scale super-duper differently. :-/
>
> Do you mean 'text-scale-adjust' and 'global-text-scale-adjust'?  I see 
> the same here.
>

Yes.  As I said earlier, global-text-scale-adjust scales smoothly, and 
text-scale-adjust scales fast.  That was a design choice when implementing 
global-text-scale-adjust.  It should of course be possible to make 
text-scale-adjust scale smoothly too.

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: Fix-global-face-scaling-bug-due-to-rounding.patch --]
[-- Type: text/x-diff; name=Fix-global-face-scaling-bug-due-to-rounding.patch, Size: 2451 bytes --]

From 3a277b9756499a392b70b74324e4e746b0ae066d Mon Sep 17 00:00:00 2001
From: Gregory Heytings <gregory@heytings.org>
Date: Sun, 13 Nov 2022 09:14:03 +0000
Subject: [PATCH] Fix global face scaling bug due to rounding.

* lisp/face-remap.el (global-text-scale-adjust): Try again if the face
height should have changed but did not actually change.
(global-text-scale-adjust--increment-factor): New internal variable.
Fixes bug#59122.
---
 lisp/face-remap.el | 16 +++++++++++++---
 1 file changed, 13 insertions(+), 3 deletions(-)

diff --git a/lisp/face-remap.el b/lisp/face-remap.el
index 432385587b..33ffb41ec9 100644
--- a/lisp/face-remap.el
+++ b/lisp/face-remap.el
@@ -461,6 +461,8 @@ global-text-scale-adjust-limits
 
 (defvar global-text-scale-adjust--default-height nil)
 
+(defvar global-text-scale-adjust--increment-factor 5)
+
 ;;;###autoload (define-key ctl-x-map [(control meta ?+)] 'global-text-scale-adjust)
 ;;;###autoload (define-key ctl-x-map [(control meta ?=)] 'global-text-scale-adjust)
 ;;;###autoload (define-key ctl-x-map [(control meta ?-)] 'global-text-scale-adjust)
@@ -499,16 +501,24 @@ global-text-scale-adjust
            (cur (face-attribute 'default :height))
            (inc
             (pcase key
-              (?- (* (- increment) 5))
+              (?- (* (- increment)
+                     global-text-scale-adjust--increment-factor))
               (?0 (- global-text-scale-adjust--default-height cur))
-              (_ (* increment 5))))
+              (_ (* increment
+                    global-text-scale-adjust--increment-factor))))
            (new (+ cur inc)))
       (when (< (car global-text-scale-adjust-limits)
                new
                (cdr global-text-scale-adjust-limits))
         (let ((frame-inhibit-implied-resize
                (not global-text-scale-adjust-resizes-frames)))
-          (set-face-attribute 'default nil :height new)))
+          (set-face-attribute 'default nil :height new)
+          (redisplay 'force)
+          (when (and (not (= key ?0))
+                     (= cur (face-attribute 'default :height)))
+            (setq global-text-scale-adjust--increment-factor
+                  (1+ global-text-scale-adjust--increment-factor))
+            (global-text-scale-adjust increment))))
       (when (characterp key)
         (set-transient-map
          (let ((map (make-sparse-keymap)))
-- 
2.35.1

bug#59122: 29.0.50; global-text-scale-adjust not working

[Stefan Kangas]

Gregory Heytings <gregory@heytings.org> writes:

> Thanks.  This bug is fixed in the attached patch.

I can verify that the bug is fixed in that patch.  Thanks.

> It should of course be possible to make text-scale-adjust scale
> smoothly too.

I think that would be good, to make things more consistent.  Even better
if we could customize the step size, and/or the method of scaling for
both commands.  One defcustom could be shared by both.

bug#59122: 29.0.50; global-text-scale-adjust not working

[Eli Zaretskii]

> Cc: 59122@debbugs.gnu.org, Rudolf Adamkovič <salutis@me.com>
> From: Stefan Kangas <stefankangas@gmail.com>
> Date: Sun, 13 Nov 2022 05:48:26 -0800
> 
> Gregory Heytings <gregory@heytings.org> writes:
> 
> > Thanks.  This bug is fixed in the attached patch.
> 
> I can verify that the bug is fixed in that patch.  Thanks.
> 
> > It should of course be possible to make text-scale-adjust scale
> > smoothly too.
> 
> I think that would be good, to make things more consistent.  Even better
> if we could customize the step size, and/or the method of scaling for
> both commands.  One defcustom could be shared by both.

The change in text-scale-adjust should be backward-compatible by
default, otherwise I'll object to it.

bug#59122: 29.0.50; global-text-scale-adjust not working

[Gregory Heytings]

>>> It should of course be possible to make text-scale-adjust scale 
>>> smoothly too.
>>
>> I think that would be good, to make things more consistent.  Even 
>> better if we could customize the step size, and/or the method of 
>> scaling for both commands.  One defcustom could be shared by both.
>
> The change in text-scale-adjust should be backward-compatible by 
> default, otherwise I'll object to it.
>

I know.  And I don't see how to reconcile the two conflicting goals here: 
Stefan K wants consistence, you want backward compatibility.

bug#59122: 29.0.50; global-text-scale-adjust not working

[Eli Zaretskii]

> Date: Sun, 13 Nov 2022 19:39:48 +0000
> From: Gregory Heytings <gregory@heytings.org>
> cc: Stefan Kangas <stefankangas@gmail.com>, salutis@me.com, 
>     59122@debbugs.gnu.org
> 
> 
> >>> It should of course be possible to make text-scale-adjust scale 
> >>> smoothly too.
> >>
> >> I think that would be good, to make things more consistent.  Even 
> >> better if we could customize the step size, and/or the method of 
> >> scaling for both commands.  One defcustom could be shared by both.
> >
> > The change in text-scale-adjust should be backward-compatible by 
> > default, otherwise I'll object to it.
> >
> 
> I know.  And I don't see how to reconcile the two conflicting goals here: 
> Stefan K wants consistence, you want backward compatibility.

If the consistent operation is opt-in, I won't object.

bug#59122: 29.0.50; global-text-scale-adjust not working

[Gregory Heytings]

Pushed, and closing.

I also updated the docstrings of global-text-scale-adjust and 
text-scale-adjust.  Making text-scale-adjust behave like 
global-text-scale-adjust only requires to set text-scale-mode-step to a 
small enough factor, so it's unnecessary to add another defcustom.

bug#59122: 29.0.50; global-text-scale-adjust not working

[Eli Zaretskii]

> Cc: 59122@debbugs.gnu.org
> Date: Sun, 13 Nov 2022 01:23:58 +0100
> From:  Rudolf Adamkovič via "Bug reports for GNU Emacs,
>  the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
> 
> Stefan Kangas <stefankangas@gmail.com> writes:
> 
> > Thanks, I can confirm that this patch works.
> 
> Works here too, but the function still increases the font size right
> after I execute it.

This is the intended behavior, so no need to try to "fix" it.

> In other words, to have *no change* in font size, I have do:
> 
> 1. type `M-x' and `global-text-scale-adjust' and `RET'
> 2. type `-'
> 3. type `q'
> 
> `text-scale-adjust' does this too, so I guess ... a feature?

Yes, but why would you need to invoke the command if you don't want to
change the size of the font?  What kind of use case is that?

bug#59122: 29.0.50; global-text-scale-adjust not working

[Gregory Heytings]

>> In other words, to have *no change* in font size, I have do:
>>
>> 1. type `M-x' and `global-text-scale-adjust' and `RET'
>> 2. type `-'
>> 3. type `q'
>>
>> `text-scale-adjust' does this too, so I guess ... a feature?
>
> Yes, but why would you need to invoke the command if you don't want to 
> change the size of the font?  What kind of use case is that?
>

For the sake of completeness: these commands are meant to be used with 
their bindings, which are

C-<wheel-up> / C-<wheel-down> / C-x C-- / C-x C-+ / C-x C-0 / C-x C-=

and

C-M-<wheel-up> / C-M-<wheel-down> / C-x C-M-- / C-x C-M-+ / C-x C-M-0 / C-x C-M-=

bug#59122: 29.0.50; global-text-scale-adjust not working

[Rudolf Adamkovič via Bug reports for GNU Emacs, the Swiss army knife of text editors]

Eli Zaretskii <eliz@gnu.org> writes:

>> Works here too, but the function still increases the font size right
>> after I execute it.
>
> This is the intended behavior, so no need to try to "fix" it.

I see.  I apologize for the noise, then.

>> In other words, to have *no change* in font size, I have do:
>> 
>> 1. type `M-x' and `global-text-scale-adjust' and `RET'
>> 2. type `-'
>> 3. type `q'
>> 
>> `text-scale-adjust' does this too, so I guess ... a feature?
>
> Yes, but why would you need to invoke the command if you don't want to
> change the size of the font?  What kind of use case is that?

Statistically, half of the time, when I invoke the command, I want to
make the font smaller.  In that case, making the font larger first leads
to both confusion and at least one unnecessary key press.

Rudy
-- 
"The introduction of suitable abstractions is our only mental aid to
organize and master complexity."
-- Edsger Wybe Dijkstra, 1930-2002

Rudolf Adamkovič <salutis@me.com> [he/him]
Studenohorská 25
84103 Bratislava
Slovakia

bug#59122: 29.0.50; global-text-scale-adjust not working

[Stephen Berman]

On Sun, 13 Nov 2022 23:37:23 +0100 Rudolf Adamkovič via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org> wrote:

> Eli Zaretskii <eliz@gnu.org> writes:
>
>>> Works here too, but the function still increases the font size right
>>> after I execute it.
>>
>> This is the intended behavior, so no need to try to "fix" it.
>
> I see.  I apologize for the noise, then.
>
>>> In other words, to have *no change* in font size, I have do:
>>> 
>>> 1. type `M-x' and `global-text-scale-adjust' and `RET'
>>> 2. type `-'
>>> 3. type `q'
>>> 
>>> `text-scale-adjust' does this too, so I guess ... a feature?
>>
>> Yes, but why would you need to invoke the command if you don't want to
>> change the size of the font?  What kind of use case is that?
>
> Statistically, half of the time, when I invoke the command, I want to
> make the font smaller.  In that case, making the font larger first leads
> to both confusion and at least one unnecessary key press.

Invoking it like this: `M-- M-x global-text-scale-adjust' shrinks the
font size.

Steve Berman

bug#59122: 29.0.50; global-text-scale-adjust not working

[Eli Zaretskii]

> From: Rudolf Adamkovič <salutis@me.com>
> Cc: stefankangas@gmail.com, gregory@heytings.org, 59122@debbugs.gnu.org
> Date: Sun, 13 Nov 2022 23:37:23 +0100
> 
> > Yes, but why would you need to invoke the command if you don't want to
> > change the size of the font?  What kind of use case is that?
> 
> Statistically, half of the time, when I invoke the command, I want to
> make the font smaller.  In that case, making the font larger first leads
> to both confusion and at least one unnecessary key press.

That still doesn't explain why you'd invoke the command with the zero
prefix argument.  I'd expect you to invoke it with a negative argument
instead.

bug#59122: 29.0.50; global-text-scale-adjust not working

[Eli Zaretskii]

> Cc: 59122@debbugs.gnu.org, Rudolf Adamkovič <salutis@me.com>
> From: Stefan Kangas <stefankangas@gmail.com>
> Date: Wed, 9 Nov 2022 14:28:54 +0100
> 
> I can reproduce this bug on macOS 12.6.1 (OP is on 12.6).
> 
> After pressing '+', '-' still doesn't decrease the font size.  I can
> only increase it using '+'.

Please step with Edebug into global-text-scale-adjust, and tell what
do you see in the variable 'key' in the following fragment from the
command:

    (let* ((key (event-basic-type last-command-event))
           (echo-keystrokes nil)
           (cur (face-attribute 'default :height))
           (inc
            (pcase key
              (?- (* (- increment) 5))
              (?0 (- global-text-scale-adjust--default-height cur))
              (_ (* increment 5))))

bug#59122: 29.0.50; global-text-scale-adjust not working

[Stefan Kangas]

Eli Zaretskii <eliz@gnu.org> writes:

> Please step with Edebug into global-text-scale-adjust, and tell what
> do you see in the variable 'key' in the following fragment from the
> command:
>
>     (let* ((key (event-basic-type last-command-event))

On the first invocation of 'global-text-scale-adjust':

last-command-event: 13 (#o15, #xd, ?\C-m)
key: 109 (#o155, #x6d, ?m)

When I then type '-', I see:

last-command-event: 45 (#o55, #x2d, ?-)
key: 45 (#o55, #x2d, ?-)

>            (echo-keystrokes nil)
>            (cur (face-attribute 'default :height))
>            (inc
>             (pcase key
>               (?- (* (- increment) 5))
>               (?0 (- global-text-scale-adjust--default-height cur))
>               (_ (* increment 5))))