From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Florian Rommel Newsgroups: gmane.emacs.devel Subject: Support fullscreen values fullheight and fullwidth on pgtk Date: Wed, 01 Jun 2022 16:57:04 +0200 Message-ID: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-Rb+VtWSXss8U2m4f96dy" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="502"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Evolution 3.44.2 To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Jun 02 07:09:37 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nwd5U-000ASN-Sh for ged-emacs-devel@m.gmane-mx.org; Thu, 02 Jun 2022 07:09:36 +0200 Original-Received: from localhost ([::1]:34776 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nwd5T-0004dF-Qg for ged-emacs-devel@m.gmane-mx.org; Thu, 02 Jun 2022 01:09:35 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:52926) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nwPmf-0007aP-0I for emacs-devel@gnu.org; Wed, 01 Jun 2022 10:57:17 -0400 Original-Received: from read.uberspace.de ([185.26.156.133]:47296) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nwPmc-0006MN-Nk for emacs-devel@gnu.org; Wed, 01 Jun 2022 10:57:16 -0400 Original-Received: (qmail 2069 invoked by uid 990); 1 Jun 2022 14:57:05 -0000 Authentication-Results: read.uberspace.de; auth=pass (plain) X-Rspamd-Bar: - X-Rspamd-Report: BAYES_HAM(-2.995976) MIME_GOOD(-0.1) MIME_BASE64_TEXT_BOGUS(1) MIME_BASE64_TEXT(0.1) X-Rspamd-Score: -1.995976 Original-Received: from unknown (HELO unkown) (::1) by read.uberspace.de (Haraka/2.8.28) with ESMTPSA; Wed, 01 Jun 2022 16:57:05 +0200 Received-SPF: pass client-ip=185.26.156.133; envelope-from=mail@florommel.de; helo=read.uberspace.de X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, MSGID_FROM_MTA_HEADER=0.001, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Mailman-Approved-At: Thu, 02 Jun 2022 01:06:58 -0400 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:290539 Archived-At: --=-Rb+VtWSXss8U2m4f96dy Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable This is a suggestion to support the values 'fullheight and 'fullwidth for the fullscreen frame parameter on pgtk. Background: I undecorate the frame when it is maximized or "tiled" (in Gnome) to the left or right (-> fullheight, currently not supported on pgtk - only with the X backend). The patch uses the GDK_WINDOW_STATE_*_TILED and GDK_WINDOW_STATE_*_RESIZABLE flags that are available since GTK 3.22.23. A value of 'fullheight is set if the top and the bottom edges are marked as tiled and not resizable; 'fullwidth is set if the left and right edges are marked as tiled and not resizable. So, is the introduced behavior correct? I think it is consistent with the description in the Emacs manual: "a fullwidth frame is as wide as possible, a fullheight frame is as tall as possible". On Gnome, it works as expected. Other desktop environments, such as KDE, Xfce or tiling window managers don't seem to support the GTK_WINDOW_STATE_*_{TILED/RESIZABLE} flags, so fullheight and fullwidth will still never be set there (however, this also seems to be the case with the Emacs X backend). Regards, Flo --=-Rb+VtWSXss8U2m4f96dy Content-Disposition: attachment; filename*0=0001-pgtk-Add-support-for-fullscreen-values-fullheight-an.pat; filename*1=ch Content-Type: text/x-patch; name="0001-pgtk-Add-support-for-fullscreen-values-fullheight-an.patch"; charset="UTF-8" Content-Transfer-Encoding: base64 RnJvbSAyZWMzZWU3M2NjN2NlMmEzOGVkNjlhOTM4ZDg1OGJiYTI4NmFjYThhIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBGbG9yaWFuIFJvbW1lbCA8bWFpbEBmbG9yb21tZWwuZGU+CkRh dGU6IFdlZCwgMSBKdW4gMjAyMiAxNjoxMzoyMSArMDIwMApTdWJqZWN0OiBbUEFUQ0hdIHBndGs6 IEFkZCBzdXBwb3J0IGZvciBmdWxsc2NyZWVuIHZhbHVlcyBmdWxsaGVpZ2h0IGFuZAogZnVsbHdp ZHRoCgoqIHNyYy9wZ3RrdGVybS5jICh3aW5kb3dfc3RhdGVfZXZlbnQpOiBTZXQgZnVsbGhlaWdo dC9mdWxsd2VpZ2h0CnBhcmFtZXRlciBkZXBlbmRpbmcgb24gbmV3X3dpbmRvd19zdGF0ZQotLS0K IHNyYy9wZ3RrdGVybS5jIHwgMjcgKysrKysrKysrKysrKysrKysrLS0tLS0tLS0tCiAxIGZpbGUg Y2hhbmdlZCwgMTggaW5zZXJ0aW9ucygrKSwgOSBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9z cmMvcGd0a3Rlcm0uYyBiL3NyYy9wZ3RrdGVybS5jCmluZGV4IGRhOTU4YTY2NjQuLmVlZTBkZjk3 OWIgMTAwNjQ0Ci0tLSBhL3NyYy9wZ3RrdGVybS5jCisrKyBiL3NyYy9wZ3RrdGVybS5jCkBAIC01 NDIwLDYgKzU0MjAsNyBAQCB3aW5kb3dfc3RhdGVfZXZlbnQgKEd0a1dpZGdldCAqd2lkZ2V0LAog CQkgICAgZ3BvaW50ZXIgKnVzZXJfZGF0YSkKIHsKICAgc3RydWN0IGZyYW1lICpmID0gcGd0a19h bnlfd2luZG93X3RvX2ZyYW1lIChldmVudC0+d2luZG93X3N0YXRlLndpbmRvdyk7CisgIEdka1dp bmRvd1N0YXRlIG5ld19zdGF0ZSA9IGV2ZW50LT53aW5kb3dfc3RhdGUubmV3X3dpbmRvd19zdGF0 ZTsKICAgdW5pb24gYnVmZmVyZWRfaW5wdXRfZXZlbnQgaW5ldjsKIAogICBFVkVOVF9JTklUIChp bmV2LmllKTsKQEAgLTU0MjgsNyArNTQyOSw3IEBAIHdpbmRvd19zdGF0ZV9ldmVudCAoR3RrV2lk Z2V0ICp3aWRnZXQsCiAKICAgaWYgKGYpCiAgICAgewotICAgICAgaWYgKGV2ZW50LT53aW5kb3df c3RhdGUubmV3X3dpbmRvd19zdGF0ZSAmIEdES19XSU5ET1dfU1RBVEVfRk9DVVNFRCkKKyAgICAg IGlmIChuZXdfc3RhdGUgJiBHREtfV0lORE9XX1NUQVRFX0ZPQ1VTRUQpCiAJewogCSAgaWYgKEZS QU1FX0lDT05JRklFRF9QIChmKSkKIAkgICAgewpAQCAtNTQ0NCwxNyArNTQ0NSwyNiBAQCB3aW5k b3dfc3RhdGVfZXZlbnQgKEd0a1dpZGdldCAqd2lkZ2V0LAogCX0KICAgICB9CiAKLSAgaWYgKGV2 ZW50LT53aW5kb3dfc3RhdGUubmV3X3dpbmRvd19zdGF0ZQotICAgICAgJiBHREtfV0lORE9XX1NU QVRFX0ZVTExTQ1JFRU4pCisgIGlmIChuZXdfc3RhdGUgJiBHREtfV0lORE9XX1NUQVRFX0ZVTExT Q1JFRU4pCiAgICAgc3RvcmVfZnJhbWVfcGFyYW0gKGYsIFFmdWxsc2NyZWVuLCBRZnVsbGJvdGgp OwotICBlbHNlIGlmIChldmVudC0+d2luZG93X3N0YXRlLm5ld193aW5kb3dfc3RhdGUKLQkgICAm IEdES19XSU5ET1dfU1RBVEVfTUFYSU1JWkVEKQorICBlbHNlIGlmIChuZXdfc3RhdGUgJiBHREtf V0lORE9XX1NUQVRFX01BWElNSVpFRCkKICAgICBzdG9yZV9mcmFtZV9wYXJhbSAoZiwgUWZ1bGxz Y3JlZW4sIFFtYXhpbWl6ZWQpOworI2lmIEdUS19DSEVDS19WRVJTSU9OICgzLCAyMiwgMjMpCisg IGVsc2UgaWYgKChuZXdfc3RhdGUgJiBHREtfV0lORE9XX1NUQVRFX1RPUF9USUxFRCkgJiYKKwkg ICAobmV3X3N0YXRlICYgR0RLX1dJTkRPV19TVEFURV9CT1RUT01fVElMRUQpICYmCisJICAgIShu ZXdfc3RhdGUgJiBHREtfV0lORE9XX1NUQVRFX1RPUF9SRVNJWkFCTEUpICYmCisJICAgIShuZXdf c3RhdGUgJiBHREtfV0lORE9XX1NUQVRFX0JPVFRPTV9SRVNJWkFCTEUpKQorICAgIHN0b3JlX2Zy YW1lX3BhcmFtIChmLCBRZnVsbHNjcmVlbiwgUWZ1bGxoZWlnaHQpOworICBlbHNlIGlmICgobmV3 X3N0YXRlICYgR0RLX1dJTkRPV19TVEFURV9MRUZUX1RJTEVEKSAmJgorCSAgIChuZXdfc3RhdGUg JiBHREtfV0lORE9XX1NUQVRFX1JJR0hUX1RJTEVEKSAmJgorCSAgICEobmV3X3N0YXRlICYgR0RL X1dJTkRPV19TVEFURV9MRUZUX1JFU0laQUJMRSkgJiYKKwkgICAhKG5ld19zdGF0ZSAmIEdES19X SU5ET1dfU1RBVEVfUklHSFRfUkVTSVpBQkxFKSkKKyAgICBzdG9yZV9mcmFtZV9wYXJhbSAoZiwg UWZ1bGxzY3JlZW4sIFFmdWxsd2lkdGgpOworI2VuZGlmCiAgIGVsc2UKICAgICBzdG9yZV9mcmFt ZV9wYXJhbSAoZiwgUWZ1bGxzY3JlZW4sIFFuaWwpOwogCi0gIGlmIChldmVudC0+d2luZG93X3N0 YXRlLm5ld193aW5kb3dfc3RhdGUKLSAgICAgICYgR0RLX1dJTkRPV19TVEFURV9JQ09OSUZJRUQp CisgIGlmIChuZXdfc3RhdGUgJiBHREtfV0lORE9XX1NUQVRFX0lDT05JRklFRCkKICAgICBTRVRf RlJBTUVfSUNPTklGSUVEIChmLCB0cnVlKTsKICAgZWxzZQogICAgIHsKQEAgLTU0NjQsOCArNTQ3 NCw3IEBAIHdpbmRvd19zdGF0ZV9ldmVudCAoR3RrV2lkZ2V0ICp3aWRnZXQsCiAgICAgICBTRVRf RlJBTUVfSUNPTklGSUVEIChmLCBmYWxzZSk7CiAgICAgfQogCi0gIGlmIChldmVudC0+d2luZG93 X3N0YXRlLm5ld193aW5kb3dfc3RhdGUKLSAgICAgICYgR0RLX1dJTkRPV19TVEFURV9TVElDS1kp CisgIGlmIChuZXdfc3RhdGUgJiBHREtfV0lORE9XX1NUQVRFX1NUSUNLWSkKICAgICBzdG9yZV9m cmFtZV9wYXJhbSAoZiwgUXN0aWNreSwgUXQpOwogICBlbHNlCiAgICAgc3RvcmVfZnJhbWVfcGFy YW0gKGYsIFFzdGlja3ksIFFuaWwpOwotLSAKMi4zNi4xCgo= --=-Rb+VtWSXss8U2m4f96dy--